It's ready to go. Thanks Wayne!
Adam Wolf
On Sun, Jun 17, 2018, 11:53 AM Wayne Stambaugh wrote:
> Hey Adam,
>
> I take it from the discussion that this patch is ready to go. Let me
> know and I will get it committed today.
>
> For Adam and all of you fathers out there, have a Happy Father's
Hey Adam,
I take it from the discussion that this patch is ready to go. Let me
know and I will get it committed today.
For Adam and all of you fathers out there, have a Happy Father's Day!
Cheers,
Wayne
On 06/12/2018 10:39 PM, Adam Wolf wrote:
> Hi folks!
>
> This patch is meant to fix a
It was already working in one of the modes, and the patch makes it so
it works in both modes.
Of course, I'd love to have another person try it and make sure it
works for them too.
Adam
On Fri, Jun 15, 2018 at 12:01 PM Bernhard Stegmaier
wrote:
>
> Adam, does the patch fix STEP export for both
Adam, does the patch fix STEP export for both kicad.app and standalone pcbnew?
If not, if you like I could try to have a look at the weekend if we can add
some check for standalone to get both working for v5 now.
I don’t know exactly, but I think there should be similar stuff in the code
No comment changes or shaming are required. We are all guilty of it to
make short and some times not so short term fixes ;)
Wayne
On 06/15/2018 12:39 PM, Adam Wolf wrote:
> I would even commit to adding a comment saying "Adam says this is
> temporary and should be removed during the V6
I would even commit to adding a comment saying "Adam says this is
temporary and should be removed during the V6 development efforts", so
folks can more easily shame me if it ends up staying around for longer
than expected :)
Adam
On Fri, Jun 15, 2018 at 11:34 AM Wayne Stambaugh wrote:
>
> I'm
I'm not opposed to this patch if it's merely a short tern solution to a
larger problem. I would rather macos support STEP export for v5.
Hopefully a cleaner long term solution can be found as part of the v6
development as the patch adds some rather ugly #ifdef/#endif code.
Cheers,
Wayne
On
Hi Adam/Bernhard-
Thanks for the excellent background and what looks like a good plan during
v6. If I understand correctly, the thought is that this patch is temporary
for v5 and will be addressed with the rest of the paths during v6.
If that is correct, does anyone have objections to this
That is correct. This is a temporary workaround before some large V6
refactoring (that still needs the details figured out).
Adam
On Fri, Jun 15, 2018 at 9:13 AM Seth Hillbrand wrote:
>
> Hi Adam/Bernhard-
>
> Thanks for the excellent background and what looks like a good plan during
> v6. If
Thanks Bernhard for the clear responses.
1) The only current issue with signing is that the standalone launchers
both live inside and outside the bundle. With all the work I've done on
packaging since V4, we can now give kicad.app a valid signature, but
there's no way to sign the subbundles that
And, for the path stuff…
I think it needs a complete cleanup.
There are paths spread all over the code (directly or indirect by putting some
path fragments together)… for plugins, templates, user-folders, help files, etc.
Worse, all those places are also full of platform #ifdef’s which doesn’t
Yes, that’s more or less what I made long ago.
Basically everything is packed into the main kicad app.
This was done to have all the dependencies only in one place.
There is just one kicad app.
"Apps" like pcbnew are not really apps, but it is main kicad binary/executable
(project manager)
The symlinked subbundles date back to the original KiCad mac packaging
work, before V4 came out. There is a pretty massive amount of code in
our CMake and KiCad already that support how this works. I think
Bernhard was the main driver of this work, but I am not sure.
Specifically, the relative
Hi Adam-
Is there a reason why the kicad2step is installed in the KiCad base
application rather than the pcbnew application? I didn't look into this in
depth but I wonder if we can avoid code dealing with a specific packaging
scenario?
Alternatively, we might put a variable in CMAKE defining
Yeah, this is actually all over the source code. I'm starting to collect a
list of them for V6... but I shall say no more until I'm ready with V5 :)
On Thu, Jun 14, 2018, 3:32 AM Nick Østergaard wrote:
> Ok.
>
> 2018-06-14 9:37 GMT+02:00 Bernhard Stegmaier :
>
>> I didn’t test this patch, but…
Ok.
2018-06-14 9:37 GMT+02:00 Bernhard Stegmaier :
> I didn’t test this patch, but… something like a install prefix path is not
> valid for a bundle.
> A bundle is a self-contained entity and has no fixed location. You can put
> it wherever you want.
> So, everything has to be relative to main
I didn’t test this patch, but… something like a install prefix path is not
valid for a bundle.
A bundle is a self-contained entity and has no fixed location. You can put it
wherever you want.
So, everything has to be relative to main binary or bundle location.
Regards,
Bernhard
> On 14. Jun
It seems a bit strange to be that relative paths like that has to be used,
can't some cmake install prefix path be used wheni is a bundle? Is this
also how it is done for other parts of kicad?
2018-06-13 4:39 GMT+02:00 Adam Wolf :
> Hi folks!
>
> This patch is meant to fix a crash Seth found
Hi folks!
This patch is meant to fix a crash Seth found when exporting STEP from
standalone pcbnew on macOS.
Thanks! My apologies for having this so late in the cycle. this is
going to be an amazing release for everyone, especially macOS users!
Adam Wolf
19 matches
Mail list logo
