Re: [Kicad-developers] Automatic label rotation

2022-04-16 Thread Seth Hillbrand 
Hello Miklos-

Thank you for the useful suggestion.

Please open a merge request on GitLab.  This will help us to more easily
review the changes you are proposing.

Best,
Seth

On Sat, Apr 16, 2022 at 7:07 AM Miklos Marton 
wrote:

> Dear Kicad developers!
>
> I made a feature which allows automatic alignment of the hierarchial and
> global labels depending on where did they got placed.
> I would like to have some discussion about it before I submit a MR.
>
> The code lives here:
>
> https://gitlab.com/martonmiklos/kicad/-/tree/add_label_rotate
>
> You could find a short video about what it does:
>
> https://www.youtube.com/watch?v=CGyEttFy7PM
>
> At the moment it is limited to hierarchial and global labels, and only the
> following connections:
>
>- Wires
>- Symbol pins
>- Bus entries
>
> Are there any other label types where this auto alignment feature would
> make sense?
>
> Are there any connection points where it could be useful (other than than
> what is implemented now)?
>
> I found two other possible item types in the code: SCH_SHEET_PIN_T,
> SCH_PIN_T.
>
> As for SCH_SHEET_PIN_T I added hierarchial sheet symbols and added the
> hierarchual pins to them,
> however if I place a global label right into the sheet imported pins they
> does not get connected automatically:
> if I move away the placed label no wires got added (like they do when I
> place a label on a symbol's pin).
>
> About the SCH_PIN_T I thought that the power taps are fall into this
> category,
> but it looks like that they are not (simply Symbol pins at least for the
> GND).
>
> I have wondered if the temporary label alignment change should be
> visualized when the cursor get moved above a placement point,
> however it might be just waste of computational time.
>
> --
> Best regards,
> Miklos Marton
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


-- 
[image: KiCad Services Corporation Logo]
Seth Hillbrand
*Lead Developer*
+1-530-302-5483‬
Long Beach, CA
[email protected]
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Automatic label rotation

2022-04-16 Thread Miklos Marton 

Dear Kicad developers!

I made a feature which allows automatic alignment of the hierarchial and 
global labels depending on where did they got placed.

I would like to have some discussion about it before I submit a MR.

The code lives here:

https://gitlab.com/martonmiklos/kicad/-/tree/add_label_rotate 



You could find a short video about what it does:

https://www.youtube.com/watch?v=CGyEttFy7PM

At the moment it is limited to hierarchial and global labels, and only 
the following connections:


 * Wires
 * Symbol pins
 * Bus entries

Are there any other label types where this auto alignment feature would 
make sense?


Are there any connection points where it could be useful (other than 
than what is implemented now)?


I found two other possible item types in the code: SCH_SHEET_PIN_T, 
SCH_PIN_T.


As for SCH_SHEET_PIN_T I added hierarchial sheet symbols and added the 
hierarchual pins to them,
however if I place a global label right into the sheet imported pins 
they does not get connected automatically:
if I move away the placed label no wires got added (like they do when I 
place a label on a symbol's pin).


About the SCH_PIN_T I thought that the power taps are fall into this 
category,
but it looks like that they are not (simply Symbol pins at least for the 
GND).


I have wondered if the temporary label alignment change should be 
visualized when the cursor get moved above a placement point,

however it might be just waste of computational time.

--
Best regards,
Miklos Marton
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp