Re: [Kicad-developers] Pushed change

[Kevin Cozens]

On 2018-03-12 05:03 PM, Jeff Young wrote:

Well, my build is still running so I can’t confirm the fixes yet, but since I 
already broke the build for some I went ahead and pushed “fixes”.


My build with latest hash code of f32f14dc8 completed without error.

--
Cheers!

Kevin.

http://www.ve3syb.ca/| "Nerds make the shiny things that
https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
 | that's why we're powerful"
Owner of Elecraft K2 #2172   |
#include   | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

[Nick Østergaard]

It looks like it just passed the build here,
http://ci.kicad-pcb.org/job/linux-kicad-full-gcc-head/3072/

2018-03-12 22:03 GMT+01:00 Jeff Young :

> Well, my build is still running so I can’t confirm the fixes yet, but
> since I already broke the build for some I went ahead and pushed “fixes”.
>
> We’ll see if they actually are shortly. ;)
>
>
> > On 12 Mar 2018, at 20:33, Kevin Cozens  wrote:
> >
> > On 2018-03-12 03:19 PM, Jeff Young wrote:
> >> I just pushed a change which removes a bunch of unnecessary boilerplate.
> >> But it occurs to me that maybe it’s necessary with pickier
> compilers?  Anyway, if someone could try it on Windows and/or Unix that
> would be great.
> > Oops. Something broke. I'm using g++ (Ubuntu 5.4.0-6ubuntu1~16.04.9)
> 5.4.0 20160609 under Linux Mint 18.3
> >
> >
> > /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp: In member
> function ‘void CVPCB_MAINFRAME::UpdateTitle()’:
> > /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43:
> error: operands to ?: have different types ‘const wxChar* {aka const
> wchar_t*}’ and ‘const wxString’
> >   fn.IsFileWritable() ? wxEmptyString : _( " [Read
> Only]" ) );
> >   ^
> > /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: note:
> and each type can be converted to the other
> > cvpcb/CMakeFiles/cvpcb_kiface.dir/build.make:326: recipe for target
> 'cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o' failed
> > make[2]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o]
> Error 1
> > CMakeFiles/Makefile2:817: recipe for target 
> > 'cvpcb/CMakeFiles/cvpcb_kiface.dir/all'
> failed
> > make[1]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/all] Error 2
> > Makefile:149: recipe for target 'all' failed
> > make: *** [all] Error 2
> >
> >
> > --
> > Cheers!
> >
> > Kevin.
> >
> > http://www.ve3syb.ca/| "Nerds make the shiny things that
> > https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
> > | that's why we're powerful"
> > Owner of Elecraft K2 #2172   |
> > #include   | --Chris Hardwick
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

[Jeff Young]

Well, my build is still running so I can’t confirm the fixes yet, but since I 
already broke the build for some I went ahead and pushed “fixes”.

We’ll see if they actually are shortly. ;)


> On 12 Mar 2018, at 20:33, Kevin Cozens  wrote:
> 
> On 2018-03-12 03:19 PM, Jeff Young wrote:
>> I just pushed a change which removes a bunch of unnecessary boilerplate.
>> But it occurs to me that maybe it’s necessary with pickier compilers?  
>> Anyway, if someone could try it on Windows and/or Unix that would be great.
> Oops. Something broke. I'm using g++ (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 
> 20160609 under Linux Mint 18.3
> 
> 
> /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp: In member function 
> ‘void CVPCB_MAINFRAME::UpdateTitle()’:
> /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: error: 
> operands to ?: have different types ‘const wxChar* {aka const wchar_t*}’ and 
> ‘const wxString’
>   fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" 
> ) );
>   ^
> /home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: note: and 
> each type can be converted to the other
> cvpcb/CMakeFiles/cvpcb_kiface.dir/build.make:326: recipe for target 
> 'cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o' failed
> make[2]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o] Error 1
> CMakeFiles/Makefile2:817: recipe for target 
> 'cvpcb/CMakeFiles/cvpcb_kiface.dir/all' failed
> make[1]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/all] Error 2
> Makefile:149: recipe for target 'all' failed
> make: *** [all] Error 2
> 
> 
> -- 
> Cheers!
> 
> Kevin.
> 
> http://www.ve3syb.ca/| "Nerds make the shiny things that
> https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
> | that's why we're powerful"
> Owner of Elecraft K2 #2172   |
> #include   | --Chris Hardwick
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

[Kevin Cozens]

On 2018-03-12 03:19 PM, Jeff Young wrote:

I just pushed a change which removes a bunch of unnecessary boilerplate.

But it occurs to me that maybe it’s necessary with pickier compilers?  
Anyway, if someone could try it on Windows and/or Unix that would be great.
Oops. Something broke. I'm using g++ (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 
20160609 under Linux Mint 18.3



/home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp: In member 
function ‘void CVPCB_MAINFRAME::UpdateTitle()’:
/home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: error: 
operands to ?: have different types ‘const wxChar* {aka const wchar_t*}’ and 
‘const wxString’
   fn.IsFileWritable() ? wxEmptyString : _( " [Read 
Only]" ) );

   ^
/home/user/Projects/Kicad/kicad/cvpcb/cvpcb_mainframe.cpp:740:43: note: 
and each type can be converted to the other
cvpcb/CMakeFiles/cvpcb_kiface.dir/build.make:326: recipe for target 
'cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o' failed

make[2]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/cvpcb_mainframe.cpp.o] Error 1
CMakeFiles/Makefile2:817: recipe for target 
'cvpcb/CMakeFiles/cvpcb_kiface.dir/all' failed

make[1]: *** [cvpcb/CMakeFiles/cvpcb_kiface.dir/all] Error 2
Makefile:149: recipe for target 'all' failed
make: *** [all] Error 2


--
Cheers!

Kevin.

http://www.ve3syb.ca/| "Nerds make the shiny things that
https://www.patreon.html/KevinCozens | distract the mouth-breathers, and
 | that's why we're powerful"
Owner of Elecraft K2 #2172   |
#include   | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

[Jeff Young]

Cool.  I’ll fix it up.

Cheers,
Jeff.

> On 12 Mar 2018, at 20:07, jp charras  wrote:
> 
> Le 12/03/2018 à 20:53, Jeff Young a écrit :
>> Hi JP,
>> 
>>> On 12 Mar 2018, at 19:40, jp charras  wrote:
>>> 
>>> Le 12/03/2018 à 20:19, Jeff Young a écrit :
 Hi folks,
 
 I just pushed a change which removes a bunch of unnecessary boilerplate.
 
 But it occurs to me that maybe it’s necessary with pickier compilers?  
 Anyway, if someone could try it on Windows and/or Unix that would be great.
 
 Cheers,
 Jeff.
 
>>> Hi Jeff,
>>> 
>>> You fixes can create issues because:
>>> 
>>> fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" )
>>> creates issues because wxEmptyString does not return a wxString, but _( " 
>>> [Read Only]" ) that is a
>>> macro for wxGetTranslation( " [Read Only]" ) returns a wxString
>> 
>> Sure, but they’re getting fed to varargs.  Do any compilers actually bark?  
>> (Mine doesn’t, but that doesn’t mean much.)
> 
> gcc 6.3 on msys2 (and certainly gcc 4.8 on Kubuntu 14.04 LST) complains:
> E:/kicad-launchpad/testing_git/pcbnew/footprint_edit_frame.cpp:802:28: error: 
> operands to ?: have
> different types 'const wxChar* {aka const wchar_t*}' and  'const wxString'
>   writable ? wxEmptyString : _( " [Read Only]" ),
> 
>> 
>>> 
>>> and
>>> 
>>> title.Printf( _( "Eeschema \u2014 %s" ), GetChars( 
>>> GetScreen()->GetFileName() ) );
>>> 
>>> is incorrect because the string inside _() *must be* a ASCII7 string.
>>> This is mandatory for translation tools.
>> 
>> Oops.  Missed that one.
>> 
>> Thanks,
>> Jeff.
>> 
> 
> -- 
> Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

[jp charras]

Le 12/03/2018 à 20:53, Jeff Young a écrit :
> Hi JP,
> 
>> On 12 Mar 2018, at 19:40, jp charras  wrote:
>>
>> Le 12/03/2018 à 20:19, Jeff Young a écrit :
>>> Hi folks,
>>>
>>> I just pushed a change which removes a bunch of unnecessary boilerplate.
>>>
>>> But it occurs to me that maybe it’s necessary with pickier compilers?  
>>> Anyway, if someone could try it on Windows and/or Unix that would be great.
>>>
>>> Cheers,
>>> Jeff.
>>>
>> Hi Jeff,
>>
>> You fixes can create issues because:
>>
>> fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" )
>> creates issues because wxEmptyString does not return a wxString, but _( " 
>> [Read Only]" ) that is a
>> macro for wxGetTranslation( " [Read Only]" ) returns a wxString
> 
> Sure, but they’re getting fed to varargs.  Do any compilers actually bark?  
> (Mine doesn’t, but that doesn’t mean much.)

gcc 6.3 on msys2 (and certainly gcc 4.8 on Kubuntu 14.04 LST) complains:
E:/kicad-launchpad/testing_git/pcbnew/footprint_edit_frame.cpp:802:28: error: 
operands to ?: have
different types 'const wxChar* {aka const wchar_t*}' and  'const wxString'
   writable ? wxEmptyString : _( " [Read Only]" ),

> 
>>
>> and
>>
>> title.Printf( _( "Eeschema \u2014 %s" ), GetChars( 
>> GetScreen()->GetFileName() ) );
>>
>> is incorrect because the string inside _() *must be* a ASCII7 string.
>> This is mandatory for translation tools.
> 
> Oops.  Missed that one.
> 
> Thanks,
> Jeff.
> 

-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

[Jeff Young]

Hi JP,

> On 12 Mar 2018, at 19:40, jp charras  wrote:
> 
> Le 12/03/2018 à 20:19, Jeff Young a écrit :
>> Hi folks,
>> 
>> I just pushed a change which removes a bunch of unnecessary boilerplate.
>> 
>> But it occurs to me that maybe it’s necessary with pickier compilers?  
>> Anyway, if someone could try it on Windows and/or Unix that would be great.
>> 
>> Cheers,
>> Jeff.
>> 
> Hi Jeff,
> 
> You fixes can create issues because:
> 
> fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" )
> creates issues because wxEmptyString does not return a wxString, but _( " 
> [Read Only]" ) that is a
> macro for wxGetTranslation( " [Read Only]" ) returns a wxString

Sure, but they’re getting fed to varargs.  Do any compilers actually bark?  
(Mine doesn’t, but that doesn’t mean much.)

> 
> and
> 
> title.Printf( _( "Eeschema \u2014 %s" ), GetChars( GetScreen()->GetFileName() 
> ) );
> 
> is incorrect because the string inside _() *must be* a ASCII7 string.
> This is mandatory for translation tools.

Oops.  Missed that one.

Thanks,
Jeff.


> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Pushed change

[jp charras]

Le 12/03/2018 à 20:19, Jeff Young a écrit :
> Hi folks,
> 
> I just pushed a change which removes a bunch of unnecessary boilerplate.
> 
> But it occurs to me that maybe it’s necessary with pickier compilers?  
> Anyway, if someone could try it on Windows and/or Unix that would be great.
> 
> Cheers,
> Jeff.
> 
Hi Jeff,

You fixes can create issues because:

fn.IsFileWritable() ? wxEmptyString : _( " [Read Only]" )
creates issues because wxEmptyString does not return a wxString, but _( " [Read 
Only]" ) that is a
macro for wxGetTranslation( " [Read Only]" ) returns a wxString

and

title.Printf( _( "Eeschema \u2014 %s" ), GetChars( GetScreen()->GetFileName() ) 
);

is incorrect because the string inside _() *must be* a ASCII7 string.
This is mandatory for translation tools.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] Pushed change

[Jeff Young]

Hi folks,

I just pushed a change which removes a bunch of unnecessary boilerplate.

But it occurs to me that maybe it’s necessary with pickier compilers?  Anyway, 
if someone could try it on Windows and/or Unix that would be great.

Cheers,
Jeff.


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp