Re: [Kicad-developers] Spaces in library nicknames
We have to leave the spaces for the footprint libraries. Otherwise we will break the behavior that's always been in place. I know it's not the best situation but hopefully it will be fairly short lived. On 04/13/2018 07:32 AM, Maciej Sumiński wrote: > Ok, thank you both for clarification. In such case, I suppose we keep > spaces enabled for footprint library and entry names and disable for > symbol related names. I have found a few places that use different rules > for name validation and I wanted to unify them. > > Cheers, > Orson > > On 04/13/2018 01:30 PM, Wayne Stambaugh wrote: >> Orson, >> >> You must have missed the original conversation. We cannot have spaces >> in symbol library nicknames until the schematic and symbol library file >> formats are implemented. I didn't want to make a change to the current >> schematic file format. Once they are in place, I will remove the spaces >> restriction. >> >> Cheers, >> >> Wayne >> >> On 04/13/2018 05:45 AM, Maciej Sumiński wrote: >>> Another question is whether spaces are considered valid in library item >>> names (symbols/footprints). Should both logical library names and >>> library items permit the same character set? Seems reasonable to me, but >>> I need to be sure. >>> >>> Cheers, >>> Orson >>> >>> On 04/13/2018 11:36 AM, Maciej Sumiński wrote: I have just noticed that one cannot use spaces in symbol library nicknames [1], whereas they are valid for footprint library nicknames [2]. I suppose it should be unified and moved to a function (static method in LIB_ID?) to avoid valid characters sets diversion. I will fix it, but I need to know what is the decision about spaces. Cheers, Orson 1. https://github.com/KiCad/kicad-source-mirror/blob/master/eeschema/dialogs/dialog_sym_lib_table.cpp#L269 2. https://github.com/KiCad/kicad-source-mirror/blob/master/pcbnew/dialogs/dialog_fp_lib_table.cpp#L302 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp >>> >>> >>> >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Spaces in library nicknames
Ok, thank you both for clarification. In such case, I suppose we keep spaces enabled for footprint library and entry names and disable for symbol related names. I have found a few places that use different rules for name validation and I wanted to unify them. Cheers, Orson On 04/13/2018 01:30 PM, Wayne Stambaugh wrote: > Orson, > > You must have missed the original conversation. We cannot have spaces > in symbol library nicknames until the schematic and symbol library file > formats are implemented. I didn't want to make a change to the current > schematic file format. Once they are in place, I will remove the spaces > restriction. > > Cheers, > > Wayne > > On 04/13/2018 05:45 AM, Maciej Sumiński wrote: >> Another question is whether spaces are considered valid in library item >> names (symbols/footprints). Should both logical library names and >> library items permit the same character set? Seems reasonable to me, but >> I need to be sure. >> >> Cheers, >> Orson >> >> On 04/13/2018 11:36 AM, Maciej Sumiński wrote: >>> I have just noticed that one cannot use spaces in symbol library >>> nicknames [1], whereas they are valid for footprint library nicknames >>> [2]. I suppose it should be unified and moved to a function (static >>> method in LIB_ID?) to avoid valid characters sets diversion. I will fix >>> it, but I need to know what is the decision about spaces. >>> >>> Cheers, >>> Orson >>> >>> 1. >>> https://github.com/KiCad/kicad-source-mirror/blob/master/eeschema/dialogs/dialog_sym_lib_table.cpp#L269 >>> 2. >>> https://github.com/KiCad/kicad-source-mirror/blob/master/pcbnew/dialogs/dialog_fp_lib_table.cpp#L302 >>> >>> >>> >>> ___ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> >> >> >> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Spaces in library nicknames
Orson, You must have missed the original conversation. We cannot have spaces in symbol library nicknames until the schematic and symbol library file formats are implemented. I didn't want to make a change to the current schematic file format. Once they are in place, I will remove the spaces restriction. Cheers, Wayne On 04/13/2018 05:45 AM, Maciej Sumiński wrote: > Another question is whether spaces are considered valid in library item > names (symbols/footprints). Should both logical library names and > library items permit the same character set? Seems reasonable to me, but > I need to be sure. > > Cheers, > Orson > > On 04/13/2018 11:36 AM, Maciej Sumiński wrote: >> I have just noticed that one cannot use spaces in symbol library >> nicknames [1], whereas they are valid for footprint library nicknames >> [2]. I suppose it should be unified and moved to a function (static >> method in LIB_ID?) to avoid valid characters sets diversion. I will fix >> it, but I need to know what is the decision about spaces. >> >> Cheers, >> Orson >> >> 1. >> https://github.com/KiCad/kicad-source-mirror/blob/master/eeschema/dialogs/dialog_sym_lib_table.cpp#L269 >> 2. >> https://github.com/KiCad/kicad-source-mirror/blob/master/pcbnew/dialogs/dialog_fp_lib_table.cpp#L302 >> >> >> >> ___ >> Mailing list: https://launchpad.net/~kicad-developers >> Post to : kicad-developers@lists.launchpad.net >> Unsubscribe : https://launchpad.net/~kicad-developers >> More help : https://help.launchpad.net/ListHelp >> > > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Spaces in library nicknames
Another question is whether spaces are considered valid in library item names (symbols/footprints). Should both logical library names and library items permit the same character set? Seems reasonable to me, but I need to be sure. Cheers, Orson On 04/13/2018 11:36 AM, Maciej Sumiński wrote: > I have just noticed that one cannot use spaces in symbol library > nicknames [1], whereas they are valid for footprint library nicknames > [2]. I suppose it should be unified and moved to a function (static > method in LIB_ID?) to avoid valid characters sets diversion. I will fix > it, but I need to know what is the decision about spaces. > > Cheers, > Orson > > 1. > https://github.com/KiCad/kicad-source-mirror/blob/master/eeschema/dialogs/dialog_sym_lib_table.cpp#L269 > 2. > https://github.com/KiCad/kicad-source-mirror/blob/master/pcbnew/dialogs/dialog_fp_lib_table.cpp#L302 > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Spaces in library nicknames
I have just noticed that one cannot use spaces in symbol library nicknames [1], whereas they are valid for footprint library nicknames [2]. I suppose it should be unified and moved to a function (static method in LIB_ID?) to avoid valid characters sets diversion. I will fix it, but I need to know what is the decision about spaces. Cheers, Orson 1. https://github.com/KiCad/kicad-source-mirror/blob/master/eeschema/dialogs/dialog_sym_lib_table.cpp#L269 2. https://github.com/KiCad/kicad-source-mirror/blob/master/pcbnew/dialogs/dialog_fp_lib_table.cpp#L302 signature.asc Description: OpenPGP digital signature ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
