Re: [Kicad-developers] export_vrml.cpp warnings

2016-09-23 Thread jp charras
Le 23/09/2016 à 00:29, Cirilo Bernardo a écrit : > Thanks, that's probably a bad C habit on my part. :) The most ancient of C++ > specs > were more lenient with magic int-enum casts. All the more reason to use "enum > class" > from now on; after all it was explicitly to address problems like thi

Re: [Kicad-developers] export_vrml.cpp warnings

2016-09-22 Thread Cirilo Bernardo
Thanks, that's probably a bad C habit on my part. :) The most ancient of C++ specs were more lenient with magic int-enum casts. All the more reason to use "enum class" from now on; after all it was explicitly to address problems like this. Fix attached; the patch also removes the few instances of

[Kicad-developers] export_vrml.cpp warnings

2016-09-22 Thread Simon Wells
i am getting the following warning /Users/simon/kicad-app/kicad/pcbnew/exporters/export_vrml.cpp:1624:18: warning: comparison of constant -1 with expression of type 'VRML_COLOR_INDEX' is always false [-Wtautological-constant-out-of-range-compare] if( colorIdx == -1 ) ~