Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-26 Thread Jonatan Liljedahl 
Hi,

How should I proceed with this patch? I think that regardless of
future features, it would make sense to either just apply this patch
so at least the traces for the second y-scale have a different visual
style, or to add a section in the preferences for setting default
solid/dashed and line width for left/right-scale traces.

On Fri, Nov 22, 2019 at 2:35 PM Wayne Stambaugh  wrote:
>
> This would be a great long term solution.  You could also store it in
> the project file since it is project specific if you don't want to go
> through the effort of designing a new s-expression file format.
>
> On 11/21/19 6:45 PM, Ian McInerney wrote:
> > I think it would be good to define a new S-expression config file that
> > can be used to store the plot configurations of the simulator. This file
> > should just contain the plot information, such as lines displayed, their
> > style/color, axis configurations, colors, etc. (and maybe analysis
> > parameters, I haven't thought about that part yet). This would allow us
> > to add the functionality to open/save plot styles (similar to how a
> > Modelsim .do file can be used to save/configure the waveform display,
> > but ours won't be a script).
> >
> > -Ian
> >
> > On Thu, 21 Nov 2019, 22:11 Jon Evans,  > > wrote:
> >
> > I can add the simulator to the scope of effort to do the whole
> > settings files upgrade for 6.0
> >
> > On Thu, Nov 21, 2019 at 5:06 PM Wayne Stambaugh
> > mailto:[email protected]>> wrote:
> >
> >
> > On 11/21/19 1:15 PM, Kymatica wrote:
> > > Sure, I can make it configurable. Where should this setting be
> > available? In the main preferences? (Perhaps a new Simulator
> > section there?)
> >
> > I would think the simulator will over time have enough user (not
> > simulation control) configuration settings that it would have
> > it's own
> > preferences dialog and that the settings would be saved in a
> > separate
> > configuration file.  I think at the moment the config settings
> > are saved
> > in the eeschema config file.
> >
> > >
> > > /Jonatan
> > >
> > >> 21 nov. 2019 kl. 18:26 skrev Wayne Stambaugh
> > mailto:[email protected]>>:
> > >>
> > >> Hi Jonatan,
> > >>
> > >> I just tested this and it seems to work as expected although I'm
> > >> thinking it might be a good idea to make this a configuration
> > option
> > >> rather than the only behavior.  Users might not find this
> > desirable.
> > >> Anyone else have any thoughts on this?  For future reference,
> > when you
> > >> are going to make behavioral changes to KiCad, please ping
> > the dev
> > >> mailing list first for feedback.  I would have made the option
> > >> suggestion before you began coding.
> > >>
> > >> Cheers,
> > >>
> > >> Wayne
> > >>
> > >>> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
> > >>> This patch makes it easier to visually keep apart traces for
> > current
> > >>> vs voltage and phase vs magnitude, by using dotted line
> > style for
> > >>> current and phase traces.
> > >>>
> > >>> To get the dotted style drawn correctly, I had to switch
> > from drawing
> > >>> each trace line segment individually to creating an array
> > and then
> > >>> using DrawLines() on it, so that the whole trace is one
> > continuous
> > >>> line.
> > >>>
> > >>>
> > >>> ___
> > >>> Mailing list: https://launchpad.net/~kicad-developers
> > >>> Post to : [email protected]
> > 
> > >>> Unsubscribe : https://launchpad.net/~kicad-developers
> > >>> More help   : https://help.launchpad.net/ListHelp
> > >>>
> > >>
> > >> ___
> > >> Mailing list: https://launchpad.net/~kicad-developers
> > >> Post to : [email protected]
> > 
> > >> Unsubscribe : https://launchpad.net/~kicad-developers
> > >> More help   : https://help.launchpad.net/ListHelp
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : [email protected]
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
> > ___
> > Mailing list: https://

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-22 Thread Wayne Stambaugh 
This would be a great long term solution.  You could also store it in
the project file since it is project specific if you don't want to go
through the effort of designing a new s-expression file format.

On 11/21/19 6:45 PM, Ian McInerney wrote:
> I think it would be good to define a new S-expression config file that
> can be used to store the plot configurations of the simulator. This file
> should just contain the plot information, such as lines displayed, their
> style/color, axis configurations, colors, etc. (and maybe analysis
> parameters, I haven't thought about that part yet). This would allow us
> to add the functionality to open/save plot styles (similar to how a
> Modelsim .do file can be used to save/configure the waveform display,
> but ours won't be a script).
> 
> -Ian
> 
> On Thu, 21 Nov 2019, 22:11 Jon Evans,  > wrote:
> 
> I can add the simulator to the scope of effort to do the whole
> settings files upgrade for 6.0
> 
> On Thu, Nov 21, 2019 at 5:06 PM Wayne Stambaugh
> mailto:[email protected]>> wrote:
> 
> 
> On 11/21/19 1:15 PM, Kymatica wrote:
> > Sure, I can make it configurable. Where should this setting be
> available? In the main preferences? (Perhaps a new Simulator
> section there?)
> 
> I would think the simulator will over time have enough user (not
> simulation control) configuration settings that it would have
> it's own
> preferences dialog and that the settings would be saved in a
> separate
> configuration file.  I think at the moment the config settings
> are saved
> in the eeschema config file.
> 
> >
> > /Jonatan
> >
> >> 21 nov. 2019 kl. 18:26 skrev Wayne Stambaugh
> mailto:[email protected]>>:
> >>
> >> Hi Jonatan,
> >>
> >> I just tested this and it seems to work as expected although I'm
> >> thinking it might be a good idea to make this a configuration
> option
> >> rather than the only behavior.  Users might not find this
> desirable.
> >> Anyone else have any thoughts on this?  For future reference,
> when you
> >> are going to make behavioral changes to KiCad, please ping
> the dev
> >> mailing list first for feedback.  I would have made the option
> >> suggestion before you began coding.
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >>> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
> >>> This patch makes it easier to visually keep apart traces for
> current
> >>> vs voltage and phase vs magnitude, by using dotted line
> style for
> >>> current and phase traces.
> >>>
> >>> To get the dotted style drawn correctly, I had to switch
> from drawing
> >>> each trace line segment individually to creating an array
> and then
> >>> using DrawLines() on it, so that the whole trace is one
> continuous
> >>> line.
> >>>
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : [email protected]
> 
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : [email protected]
> 
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : [email protected]
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : [email protected]
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-22 Thread Wayne Stambaugh 
Makes sense to me.

On 11/21/19 5:10 PM, Jon Evans wrote:
> I can add the simulator to the scope of effort to do the whole settings
> files upgrade for 6.0
> 
> On Thu, Nov 21, 2019 at 5:06 PM Wayne Stambaugh  > wrote:
> 
> 
> On 11/21/19 1:15 PM, Kymatica wrote:
> > Sure, I can make it configurable. Where should this setting be
> available? In the main preferences? (Perhaps a new Simulator section
> there?)
> 
> I would think the simulator will over time have enough user (not
> simulation control) configuration settings that it would have it's own
> preferences dialog and that the settings would be saved in a separate
> configuration file.  I think at the moment the config settings are saved
> in the eeschema config file.
> 
> >
> > /Jonatan
> >
> >> 21 nov. 2019 kl. 18:26 skrev Wayne Stambaugh
> mailto:[email protected]>>:
> >>
> >> Hi Jonatan,
> >>
> >> I just tested this and it seems to work as expected although I'm
> >> thinking it might be a good idea to make this a configuration option
> >> rather than the only behavior.  Users might not find this desirable.
> >> Anyone else have any thoughts on this?  For future reference,
> when you
> >> are going to make behavioral changes to KiCad, please ping the dev
> >> mailing list first for feedback.  I would have made the option
> >> suggestion before you began coding.
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >>> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
> >>> This patch makes it easier to visually keep apart traces for current
> >>> vs voltage and phase vs magnitude, by using dotted line style for
> >>> current and phase traces.
> >>>
> >>> To get the dotted style drawn correctly, I had to switch from
> drawing
> >>> each trace line segment individually to creating an array and then
> >>> using DrawLines() on it, so that the whole trace is one continuous
> >>> line.
> >>>
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : [email protected]
> 
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : [email protected]
> 
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : [email protected]
> 
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-22 Thread Jonatan Liljedahl 
Also this message didn't reach the list:

On Fri, Nov 22, 2019 at 12:14 AM Kymatica  wrote:
>
> Hi,
> With quick and easy I wasn’t actually referring to the coding involved, but 
> to the user experience: when I fire up the simulator I (as a user) just want 
> to see the results and look at the plots, with as little confusion as 
> possible regarding which trace is which, or which trace belongs to which 
> scale. I don’t want to configure anything. But perhaps I missunderstood, and 
> that the proposal wasn’t to have style config per trace/signal but per trace 
> type? (Volt, Current, Mag, Phase) Because traces are volatile, you add and 
> remove them many times depending on what you want to see.
>
> /Jonatan
>
> > 21 nov. 2019 kl. 21:55 skrev Wayne Stambaugh :
> >
> > On 11/21/19 2:36 PM, Kymatica wrote:
> >> The idea here was to simply use a different visual style for the traces
> >> that are plotted for the secondary y axis, to make it easy to see which
> >> scale the trace belongs to without having to look it up in the signals 
> >> list.
> >>
> >> Per trace configuration could be nice, at least if preparing images for
> >> presentation. But for everyday simulation work I’d just want it quick
> >> and easy.
> >
> > I understand the temptation to do the quick and easy hack.  We have all
> > done it.  From a project maintenance perspective, allowing developers to
> > merge their personal quick hacks quickly makes a mess of the KiCad code
> > base.  This is why I would prefer that we carefully consider what trace
> > drawing options we want to support so we can design a solution that
> > works over the long term.
> >
> >>
> >> /Jonatan
> >>
>  21 nov. 2019 kl. 18:34 skrev Ian McInerney :
> >>>
> >>> 
> >>> This is probably introducing major feature creep, but it would be nice
> >>> to develop a dialog that allows setting the per-trace characteristics
> >>> (such as color, line type, line width, etc) that this could go in.
> >>> Where we put the accessors to it, I am not sure (it would be great if
> >>> we could link it with the legend fields). Then we can add in more
> >>> configuration options there as we implement them.
> >>>
> >>> -Ian
> >>>
> >>> On Thu, Nov 21, 2019 at 5:26 PM Wayne Stambaugh  >>> > wrote:
> >>>
> >>>Hi Jonatan,
> >>>
> >>>I just tested this and it seems to work as expected although I'm
> >>>thinking it might be a good idea to make this a configuration option
> >>>rather than the only behavior.  Users might not find this desirable.
> >>>Anyone else have any thoughts on this?  For future reference, when you
> >>>are going to make behavioral changes to KiCad, please ping the dev
> >>>mailing list first for feedback.  I would have made the option
> >>>suggestion before you began coding.
> >>>
> >>>Cheers,
> >>>
> >>>Wayne
> >>>
> >>>On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
>  This patch makes it easier to visually keep apart traces for current
>  vs voltage and phase vs magnitude, by using dotted line style for
>  current and phase traces.
> 
>  To get the dotted style drawn correctly, I had to switch from
> >>>drawing
>  each trace line segment individually to creating an array and then
>  using DrawLines() on it, so that the whole trace is one continuous
>  line.
> 
> 
>  ___
>  Mailing list: https://launchpad.net/~kicad-developers
>  Post to : [email protected]
> >>>
>  Unsubscribe : https://launchpad.net/~kicad-developers
>  More help   : https://help.launchpad.net/ListHelp
> 
> >>>
> >>>___
> >>>Mailing list: https://launchpad.net/~kicad-developers
> >>>Post to : [email protected]
> >>>
> >>>Unsubscribe : https://launchpad.net/~kicad-developers
> >>>More help   : https://help.launchpad.net/ListHelp
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : [email protected]
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : [email protected]
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp



-- 
/Jonatan
http://kymatica.com

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-22 Thread Jonatan Liljedahl 
Right, such configuration could be useful. However, note that a
selection of which lines (signals?) to show would be tied to the
actual current state of the schematic. Nets changes names, either
because user changes the names of labels, or automatically when things
get reconnected and re-annotated (Net-(R12-Pad2)) etc..

In any case, I think it makes sense to have a base setting of default
trace drawing style, and I think it makes sense if this is separated
into "left scale" (Voltage and Magnitude) and "right scale" (Current
and Phase). You can only view Voltage and Current, or Magnitude and
Phase, in the same plot, not any other combinations.

On Fri, Nov 22, 2019 at 12:46 AM Ian McInerney  wrote:
>
> I think it would be good to define a new S-expression config file that can be 
> used to store the plot configurations of the simulator. This file should just 
> contain the plot information, such as lines displayed, their style/color, 
> axis configurations, colors, etc. (and maybe analysis parameters, I haven't 
> thought about that part yet). This would allow us to add the functionality to 
> open/save plot styles (similar to how a Modelsim .do file can be used to 
> save/configure the waveform display, but ours won't be a script).
>
> -Ian
>
> On Thu, 21 Nov 2019, 22:11 Jon Evans,  wrote:
>>
>> I can add the simulator to the scope of effort to do the whole settings 
>> files upgrade for 6.0
>>
>> On Thu, Nov 21, 2019 at 5:06 PM Wayne Stambaugh  wrote:
>>>
>>>
>>> On 11/21/19 1:15 PM, Kymatica wrote:
>>> > Sure, I can make it configurable. Where should this setting be available? 
>>> > In the main preferences? (Perhaps a new Simulator section there?)
>>>
>>> I would think the simulator will over time have enough user (not
>>> simulation control) configuration settings that it would have it's own
>>> preferences dialog and that the settings would be saved in a separate
>>> configuration file.  I think at the moment the config settings are saved
>>> in the eeschema config file.
>>>
>>> >
>>> > /Jonatan
>>> >
>>> >> 21 nov. 2019 kl. 18:26 skrev Wayne Stambaugh :
>>> >>
>>> >> Hi Jonatan,
>>> >>
>>> >> I just tested this and it seems to work as expected although I'm
>>> >> thinking it might be a good idea to make this a configuration option
>>> >> rather than the only behavior.  Users might not find this desirable.
>>> >> Anyone else have any thoughts on this?  For future reference, when you
>>> >> are going to make behavioral changes to KiCad, please ping the dev
>>> >> mailing list first for feedback.  I would have made the option
>>> >> suggestion before you began coding.
>>> >>
>>> >> Cheers,
>>> >>
>>> >> Wayne
>>> >>
>>> >>> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
>>> >>> This patch makes it easier to visually keep apart traces for current
>>> >>> vs voltage and phase vs magnitude, by using dotted line style for
>>> >>> current and phase traces.
>>> >>>
>>> >>> To get the dotted style drawn correctly, I had to switch from drawing
>>> >>> each trace line segment individually to creating an array and then
>>> >>> using DrawLines() on it, so that the whole trace is one continuous
>>> >>> line.
>>> >>>
>>> >>>
>>> >>> ___
>>> >>> Mailing list: https://launchpad.net/~kicad-developers
>>> >>> Post to : [email protected]
>>> >>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> >>> More help   : https://help.launchpad.net/ListHelp
>>> >>>
>>> >>
>>> >> ___
>>> >> Mailing list: https://launchpad.net/~kicad-developers
>>> >> Post to : [email protected]
>>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>>> >> More help   : https://help.launchpad.net/ListHelp
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : [email protected]
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : [email protected]
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



-- 
/Jonatan
http://kymatica.com

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-21 Thread Ian McInerney 
I think it would be good to define a new S-expression config file that can
be used to store the plot configurations of the simulator. This file should
just contain the plot information, such as lines displayed, their
style/color, axis configurations, colors, etc. (and maybe analysis
parameters, I haven't thought about that part yet). This would allow us to
add the functionality to open/save plot styles (similar to how a Modelsim
.do file can be used to save/configure the waveform display, but ours won't
be a script).

-Ian

On Thu, 21 Nov 2019, 22:11 Jon Evans,  wrote:

> I can add the simulator to the scope of effort to do the whole settings
> files upgrade for 6.0
>
> On Thu, Nov 21, 2019 at 5:06 PM Wayne Stambaugh 
> wrote:
>
>>
>> On 11/21/19 1:15 PM, Kymatica wrote:
>> > Sure, I can make it configurable. Where should this setting be
>> available? In the main preferences? (Perhaps a new Simulator section there?)
>>
>> I would think the simulator will over time have enough user (not
>> simulation control) configuration settings that it would have it's own
>> preferences dialog and that the settings would be saved in a separate
>> configuration file.  I think at the moment the config settings are saved
>> in the eeschema config file.
>>
>> >
>> > /Jonatan
>> >
>> >> 21 nov. 2019 kl. 18:26 skrev Wayne Stambaugh :
>> >>
>> >> Hi Jonatan,
>> >>
>> >> I just tested this and it seems to work as expected although I'm
>> >> thinking it might be a good idea to make this a configuration option
>> >> rather than the only behavior.  Users might not find this desirable.
>> >> Anyone else have any thoughts on this?  For future reference, when you
>> >> are going to make behavioral changes to KiCad, please ping the dev
>> >> mailing list first for feedback.  I would have made the option
>> >> suggestion before you began coding.
>> >>
>> >> Cheers,
>> >>
>> >> Wayne
>> >>
>> >>> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
>> >>> This patch makes it easier to visually keep apart traces for current
>> >>> vs voltage and phase vs magnitude, by using dotted line style for
>> >>> current and phase traces.
>> >>>
>> >>> To get the dotted style drawn correctly, I had to switch from drawing
>> >>> each trace line segment individually to creating an array and then
>> >>> using DrawLines() on it, so that the whole trace is one continuous
>> >>> line.
>> >>>
>> >>>
>> >>> ___
>> >>> Mailing list: https://launchpad.net/~kicad-developers
>> >>> Post to : [email protected]
>> >>> Unsubscribe : https://launchpad.net/~kicad-developers
>> >>> More help   : https://help.launchpad.net/ListHelp
>> >>>
>> >>
>> >> ___
>> >> Mailing list: https://launchpad.net/~kicad-developers
>> >> Post to : [email protected]
>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : [email protected]
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-21 Thread Jon Evans 
I can add the simulator to the scope of effort to do the whole settings
files upgrade for 6.0

On Thu, Nov 21, 2019 at 5:06 PM Wayne Stambaugh 
wrote:

>
> On 11/21/19 1:15 PM, Kymatica wrote:
> > Sure, I can make it configurable. Where should this setting be
> available? In the main preferences? (Perhaps a new Simulator section there?)
>
> I would think the simulator will over time have enough user (not
> simulation control) configuration settings that it would have it's own
> preferences dialog and that the settings would be saved in a separate
> configuration file.  I think at the moment the config settings are saved
> in the eeschema config file.
>
> >
> > /Jonatan
> >
> >> 21 nov. 2019 kl. 18:26 skrev Wayne Stambaugh :
> >>
> >> Hi Jonatan,
> >>
> >> I just tested this and it seems to work as expected although I'm
> >> thinking it might be a good idea to make this a configuration option
> >> rather than the only behavior.  Users might not find this desirable.
> >> Anyone else have any thoughts on this?  For future reference, when you
> >> are going to make behavioral changes to KiCad, please ping the dev
> >> mailing list first for feedback.  I would have made the option
> >> suggestion before you began coding.
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >>> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
> >>> This patch makes it easier to visually keep apart traces for current
> >>> vs voltage and phase vs magnitude, by using dotted line style for
> >>> current and phase traces.
> >>>
> >>> To get the dotted style drawn correctly, I had to switch from drawing
> >>> each trace line segment individually to creating an array and then
> >>> using DrawLines() on it, so that the whole trace is one continuous
> >>> line.
> >>>
> >>>
> >>> ___
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to : [email protected]
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to : [email protected]
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-21 Thread Wayne Stambaugh 

On 11/21/19 1:15 PM, Kymatica wrote:
> Sure, I can make it configurable. Where should this setting be available? In 
> the main preferences? (Perhaps a new Simulator section there?)

I would think the simulator will over time have enough user (not
simulation control) configuration settings that it would have it's own
preferences dialog and that the settings would be saved in a separate
configuration file.  I think at the moment the config settings are saved
in the eeschema config file.

> 
> /Jonatan 
> 
>> 21 nov. 2019 kl. 18:26 skrev Wayne Stambaugh :
>>
>> Hi Jonatan,
>>
>> I just tested this and it seems to work as expected although I'm
>> thinking it might be a good idea to make this a configuration option
>> rather than the only behavior.  Users might not find this desirable.
>> Anyone else have any thoughts on this?  For future reference, when you
>> are going to make behavioral changes to KiCad, please ping the dev
>> mailing list first for feedback.  I would have made the option
>> suggestion before you began coding.
>>
>> Cheers,
>>
>> Wayne
>>
>>> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
>>> This patch makes it easier to visually keep apart traces for current
>>> vs voltage and phase vs magnitude, by using dotted line style for
>>> current and phase traces.
>>>
>>> To get the dotted style drawn correctly, I had to switch from drawing
>>> each trace line segment individually to creating an array and then
>>> using DrawLines() on it, so that the whole trace is one continuous
>>> line.
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : [email protected]
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : [email protected]
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-21 Thread Wayne Stambaugh 
On 11/21/19 2:36 PM, Kymatica wrote:
> The idea here was to simply use a different visual style for the traces
> that are plotted for the secondary y axis, to make it easy to see which
> scale the trace belongs to without having to look it up in the signals list.
> 
> Per trace configuration could be nice, at least if preparing images for
> presentation. But for everyday simulation work I’d just want it quick
> and easy.

I understand the temptation to do the quick and easy hack.  We have all
done it.  From a project maintenance perspective, allowing developers to
merge their personal quick hacks quickly makes a mess of the KiCad code
base.  This is why I would prefer that we carefully consider what trace
drawing options we want to support so we can design a solution that
works over the long term.

> 
> /Jonatan 
> 
>> 21 nov. 2019 kl. 18:34 skrev Ian McInerney :
>>
>> 
>> This is probably introducing major feature creep, but it would be nice
>> to develop a dialog that allows setting the per-trace characteristics
>> (such as color, line type, line width, etc) that this could go in.
>> Where we put the accessors to it, I am not sure (it would be great if
>> we could link it with the legend fields). Then we can add in more
>> configuration options there as we implement them.
>>
>> -Ian
>>
>> On Thu, Nov 21, 2019 at 5:26 PM Wayne Stambaugh > > wrote:
>>
>> Hi Jonatan,
>>
>> I just tested this and it seems to work as expected although I'm
>> thinking it might be a good idea to make this a configuration option
>> rather than the only behavior.  Users might not find this desirable.
>> Anyone else have any thoughts on this?  For future reference, when you
>> are going to make behavioral changes to KiCad, please ping the dev
>> mailing list first for feedback.  I would have made the option
>> suggestion before you began coding.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
>> > This patch makes it easier to visually keep apart traces for current
>> > vs voltage and phase vs magnitude, by using dotted line style for
>> > current and phase traces.
>> >
>> > To get the dotted style drawn correctly, I had to switch from
>> drawing
>> > each trace line segment individually to creating an array and then
>> > using DrawLines() on it, so that the whole trace is one continuous
>> > line.
>> >
>> >
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to     : [email protected]
>> 
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : [email protected]
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : [email protected]
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-21 Thread Jeff Young 
I think phase is always dotted in LTSpice, but current is solid.  You can chose 
the colour of any trace.

> On 21 Nov 2019, at 17:33, Ian McInerney  wrote:
> 
> This is probably introducing major feature creep, but it would be nice to 
> develop a dialog that allows setting the per-trace characteristics (such as 
> color, line type, line width, etc) that this could go in. Where we put the 
> accessors to it, I am not sure (it would be great if we could link it with 
> the legend fields). Then we can add in more configuration options there as we 
> implement them.
> 
> -Ian
> 
> On Thu, Nov 21, 2019 at 5:26 PM Wayne Stambaugh  > wrote:
> Hi Jonatan,
> 
> I just tested this and it seems to work as expected although I'm
> thinking it might be a good idea to make this a configuration option
> rather than the only behavior.  Users might not find this desirable.
> Anyone else have any thoughts on this?  For future reference, when you
> are going to make behavioral changes to KiCad, please ping the dev
> mailing list first for feedback.  I would have made the option
> suggestion before you began coding.
> 
> Cheers,
> 
> Wayne
> 
> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
> > This patch makes it easier to visually keep apart traces for current
> > vs voltage and phase vs magnitude, by using dotted line style for
> > current and phase traces.
> > 
> > To get the dotted style drawn correctly, I had to switch from drawing
> > each trace line segment individually to creating an array and then
> > using DrawLines() on it, so that the whole trace is one continuous
> > line.
> > 
> > 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers 
> > 
> > Post to : [email protected] 
> > 
> > Unsubscribe : https://launchpad.net/~kicad-developers 
> > 
> > More help   : https://help.launchpad.net/ListHelp 
> > 
> > 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : [email protected] 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-21 Thread Ian McInerney 
This is probably introducing major feature creep, but it would be nice to
develop a dialog that allows setting the per-trace characteristics (such as
color, line type, line width, etc) that this could go in. Where we put the
accessors to it, I am not sure (it would be great if we could link it with
the legend fields). Then we can add in more configuration options there as
we implement them.

-Ian

On Thu, Nov 21, 2019 at 5:26 PM Wayne Stambaugh 
wrote:

> Hi Jonatan,
>
> I just tested this and it seems to work as expected although I'm
> thinking it might be a good idea to make this a configuration option
> rather than the only behavior.  Users might not find this desirable.
> Anyone else have any thoughts on this?  For future reference, when you
> are going to make behavioral changes to KiCad, please ping the dev
> mailing list first for feedback.  I would have made the option
> suggestion before you began coding.
>
> Cheers,
>
> Wayne
>
> On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
> > This patch makes it easier to visually keep apart traces for current
> > vs voltage and phase vs magnitude, by using dotted line style for
> > current and phase traces.
> >
> > To get the dotted style drawn correctly, I had to switch from drawing
> > each trace line segment individually to creating an array and then
> > using DrawLines() on it, so that the whole trace is one continuous
> > line.
> >
> >
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : [email protected]
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Eeschema: simulator: use dotted traces for current and phase.

2019-11-21 Thread Wayne Stambaugh 
Hi Jonatan,

I just tested this and it seems to work as expected although I'm
thinking it might be a good idea to make this a configuration option
rather than the only behavior.  Users might not find this desirable.
Anyone else have any thoughts on this?  For future reference, when you
are going to make behavioral changes to KiCad, please ping the dev
mailing list first for feedback.  I would have made the option
suggestion before you began coding.

Cheers,

Wayne

On 11/19/19 11:30 AM, Jonatan Liljedahl wrote:
> This patch makes it easier to visually keep apart traces for current
> vs voltage and phase vs magnitude, by using dotted line style for
> current and phase traces.
> 
> To get the dotted style drawn correctly, I had to switch from drawing
> each trace line segment individually to creating an array and then
> using DrawLines() on it, so that the whole trace is one continuous
> line.
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp