Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

There is a similar issue with "New" and "Append Board" operations, but it existed way before Jon's improvements. I've created a bug report, so it not gets lost: https://bugs.launchpad.net/kicad/+bug/1751589 Andrzej W dniu 2018-02-23 o 13:18, jp charras pisze: Le 23/02/2018 à 01:04, Jon Evans

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

4. State of some checkboxes is not saved. Fix for that one in attachment. Andrzej >From 9ccc36e2d0de45175e928bb70f14340392bd35be Mon Sep 17 00:00:00 2001 From: Andrzej Wolski Date: Sat, 24 Feb 2018 21:51:33 +0100 Subject: [PATCH] Restore some missing visibility

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Oh well, I can't share with google drive... This should work better: https://drive.google.com/open?id=1G1DDjlusNYpZ63m9ymXgBXRD0isOziCz 2018-02-23 23:09 GMT+02:00 Eeli Kaikkonen : > I also think it's an improvement, something which I had in mind. As we > have seen there

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

My straw man would be that we need to get out of the heuristics game. When we get them wrong, customers file bugs and lose confidence in their understanding of the program. If we have a checkbox that says “Through Hole Pads”, then it should toggle the visibility of through hole pads. That

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Before we do any more tweaking, we should definitely agree on the visibility behavior and stick too it. Otherwise this will be a never ending cycle of changes. I think what we have in place is a big improvement any further tweaking be put off to v6. This way we have the time to perhaps do

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

I also think it's an improvement, something which I had in mind. As we have seen there are countless of details which could be changed, but it's difficult to say which are useful. For what it's worth, a bit earlier I used QtDesigner to create a mock-up widget. It has some ideas which could or

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Actually that logic was already there, I just fixed hiding non footprint items together with pads. Andrzej W dniu 2018-02-23 o 21:46, Jon Evans pisze: I'm fine with renaming to SMD pads. Right now the logic (implemented by Andrzej, not me by the way) assumes that all pads are associated with

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

I'm fine with renaming to SMD pads. Right now the logic (implemented by Andrzej, not me by the way) assumes that all pads are associated with footprints, and if footprint display is turned off, hides pads (SMD and through hole) Seems like lots of people have different opinions on what those

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Hi Jon, Just playing with the new render palette. It’s a big improvement. However, I noted that turning off Footprints turns off through-hole pads. Since we have a separate option for that, it’s counter-intuitive to have Footprints also control it. (And, when one wants to see the copper and

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Le 23/02/2018 à 16:12, Jon Evans a écrit : > You can commit that, but I can't quite tell why there are two different > functions ReFillRender() and > SyncRenderStates(); they do mostly the same thing so it seems best to just > collapse them into one to > avoid bugs in the future. > The attached

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

You can commit that, but I can't quite tell why there are two different functions ReFillRender() and SyncRenderStates(); they do mostly the same thing so it seems best to just collapse them into one to avoid bugs in the future. The attached patch removes SyncRenderStates -- please let me know if

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Le 23/02/2018 à 15:57, Jon Evans a écrit : > If you add a call to ReFillRender() at the top of  > PCB_LAYER_WIDGET::SyncRenderStates() instead of my > change, does it fix it? > Yes, just adding the call fixes this issue. Can I commit this fix? > On Fri, Feb 23, 2018 at 9:54 AM, jp charras

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

If you add a call to ReFillRender() at the top of PCB_LAYER_WIDGET::SyncRenderStates() instead of my change, does it fix it? On Fri, Feb 23, 2018 at 9:54 AM, jp charras wrote: > Le 23/02/2018 à 14:24, Jon Evans a écrit : > > Hi JP, good catch, the attached fixes it for me

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Le 23/02/2018 à 14:24, Jon Evans a écrit : > Hi JP, good catch, the attached fixes it for me > > -Jon > > On Fri, Feb 23, 2018 at 7:18 AM, jp charras > > wrote: > > Le 23/02/2018 à 01:04, Jon Evans a écrit : > > Here are two more

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Before anyone decides to take on this task, I have some very concrete ideas about creating a plot manager for creating plot tasks which will allow users (me) to set up a plot (and possibly other exports) task that includes all of the plots I use in production and perform this task with a single

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Hi JP, good catch, the attached fixes it for me -Jon On Fri, Feb 23, 2018 at 7:18 AM, jp charras wrote: > Le 23/02/2018 à 01:04, Jon Evans a écrit : > > Here are two more quick patches addressing some of the easier changes. > > I have some other bugs to look at that seem

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Le 23/02/2018 à 01:04, Jon Evans a écrit : > Here are two more quick patches addressing some of the easier changes. > I have some other bugs to look at that seem more urgent, so I'm not going to > work on the right-click > menu or settings persistence. > > Thanks, > Jon > Hi Jon, There is a

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

John, I merged your patch. Thanks. Wayne On 02/22/2018 07:04 PM, Jon Evans wrote: Here are two more quick patches addressing some of the easier changes. I have some other bugs to look at that seem more urgent, so I'm not going to work on the right-click menu or settings persistence.

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

I couldn't find it so I reported https://bugs.launchpad.net/kicad/+bug/1751171 On Thu, Feb 22, 2018 at 6:34 PM, Jon Evans wrote: > Is there already a bug report for that? We should make sure to keep track > of all this so if someone has time to do some kind of

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Is there already a bug report for that? We should make sure to keep track of all this so if someone has time to do some kind of settings-saving overhaul for V6 we catch all of that stuff. On Thu, Feb 22, 2018 at 7:31 PM, José Ignacio wrote: > One thing that is very

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

One thing that is very inconsistent is that layer settings for plotting gerbers are saved in the board file (as they should), but settings for the drill file are saved in the global kicad settings (which means that if i have two different projects that need different drill settings i need to

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Here are two more quick patches addressing some of the easier changes. I have some other bugs to look at that seem more urgent, so I'm not going to work on the right-click menu or settings persistence. Thanks, Jon On Thu, Feb 22, 2018 at 6:15 PM, Wayne Stambaugh wrote: >

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Patch merged. Thanks. On 02/21/2018 11:39 PM, Jon Evans wrote: Hi all, This patch rearranges the Render panel to be in a more logical order, and adds some whitespace. I divided it into three groupings: 1) footprint related 2) other board objects 3) non-board stuff like grid, ratlines, etc.

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

2018-02-22 23:05 GMT+02:00 Tiger12506 : > I agree 100% on separate file. As someone who puts kicad files in git, the > most irritating thing in the world is having unrelated changes in your > diff. Separate file gives you the flexibility to have either situation -- > if you

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

I agree 100% on separate file. As someone who puts kicad files in git, the most irritating thing in the world is having unrelated changes in your diff. Separate file gives you the flexibility to have either situation -- if you want the vcs to track it, you include the file, if you don't, your

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

I'm agreeing with Andy on this one. I really don't like the idea of putting UI or print/plot state information in the board file. Most of the current state information was added by my predecessor. I've never liked the idea of UI state information being saved in the board file. Andy pointed out

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

I agree. I think layer visibility data should be saved in board file because that file should be independent of project file and any other files. I would like to be able to send only pcb file via email, and have all information contained there. Some solution to problem Andy described might be

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

On Feb 22, 2018, at 10:48 AM, Jon Evans wrote: > > The tradeoff there is that other users will have a workflow that involves > setting up a nice set of layers displayed/hidden for working on a board, and > want to switch to another set for another board. > Maybe saving in

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

The tradeoff there is that other users will have a workflow that involves setting up a nice set of layers displayed/hidden for working on a board, and want to switch to another set for another board. Maybe saving in the app preferences is okay in the short term, but I think eventually it's best to

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

I won't be able to do it before weekend, so if you have time, please go ahead. Cheers, Andrzej On 02/22/2018 03:58 PM, Jon Evans wrote: Currently some of the render visibility stuff is saved in the application preferences, and some is not saved. I think if there are layers related to board

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

3. It would be nice to have right click menu with something like:     "Show all footprint related"     "Hide all footprint related"     "Show all free primitives"     "Hide all free primitives"     "Show all other???"     "Hide all other???"     "Show all"     "Hide all" Don't we

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

On Feb 22, 2018, at 7:58 AM, Jon Evans wrote: > > Currently some of the render visibility stuff is saved in the application > preferences, and some is not saved. > I think if there are layers related to board item visibility that aren't > saved, saving them in the project

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Currently some of the render visibility stuff is saved in the application preferences, and some is not saved. I think if there are layers related to board item visibility that aren't saved, saving them in the project or board makes more sense than saving in the app config. Re. 3, yes I think that

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

On 2/22/2018 9:10 AM, Andrzej Wolski wrote: > If some work on Render panel is still being done, I would have some > suggestions: > 1. "Text Front" and "Text Back" should be renamed to something like > "Footpr. Text Front" It is misleading now. I'm fine with this but please do not abbreviate the

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

If some work on Render panel is still being done, I would have some suggestions: 1. "Text Front" and "Text Back" should be renamed to something like "Footpr. Text Front" It is misleading now. 2. "Bl/Bburied Via" and "Micro Via" could be hidden if they are disabled in design settings. 3. It

Re: [Kicad-developers] [PATCH] Rearrange Render panel of PcbNew layer widget; add spacers

Jon, I'm fine with the rearranging but I think Jeff is doing some work on the layer manager. You might want to coordinate with him to make sure you don't end up with a big merge clash. Cheers, Wayne On 2/21/2018 11:39 PM, Jon Evans wrote: > Hi all, > > This patch rearranges the Render panel