Re: [Kicad-developers] [PATCH] Selection appearance options

2019-11-27 Thread Jonatan Liljedahl 
Thanks!

I will revisit patch #2 and make the selection thickness configurable
as well, with a default value that keeps the current appearance.

Cheers

On Wed, Nov 27, 2019 at 5:06 AM Seth Hillbrand  wrote:
>
> On 2019-11-23 05:46, Jonatan Liljedahl wrote:
>
> > Thanks Seth,
> >
> > I'm on Mac only (my linux box hasn't been powered on since 5 years or
> > so). The code I touched should not look different depending on
> > platform. I guess any difference would rather be in how colors are
> > presented (considering the #ifdef MAC around default
> > selection-highlight color), but even in that case I strongly suspect
> > this is rather about the monitor rather than operating system!
> >
> > Cheers
> >
> > On Fri, Nov 22, 2019 at 6:25 PM Seth Hillbrand 
> > wrote:
> >
> > On 11/21/19 8:01 AM, Jonatan Liljedahl wrote:
> >
> > Hi,
> >
> > Here comes two patches regarding the selection appearance.
> >
> > Patch #1: Adds three new options in the settings dialog:
> >
> > - Draw selected text items as box
> > Instead of drawing a stroked shadow behind the text, a rounded
> > rectangle is drawn according to the text boundary box.
> >
> > - Draw selected child items
> > When disabled, only the main selected item is drawn with the selection
> > shadow, not the various fields and pin names etc. Default is enabled
> > (current behaviour)
> >
> > - Fill selected shapes
> > Any selected shapes has their selection shadow filled, instead of just
> > drawing along the lines.
> >
> > See attached screenshots for a demonstration of some various
> > combinations of these settings.
> >
> > Patch #2: Tweaks the amount of zoom-level impact on the selection
> > shadow thickness, to get a more coherent look while zooming. You need
> > to try this in action to know if it's good (I think it is).
> >
> > Cheers
> >
>
> Hi Jonatan-
>
> I tested the functionality of these patches and they seem to work as
> advertised.  The dialog boxes look correct on my Linux box.  Patch #2
> makes the selections very large to my eye, so I haven't pushed that one
> but I did push the selection options patch.
>
> Thank you for your contribution to KiCad!
>
> -Seth
>
> Seth Hillbrand
> KiCad Services Corporation
> https://www.kipro-pcb.com
> +1 530 302 5483 | +1 212 603 9372



-- 
/Jonatan
http://kymatica.com

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Selection appearance options

2019-11-26 Thread Seth Hillbrand 

On 2019-11-23 05:46, Jonatan Liljedahl wrote:


Thanks Seth,

I'm on Mac only (my linux box hasn't been powered on since 5 years or 
so). The code I touched should not look different depending on 
platform. I guess any difference would rather be in how colors are 
presented (considering the #ifdef MAC around default 
selection-highlight color), but even in that case I strongly suspect 
this is rather about the monitor rather than operating system!


Cheers

On Fri, Nov 22, 2019 at 6:25 PM Seth Hillbrand  
wrote:


On 11/21/19 8:01 AM, Jonatan Liljedahl wrote:

Hi,

Here comes two patches regarding the selection appearance.

Patch #1: Adds three new options in the settings dialog:

- Draw selected text items as box
Instead of drawing a stroked shadow behind the text, a rounded
rectangle is drawn according to the text boundary box.

- Draw selected child items
When disabled, only the main selected item is drawn with the selection
shadow, not the various fields and pin names etc. Default is enabled
(current behaviour)

- Fill selected shapes
Any selected shapes has their selection shadow filled, instead of just
drawing along the lines.

See attached screenshots for a demonstration of some various
combinations of these settings.

Patch #2: Tweaks the amount of zoom-level impact on the selection
shadow thickness, to get a more coherent look while zooming. You need
to try this in action to know if it's good (I think it is).

Cheers



Hi Jonatan-

I tested the functionality of these patches and they seem to work as 
advertised.  The dialog boxes look correct on my Linux box.  Patch #2 
makes the selections very large to my eye, so I haven't pushed that one 
but I did push the selection options patch.


Thank you for your contribution to KiCad!

-Seth

Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Selection appearance options

2019-11-23 Thread Jonatan Liljedahl 
Thanks Seth,

I'm on Mac only (my linux box hasn't been powered on since 5 years or so).
The code I touched should not look different depending on platform. I guess
any difference would rather be in how colors are presented (considering the
#ifdef MAC around default selection-highlight color), but even in that case
I strongly suspect this is rather about the monitor rather than operating
system!

Cheers

On Fri, Nov 22, 2019 at 6:25 PM Seth Hillbrand  wrote:

> On 11/21/19 8:01 AM, Jonatan Liljedahl wrote:
>
> Hi,
>
> Here comes two patches regarding the selection appearance.
>
> Patch #1: Adds three new options in the settings dialog:
>
> - Draw selected text items as box
> Instead of drawing a stroked shadow behind the text, a rounded
> rectangle is drawn according to the text boundary box.
>
> - Draw selected child items
> When disabled, only the main selected item is drawn with the selection
> shadow, not the various fields and pin names etc. Default is enabled
> (current behaviour)
>
> - Fill selected shapes
> Any selected shapes has their selection shadow filled, instead of just
> drawing along the lines.
>
> See attached screenshots for a demonstration of some various
> combinations of these settings.
>
> Patch #2: Tweaks the amount of zoom-level impact on the selection
> shadow thickness, to get a more coherent look while zooming. You need
> to try this in action to know if it's good (I think it is).
>
> Cheers
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
> Hi Jonatan-
>
> Thanks for this patch.  I'll give this a test run this weekend.  I know
> that the Mac display of highlight was always a bit different than Linux, so
> it would be good if one of our Mac devs also tested for issues.
>
> Best-
> Seth
>
> --
> KiCad Services Corporation [image: KiCad Services Corporation Logo]
> Seth Hillbrand
> *Lead Developer*
> +1-530-302-5483‬ <+12126039372>
> Davis, CA
> [email protected]
> https://twitter.com/KiProEDA 
> https://www.linkedin.com/company/kicad
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : [email protected]
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


-- 
/Jonatan
http://kymatica.com
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Selection appearance options

2019-11-22 Thread Seth Hillbrand 

On 11/21/19 8:01 AM, Jonatan Liljedahl wrote:

Hi,

Here comes two patches regarding the selection appearance.

Patch #1: Adds three new options in the settings dialog:

- Draw selected text items as box
Instead of drawing a stroked shadow behind the text, a rounded
rectangle is drawn according to the text boundary box.

- Draw selected child items
When disabled, only the main selected item is drawn with the selection
shadow, not the various fields and pin names etc. Default is enabled
(current behaviour)

- Fill selected shapes
Any selected shapes has their selection shadow filled, instead of just
drawing along the lines.

See attached screenshots for a demonstration of some various
combinations of these settings.

Patch #2: Tweaks the amount of zoom-level impact on the selection
shadow thickness, to get a more coherent look while zooming. You need
to try this in action to know if it's good (I think it is).

Cheers

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Hi Jonatan-

Thanks for this patch.  I'll give this a test run this weekend.  I know 
that the Mac display of highlight was always a bit different than Linux, 
so it would be good if one of our Mac devs also tested for issues.


Best-
Seth

--
KiCad Services Corporation KiCad Services Corporation Logo
Seth Hillbrand
*Lead Developer*
+1-530-302-5483‬ 
Davis, CA
www.kipro-pcb.com  [email protected] 

https://twitter.com/KiProEDA  
https://www.linkedin.com/company/kicad 



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Selection appearance options

2019-11-21 Thread Kevin Cozens 

On 2019-11-21 11:01 a.m., Jonatan Liljedahl wrote:

Here comes two patches regarding the selection appearance.


I'm just curious as to what is the problem that the proposed patches are 
meant to address? (I may have missed the information in an earlier email).


Is the idea to provide a much more visible indicator of what has been 
selected than just reducing colour saturation, particularly when zoomed out?


One question about the proposed patches. Have they been tested with symbols 
containing the yellow infill?


--
Cheers!

Kevin.

http://www.ve3syb.ca/   | "Nerds make the shiny things that
https://www.patreon.com/KevinCozens | distract the mouth-breathers, and
| that's why we're powerful"
Owner of Elecraft K2 #2172  |
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp