Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-24 Thread Greg Smith
I have placed the KiCad Python Style Guide in  https://github.com/HiGregSmith/kicad-python-style-guidefor comment. It is not formatted particularly well, but captures everything mentioned in this thread. I thought it was important to include the "Logistics" section because that is hard to find

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-14 Thread Wayne Stambaugh
On 8/12/2017 11:59 AM, Greg Smith wrote: > Where should I submit a (likely short) style guide for review? The KiCad developer's mailing list. > > I have recently reviewed PEP8 and updated the code for KiPadCheck and > LayerViewSet to be compliant, so I can write a short document about the

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-12 Thread Wayne Stambaugh
On 8/12/2017 1:05 PM, Simon Küppers wrote: > I wrote a developer Documentation Page on Python scripting for kicad, i > think the information is best written down there. I have no objections to this. I could just as easily be added to the coding policy in a separate section for Python scripting.

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-12 Thread Wayne Stambaugh
I'm OK with pep8 or some variation there of. On 8/12/2017 12:42 PM, Adam Wolf wrote: > Sure. I was actually in the audience for that talk :) IIRC, the > biggest takeaway is that sometimes there are exceptions, especially > for highly idiomatic code, and also that the 80 character original >

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-12 Thread Simon Küppers
I wrote a developer Documentation Page on Python scripting for kicad, i think the information is best written down there. Am 12. August 2017 18:42:05 MESZ schrieb Adam Wolf : >Sure. I was actually in the audience for that talk :) IIRC, the >biggest takeaway is

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-12 Thread Adam Wolf
Sure. I was actually in the audience for that talk :) IIRC, the biggest takeaway is that sometimes there are exceptions, especially for highly idiomatic code, and also that the 80 character original line length limit is silly today and something like 120 is more appropriate. If you have

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-12 Thread Kevin Cozens
On 2017-08-12 11:43 AM, Adam Wolf wrote: I think PEP8 is great for us. Let's just add a line that says "We use PEP8 as our Python style guide." Before you get too deep in to following PEP8 you might want to watch the video of a talk given by Raymond Hettinger (a core Python programmer) at

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-12 Thread Greg Smith
Where should I submit a (likely short) style guide for review? I have recently reviewed PEP8 and updated the code for KiPadCheck and LayerViewSet to be compliant, so I can write a short document about the KiCad Python style for others to review. There are other guides similar to style guides

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-12 Thread Adam Wolf
I think PEP8 is great for us. Let's just add a line that says "We use PEP8 as our Python style guide." Adam Wolf On Sat, Aug 12, 2017 at 10:27 AM, Strontium wrote: > Hello Wayne and Greg, > > Can I suggest just adopting PEP8 for Python code formatting. Its clean, > well

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-12 Thread Strontium
Hello Wayne and Greg, Can I suggest just adopting PEP8 for Python code formatting. Its clean, well documented, and there are plenty of linters to check conformance. And if there is anything in PEP8 that is annoying for KiCad development (cant imagine what) just specify an exclusion or

Re: [Kicad-developers] Python script offered as example for Action Plugin and wxFormBuilder integration

2017-08-12 Thread Wayne Stambaugh
On 8/11/2017 10:08 PM, Greg Smith wrote: > What is the process of getting a python example script into KiCad > distribution? You must submit a patch (preferably using `git format-patch` against the HEAD of the KiCad master branch) to the developer's mailing list so developers can test and comment