Re: [Kicad-developers] Version 5.1 backward compatibility with 5.0 (polygon for outline)

[Wayne Stambaugh]

On 12/10/2018 9:17 AM, Seth Hillbrand wrote:
> Am 2018-12-10 08:08, schrieb Wayne Stambaugh:
>>
>> We should back this change out until v6.  We have an unwritten policy
>> (although maybe I should write it down) about not changing file formats
>> during a stable release series.  Boards designed with 5.1.x should
>> produce the same output as boards designed with 5.0.x.
> 
> Sounds good!  I've adjusted the output so that drawing with the polygon
> tool produces segments on the edge cuts layer.  This keeps compatibility
> with v5.0.x.
> 
> Best-
> Seth

Thanks for the quick response Seth.  I appreciate it.

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Version 5.1 backward compatibility with 5.0 (polygon for outline)

[Seth Hillbrand]

Am 2018-12-10 08:08, schrieb Wayne Stambaugh:


We should back this change out until v6.  We have an unwritten policy
(although maybe I should write it down) about not changing file formats
during a stable release series.  Boards designed with 5.1.x should
produce the same output as boards designed with 5.0.x.


Sounds good!  I've adjusted the output so that drawing with the polygon 
tool produces segments on the edge cuts layer.  This keeps compatibility 
with v5.0.x.


Best-
Seth

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Version 5.1 backward compatibility with 5.0 (polygon for outline)

[Wayne Stambaugh]

On 12/10/2018 8:57 AM, Eeli Kaikkonen wrote:
> 
> 
> ma 10. jouluk. 2018 klo 15.10 Wayne Stambaugh (stambau...@gmail.com
> ) kirjoitti:
> 
> 
> We should back this change out until v6.  We have an unwritten policy
> (although maybe I should write it down) about not changing file formats
> during a stable release series.  Boards designed with 5.1.x should
> produce the same output as boards designed with 5.0.x.
> 
> 
> Strictly speaking this wasn't a file format change, and maybe that's why
> it went unnoticed. For compatibility also *interpretation* of the file
> format should stay exactly the same. The same situation could have
> happened with edge clearance. I tested it with 5.0 and HEAD and both
> seem to give the same result now, i.e. the width of the Edge.Cuts line
> affects the clearance. If I'm wrong it should be changed in development
> HEAD.
> 
> Eeli Kaikkonen
> 

Board output is not just the file format.  Changing the output results
(gerbers) of an unchanged board file is really dangerous in production
environments.  How are users expected to detect a subtle change like
this?  There is no way they would even be aware of the change unless
they ran a diff on their gerber files.  I am always going to error on
the side of caution with theses kinds of changes.

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Version 5.1 backward compatibility with 5.0 (polygon for outline)

[Eeli Kaikkonen]

ma 10. jouluk. 2018 klo 15.10 Wayne Stambaugh (stambau...@gmail.com)
kirjoitti:

>
> We should back this change out until v6.  We have an unwritten policy
> (although maybe I should write it down) about not changing file formats
> during a stable release series.  Boards designed with 5.1.x should
> produce the same output as boards designed with 5.0.x.
>
>
Strictly speaking this wasn't a file format change, and maybe that's why it
went unnoticed. For compatibility also *interpretation* of the file format
should stay exactly the same. The same situation could have happened with
edge clearance. I tested it with 5.0 and HEAD and both seem to give the
same result now, i.e. the width of the Edge.Cuts line affects the
clearance. If I'm wrong it should be changed in development HEAD.

Eeli Kaikkonen
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Version 5.1 backward compatibility with 5.0 (polygon for outline)

[Wayne Stambaugh]

On 12/9/2018 5:38 PM, Seth Hillbrand wrote:
> Am 2018-12-09 17:01, schrieb Eeli Kaikkonen:
>> Recently I realized that the new "graphic polygon for edge outline
>> feature", as great as it is, isn't compatible with 5.0. The 3D view
>> can't handle it and it's filled in gerber. So, if someone makes a pcb
>> file with nightly builds it's not necessarily compatible with 5.0.
>>
>> Is this allowed on purpose or is it an oversight?
> 
> Hi Eeli-
> 
> Hmm... That's a good point.  My original thinking was that 5.0 allowed
> drawing the polygon on edge cuts but it broke the things that you
> mentioned, so fixing the outline seemed more useful than prohibiting the
> layer.
> 
> But you are right, this creates an issue where the board will work with
> 5.1 and not with 5.0.  I guess we should back that change out and
> prohibit the layer until 6.0 unless there are other ideas.
> 
> -S
> 

We should back this change out until v6.  We have an unwritten policy
(although maybe I should write it down) about not changing file formats
during a stable release series.  Boards designed with 5.1.x should
produce the same output as boards designed with 5.0.x.

Cheers,

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Version 5.1 backward compatibility with 5.0 (polygon for outline)

[Seth Hillbrand]

Am 2018-12-09 17:01, schrieb Eeli Kaikkonen:

Recently I realized that the new "graphic polygon for edge outline
feature", as great as it is, isn't compatible with 5.0. The 3D view
can't handle it and it's filled in gerber. So, if someone makes a pcb
file with nightly builds it's not necessarily compatible with 5.0.

Is this allowed on purpose or is it an oversight?


Hi Eeli-

Hmm... That's a good point.  My original thinking was that 5.0 allowed 
drawing the polygon on edge cuts but it broke the things that you 
mentioned, so fixing the outline seemed more useful than prohibiting the 
layer.


But you are right, this creates an issue where the board will work with 
5.1 and not with 5.0.  I guess we should back that change out and 
prohibit the layer until 6.0 unless there are other ideas.


-S

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp