Re: [klee-dev] Bug(s) in ConstantExpr class

2012-09-11 Thread Cristian Cadar
Hi Dan, Thanks for your message. I agree with your fixes to getTrue() and getFalse(); I applied your patch in r163606: http://llvm.org/viewvc/llvm-project?rev=163606view=rev Regarding ConstantExpr::getZExtValue(), I think the current version is correct. The bits argument simply states the

Re: [klee-dev] Bug(s) in ConstantExpr class

2012-09-11 Thread Delcypher
Thanks Cristian. Your explanation makes sense so I guess there's nothing really wrong with the ConstantExpr::getZExtValue() method implementation but I do think the description could be improved as Return the constant value for a limited number of bits. makes it sounds as if the bit parameter to