[kmymoney4] [Bug 383161] Broken net worth graph in case data contains only the same value

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383161

--- Comment #4 from Ralf Habacker  ---
(In reply to Ralf Habacker from comment #3)
> 
>   QVector< double > vec0,  vec1, vec2;
> -  vec0 << 5 << 1 << 3 << 4 << 1;
> -  vec1 << 3 << 6 << 2 << 4 << 8;
> -  vec2 << 0 << 7 << 1 << 2 << 1;´
> +// vec0 << 5 << 1 << 3 << 4 << 1;
> +// vec1 << 3 << 6 << 2 << 4 << 8;
> +  vec3 << 7 << 7 << 7 << 7 << 7;
This should be vec2 instead, sorry.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383161] Broken net worth graph in case data contains only the same value

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383161

--- Comment #3 from Ralf Habacker  ---
(In reply to NSLW from comment #2)
> Ralf, it would be better if you would test master version before 'producing'
> bug.
> *** This bug has been marked as a duplicate of bug 338642 ***

I don't think that this is the same bug as 338642. 

git master now contains a short KChart widget test. You may modify
kmymoney/reports/tests/chart-test.cpp as shown below:

  QVector< double > vec0,  vec1, vec2;
-  vec0 << 5 << 1 << 3 << 4 << 1;
-  vec1 << 3 << 6 << 2 << 4 << 8;
-  vec2 << 0 << 7 << 1 << 2 << 1;´
+// vec0 << 5 << 1 << 3 << 4 << 1;
+// vec1 << 3 << 6 << 2 << 4 << 8;
+  vec3 << 7 << 7 << 7 << 7 << 7;

and let the app run which shows the mentioned behavior.

Then modify

  CartesianAxis *yAxis = new CartesianAxis (widget.lineDiagram() );
+
static_cast(widget.lineDiagram()->coordinatePlane())->setAutoAdjustVerticalRangeToData(101);

and run again - bug is fixed

then modify again

-
static_cast(widget.lineDiagram()->coordinatePlane())->setAutoAdjustVerticalRangeToData(101);
+
static_cast(widget.lineDiagram()->coordinatePlane())->setAutoAdjustVerticalRangeToData(2);

and compile and run again - bug is not fixed.

If you can confirm please restore bug state.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383161] Broken net worth graph in case data contains only the same value

[NSLW]

https://bugs.kde.org/show_bug.cgi?id=383161

NSLW  changed:

   What|Removed |Added

 Resolution|FIXED   |DUPLICATE
 CC||lukasz.wojnilow...@gmail.co
   ||m

--- Comment #2 from NSLW  ---
Ralf, it would be better if you would test master version before 'producing'
bug.

*** This bug has been marked as a duplicate of bug 338642 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 338642] Chart type line doesn't adjust minimum value on graph if the report is older than 4 months.

[NSLW]

https://bugs.kde.org/show_bug.cgi?id=338642

NSLW  changed:

   What|Removed |Added

 CC||ralf.habac...@freenet.de

--- Comment #7 from NSLW  ---
*** Bug 383161 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383163] CATEGORIES doesn't toggle between Expense and Income. It's stuck on Income.

[Jack]

https://bugs.kde.org/show_bug.cgi?id=383163

Jack  changed:

   What|Removed |Added

 CC||ostroffjh@users.sourceforge
   ||.net

--- Comment #1 from Jack  ---
Please provide more detail about exactly when/where this happens - which view
and what are you trying to do?  Many account/category lists include both income
and expense, so you just have to scroll.  A screenshot might also help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383165] Networth report shows wrong values

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=383165

Thomas Baumgart  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #4 from Thomas Baumgart  ---
this seems to cause the problem

commit bda676a62ecca82de350d15a5086619a02420af0
Author: Ralf Habacker 
Date:   Sun Oct 2 17:50:11 2016 +0200

Show more accounts in account tab of report settings dialog.

Simply reverting is not enough. Once reverted you can load the test file and
the false report is still false whereas the default report now shows correct
results. One needs to file it once to fix the file so we need a fix to solve
this issue in code also.  Arrrgh.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383165] Networth report shows wrong values

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=383165

--- Comment #3 from Thomas Baumgart  ---
Created attachment 107091
  --> https://bugs.kde.org/attachment.cgi?id=107091=edit
Demo file with two customized networth reports

And not only the equity accounts: also income and expense accounts are used.
That certainly is absolutely false. The attached file shows the problem (at
least in master). It contains two customized reports (correct and false). The
false one is a copy of the default networth report just the name has been
adjusted. I tweaked the configuration so that the correct one shows how the
graph must appear.

Ralf, can you check if the default (false) one also shows false values in 4.8
so that we know about the status of 4.8. 

Also, I noticed that the account tab of the report configuration now shows all
five account groups when only two (or maybe three with equities) are allowed.
To have income and expenses here is *wrong*. I have no idea where this comes
from.

Again, let's check if this is in 4.8 as well as master or only master.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 366492] OFX Import dialog does not import OFX files

[Alexandre]

https://bugs.kde.org/show_bug.cgi?id=366492

--- Comment #5 from Alexandre  ---
Thomas, thanks for the correction, that statement is redundant. I was debugging
some seg fault and changed this function a few times and forced that
initialization to check and forgot to remove it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [kmymoney] kmymoney: Merge remote-tracking branch 'origin/4.8'

[Thomas Baumgart]

Hi Ralf,

your recent merge introduced a report test case which is interactive. This 
breaks the CI system running in the background. I think, I have to disable 
this one for now.

Details: 
https://build.kde.org/job/Extragear%20kmymoney%20kf5-qt5%20SUSEQt5.9/55/console

Regards

Thomas

On Samstag, 5. August 2017 12:02:36 CEST Ralf Habacker wrote:

> Git commit 27443863f75d183312c7c6842ab7c76faf5cbd33 by Ralf Habacker.
> Committed on 05/08/2017 at 11:58.
> Pushed by habacker into branch 'master'.
> 
> Merge remote-tracking branch 'origin/4.8'
> 
> # Conflicts:

[...]

-- 

Regards

Thomas Baumgart

https://www.telegram.org/   Telegram, the better WhatsApp
-
Real backups of your NAS can be found with the NSA
-


signature.asc
Description: This is a digitally signed message part.

[kmymoney4] [Bug 383165] Networth report shows wrong values

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=383165

--- Comment #2 from Thomas Baumgart  ---
Created attachment 107088
  --> https://bugs.kde.org/attachment.cgi?id=107088=edit
Report output

No, it is still broken (at least in master). The equity accounts are completely
wrong here. They don't have to be used in this calculation.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383165] Networth report shows wrong values

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383165

Ralf Habacker  changed:

   What|Removed |Added

 CC||ralf.habac...@freenet.de

--- Comment #1 from Ralf Habacker  ---
The commits which fixes bug 382378 has been recently merged into master and
should  fix that in master too. Can you retest ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383165] New: Networth report shows wrong values

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=383165

Bug ID: 383165
   Summary: Networth report shows wrong values
   Product: kmymoney4
   Version: git (master)
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: reports
  Assignee: kmymoney-devel@kde.org
  Reporter: tbaumg...@kde.org
  Target Milestone: ---

Some recent changes to the report sub-system must have broken something. The
networth report shows wrong values. Use demo file stored in bug 382378
https://bugs.kde.org/attachment.cgi?id=106679 and open "Report/Networth today"
and compare the value with the one provided on the home view.

Looks like the equity accounts are taken into account here. This is wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383163] New: CATEGORIES doesn't toggle between Expense and Income. It's stuck on Income.

[Sy]

https://bugs.kde.org/show_bug.cgi?id=383163

Bug ID: 383163
   Summary: CATEGORIES doesn't toggle between Expense and Income.
It's stuck on Income.
   Product: kmymoney4
   Version: 4.8.0
  Platform: unspecified
OS: MS Windows
Status: UNCONFIRMED
  Severity: critical
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: syr...@optimum.net
  Target Milestone: ---

CATEGORIES doesn't toggle between Expense and Income. It's stuck on Income.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kdiagram] [Bug 383160] Crash on showing investment price chart

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=383160

Thomas Baumgart  changed:

   What|Removed |Added

Product|kmymoney4   |kdiagram
  Component|general |KChart
 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 CC||kmymoney-devel@kde.org
   Assignee|kmymoney-devel@kde.org  |kosse...@kde.org

--- Comment #3 from Thomas Baumgart  ---
Reopened and moved to KDiagram and assigned to maintainer for upstream handling

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.

[kmymoney4] [Bug 383161] Broken net worth graph in case data contains only the same value

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383161

Ralf Habacker  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kmy
   ||money/df06a0d0e44c4b21c9675
   ||abff4f7809534b65e05
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.8.1

--- Comment #1 from Ralf Habacker  ---
Git commit df06a0d0e44c4b21c9675abff4f7809534b65e05 by Ralf Habacker.
Committed on 05/08/2017 at 09:16.
Pushed by habacker into branch '4.8'.

Fix 'Broken net worth graph in case data contains only the same value'

If chart model contains only data with the same value KDChart 2.6
automatically adjust the vertical range to a non visible area
and displays x axis labels at the top of the diagram.

The fix is to disable "auto adjust vertical range to data". The used
value has been empirically determined.

FIXED-IN:4.8.1

M  +1-0kmymoney/reports/kreportchartview.cpp

https://commits.kde.org/kmymoney/df06a0d0e44c4b21c9675abff4f7809534b65e05

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383161] New: Broken net worth graph in case data contains only the same value

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383161

Bug ID: 383161
   Summary: Broken net worth graph in case data contains only the
same value
   Product: kmymoney4
   Version: unspecified
  Platform: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: reports
  Assignee: kmymoney-devel@kde.org
  Reporter: ralf.habac...@freenet.de
  Target Milestone: ---

Created attachment 107083
  --> https://bugs.kde.org/attachment.cgi?id=107083=edit
kmymoney test file

After updating kdchart to 2.6 in 4.8 branch (see bug 382427) kmymoney shows a
broken net worse graph in case the graph contains only data with the same value

How to reproduce: 
1. compile kmymoney from 4.8 branch
2. download kmymoney test file from this bug
3. start kmymoney and open file downloaded with 2.
4. Choose Reports -> net worth test report

What happens ?
There is no graph shown and the x axis labels are displayed at the top of the
page

What is expected ?
kmymoney should show the complete graph

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383110] Labels overlap with points

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383110

Ralf Habacker  changed:

   What|Removed |Added

   Version Fixed In||4.8.1
 Resolution|--- |DUPLICATE
 Status|CONFIRMED   |RESOLVED

--- Comment #6 from Ralf Habacker  ---


*** This bug has been marked as a duplicate of bug 382427 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 382427] Incorrect formatting of number display of point label in graph reports

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=382427

Ralf Habacker  changed:

   What|Removed |Added

 CC||xtem...@gmail.com

--- Comment #15 from Ralf Habacker  ---
*** Bug 383110 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383160] Crash on showing investment price chart

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383160

Ralf Habacker  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kmy
   ||money/751e731ac783224e2b8d5
   ||5d734aa0c203f41ded9
 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.8.1
 Resolution|--- |FIXED

--- Comment #2 from Ralf Habacker  ---
Git commit 751e731ac783224e2b8d55d734aa0c203f41ded9 by Ralf Habacker.
Committed on 05/08/2017 at 08:57.
Pushed by habacker into branch '4.8'.

Fix crash accessing wrong data array on investment price graph

The crash happened because position.column is not used to check
the requested data array instead it checks always the first data
array which fails later in case position.row exceeds array
size.

This commit needs to be posted to the KDChart bug tracker too to be
included in further KDChart releases.

FIXED-IN:4.8.1

M  +1-1   
libkdchart/src/KDChart/Cartesian/KDChartCartesianDiagramDataCompressor_p.cpp

https://commits.kde.org/kmymoney/751e731ac783224e2b8d55d734aa0c203f41ded9

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383160] Crash on showing investment price chart

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383160

Ralf Habacker  changed:

   What|Removed |Added

   Severity|normal  |crash
Summary|Crash on showing investment |Crash on showing investment
   |price report|price chart

--- Comment #1 from Ralf Habacker  ---
Stacktrace: 

Application: KMyMoney (kmymoney), signal: Aborted
Using host libthread_db library "/lib64/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f9e93c39900 (LWP 25110))]

Thread 2 (Thread 0x7f9e745b1700 (LWP 25118)):
#0  0x7f9e8af58468 in pthread_cond_timedwait@@GLIBC_2.3.2 () at
/lib64/libpthread.so.0
#1  0x7f9e8edc1134 in QWaitCondition::wait(QMutex*, unsigned long)
(time=3, this=0x3249a10) at thread/qwaitcondition_unix.cpp:84
#2  0x7f9e8edc1134 in QWaitCondition::wait(QMutex*, unsigned long)
(this=this@entry=0x3caff00, mutex=mutex@entry=0x3c49a48, time=3) at
thread/qwaitcondition_unix.cpp:158
#3  0x7f9e8edb4b9a in QThreadPoolThread::run() (this=0x3cafef0) at
concurrent/qthreadpool.cpp:142
#4  0x7f9e8edc0c6f in QThreadPrivate::start(void*) (arg=0x3cafef0) at
thread/qthread_unix.cpp:352
#5  0x7f9e8af53744 in start_thread () at /lib64/libpthread.so.0
#6  0x7f9e8df6baad in clone () at /lib64/libc.so.6

Thread 1 (Thread 0x7f9e93c39900 (LWP 25110)):
[KCrash Handler]
#6  0x7f9e8deb68d7 in raise () at /lib64/libc.so.6
#7  0x7f9e8deb7caa in abort () at /lib64/libc.so.6
#8  0x7f9e8edb6694 in qt_message_output(QtMsgType, char const*)
(msgType=msgType@entry=QtFatalMsg, buf=) at
global/qglobal.cpp:2423
#9  0x7f9e8edb6819 in qt_message(QtMsgType, const char *, typedef
__va_list_tag __va_list_tag *) (msgType=msgType@entry=QtFatalMsg,
msg=msg@entry=0x7f9e8ef239a0 "ASSERT failure in %s: \"%s\", file %s, line %d",
ap=ap@entry=0x7ffc94c524a8) at global/qglobal.cpp:2469
#10 0x7f9e8edb7024 in qFatal(char const*, ...)
(msg=msg@entry=0x7f9e8ef239a0 "ASSERT failure in %s: \"%s\", file %s, line %d")
at global/qglobal.cpp:2652
#11 0x7f9e8edb708e in qt_assert_x(char const*, char const*, char const*,
int) (where=where@entry=0x7f9e93615fc1 "QVector::operator[]",
what=what@entry=0x7f9e93615fae "index out of range",
file=file@entry=0x7f9e93614ca0 "/usr/include/QtCore/qvector.h",
line=line@entry=359) at global/qglobal.cpp:2126
#12 0x7f9e935d8077 in
QVector::operator[](int)
(this=0xbdbff78, i=i@entry=105) at /usr/include/QtCore/qvector.h:359
#13 0x7f9e935d4613 in
KDChart::CartesianDiagramDataCompressor::invalidate(KDChart::CartesianDiagramDataCompressor::CachePosition
const&) (this=this@entry=0x7357058, position=...) at
/home/ralf/src/kmymoney-4.8/libkdchart/src/KDChart/Cartesian/KDChartCartesianDiagramDataCompressor_p.cpp:606
#14 0x7f9e935d47fc in
KDChart::CartesianDiagramDataCompressor::slotModelDataChanged(QModelIndex
const&, QModelIndex const&) (this=0x7357058, topLeftIndex=...,
bottomRightIndex=...) at
/home/ralf/src/kmymoney-4.8/libkdchart/src/KDChart/Cartesian/KDChartCartesianDiagramDataCompressor_p.cpp:257
#15 0x7f9e8eed62da in QMetaObject::activate(QObject*, QMetaObject const*,
int, void**) (sender=sender@entry=0x74ac0f0, m=m@entry=0x7f9e8f2266a0
,
local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x7ffc94c527a0)
at kernel/qobject.cpp:3576
#16 0x7f9e8ef20497 in QAbstractItemModel::dataChanged(QModelIndex const&,
QModelIndex const&) (this=this@entry=0x74ac0f0, _t1=..., _t2=...) at
.moc/release-shared/moc_qabstractitemmodel.cpp:163
#17 0x7f9e93593237 in KDChart::AttributesModel::slotDataChanged(QModelIndex
const&, QModelIndex const&) (this=0x74ac0f0, topLeft=..., bottomRight=...) at
/home/ralf/src/kmymoney-4.8/libkdchart/src/KDChart/KDChartAttributesModel.cpp:691
#18 0x7f9e8eed62da in QMetaObject::activate(QObject*, QMetaObject const*,
int, void**) (sender=sender@entry=0x7350890, m=m@entry=0x7f9e8f2266a0
,
local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x7ffc94c52940)
at kernel/qobject.cpp:3576
#19 0x7f9e8ef20497 in QAbstractItemModel::dataChanged(QModelIndex const&,
QModelIndex const&) (this=this@entry=0x7350890, _t1=..., _t2=...) at
.moc/release-shared/moc_qabstractitemmodel.cpp:163
#20 0x7f9e8fe4e540 in
QStandardItemModelPrivate::itemChanged(QStandardItem*) (this=,
item=item@entry=0xbdbfc20) at itemviews/qstandarditemmodel.cpp:501
#21 0x7f9e8fe4efdd in QStandardItem::setData(QVariant const&, int)
(this=0xbdbfc20, value=..., role=) at
itemviews/qstandarditemmodel.cpp:829
#22 0x7f9e8fe51b70 in QStandardItemModel::setData(QModelIndex const&,
QVariant const&, int) (this=this@entry=0x7350890, index=..., value=...,
role=role@entry=0) at itemviews/qstandarditemmodel.cpp:2824
#23 0x00579cf7 in reports::KReportChartView::setDataCell(int, int,
double) (this=this@entry=0x7350850, row=row@entry=105, 

[kmymoney4] [Bug 383160] New: Crash on showing investment price report

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383160

Bug ID: 383160
   Summary: Crash on showing investment price report
   Product: kmymoney4
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kmymoney-devel@kde.org
  Reporter: ralf.habac...@freenet.de
  Target Milestone: ---

After updating kdchart to 2.6 in 4.8 branch (see bug 382427) kmymoney crashes
on generating investment price chart. 

How to reproduce: 
1. compile kmymoney from 4.8 branch
2. download attachment 106680 from bug 382378
3. start kmymoney and open kmymoney downloaded from 2
4. Choose Reports -> investment price char

What happens ?
kmymoney crashes

What is expected ?
kmymoney should not crash

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 382427] Incorrect formatting of number display of point label in graph reports

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=382427

--- Comment #14 from Ralf Habacker  ---
Git commit 51529f756008f2c879a92b0b3fef72a716e51e2b by Ralf Habacker.
Committed on 05/08/2017 at 08:44.
Pushed by habacker into branch '4.8'.

Add missing copyright header

bugzilla complaints about this.

M  +16   -0kmymoney/reports/reportcharttest.cpp

https://commits.kde.org/kmymoney/51529f756008f2c879a92b0b3fef72a716e51e2b

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 382427] Incorrect formatting of number display of point label in graph reports

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=382427

Ralf Habacker  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |FIXED
 Status|NEEDSINFO   |RESOLVED
  Latest Commit||https://commits.kde.org/kmy
   ||money/cb841612e11349aca26b6
   ||c4af4ff7dced9a95357
   Version Fixed In||4.8.1

--- Comment #13 from Ralf Habacker  ---
Git commit cb841612e11349aca26b6c4af4ff7dced9a95357 by Ralf Habacker.
Committed on 05/08/2017 at 08:35.
Pushed by habacker into branch '4.8'.

Update to KDChart 2.6

Also add test report chart.

FIXED-IN:4.8.1

https://commits.kde.org/kmymoney/cb841612e11349aca26b6c4af4ff7dced9a95357

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 356399] crash while saving file after report change with data loss

[Michał Walenciak]

https://bugs.kde.org/show_bug.cgi?id=356399

--- Comment #6 from Michał Walenciak  ---
I can confirm I have no crash any more. KMyMoney version 4.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 382427] Incorrect formatting of number display of point label in graph reports

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=382427

--- Comment #12 from Ralf Habacker  ---
(In reply to NSLW from comment #11)
> (In reply to Ralf Habacker from comment #10)
> > (In reply to NSLW from comment #9)
> > > (In reply to Ralf Habacker from comment #8)
> > > > (In reply to NSLW from comment #7)
> > > > > No problem here. Aren't the graphs look correct?
> > > > 
> > > > This is because kmymoney from master branch uses KDChart version 2.6.0 
> > > > which
> > > > has this bug fixed. 4.8 branch uses KDChart version 2.4.3 which is 
> > > > broken in
> > > > this area.
> > > 
> > > Then I would suggest either fix it 
> > 
> > I'm mostly ready with this - see at
> > https://github.com/rhabacker/kmymoney/commits/4.8-kdchart-2.6. 
> > Should I open a review request for this or simply merge into 4.8 ?
> 
> Maybe Thomas would like to review this, but if you just removed old one
> version and pasted new one version 
yes 
> and it works for you, then I think there is nothing to review.
I did not changed any major things. From the git log mentioned above you can
see that there is one commit with the update, two commits with fixed bugs I was
faced on testing (may be useful for master too) and one commit which adds a
simple chart test dialog, which makes it easier to debug chart issues in
future.
Talking about the bugs I guess it would be better to open separate bug reports
for it  to be able to have it public.

Also I will merge the two remaining commits - the update and the test dialog
into one commit to solve this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney4] [Bug 383110] Labels overlap with points

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=383110

Ralf Habacker  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||ralf.habac...@freenet.de

--- Comment #5 from Ralf Habacker  ---
This is caused by the same reason as bug 382427 has - an outdated KDChart
library used in the 4.8 branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kmymoney] [Bug 366492] OFX Import dialog does not import OFX files

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=366492

--- Comment #4 from Thomas Baumgart  ---
Alexandre, thanks for the proposed patch. I'll take care of it. I just wonder
what the following change is needed for:

-  QString accId;
+  QString accId = QString();

The additional assignment does not make any sense in my eyes. Maybe, you can
share the reasons.

-- 
You are receiving this mail because:
You are the assignee for the bug.