Re: [Koha] Koha upgrade from 3.16 to 16.11

2017-04-23 Thread Nicolas Legrand
Hey Jonathan, Hey Hugo, we also have trouble in 16.11 with tax calculation : mysql> select unitprice_tax_excluded, unitprice_tax_included from aqorders join aqinvoices on aqinvoices.invoiceid = aqorders.invoiceid where aqinvoices.invoiceid = 2674 limit 10;

Re: [Koha] Koha upgrade from 3.16 to 16.11

2017-04-21 Thread Jonathan Druart
Nick did open one, there is a patch to signoff, see bug 18471. On Thu, 20 Apr 2017 at 11:38 Jonathan Druart < jonathan.dru...@bugs.koha-community.org> wrote: > Yes indeed, the formatting should be done template side. > They are the only 2 occurrences of this kind apparently. > Did you open a bug

Re: [Koha] Koha upgrade from 3.16 to 16.11

2017-04-20 Thread Jonathan Druart
Yes indeed, the formatting should be done template side. They are the only 2 occurrences of this kind apparently. Did you open a bug report? On Thu, 20 Apr 2017 at 05:59 Nicolas Legrand wrote: > I think I now have something in invoice.pl : > >

Re: [Koha] Koha upgrade from 3.16 to 16.11

2017-04-20 Thread Nicolas Legrand
I think I now have something in invoice.pl : $line->{total_tax_excluded} = Koha::Number::Price->new( $line->{unitprice_tax_excluded} * $line->{quantity} )->format; $line->{total_tax_included} = Koha::Number::Price->new( $line->{unitprice_tax_included} * $line->{quantity} )->format;

Re: [Koha] Koha upgrade from 3.16 to 16.11

2017-04-19 Thread Jonathan Druart
Nicolas, what you describe can be ok, if the tax rate is 0. You need to provide ALL the price values from aqorders (quantity, listprice, unitprice, unitprice_tax_excluded, unitprice_tax_included, quantityreceived, rrp, rrp_tax_excluded, rrp_tax_included, ecost, ecost_tax_excluded,

Re: [Koha] Koha upgrade from 3.16 to 16.11

2017-04-19 Thread Nicolas Legrand
Sorry, it seems to be a problem with our conf, we avec a 0 taxes rate, since we buy from the whole world. 2017-04-19 17:16 GMT+02:00 Nicolas Legrand : > Hey Jonathan, Hey Hugo, > > we also have trouble in 16.11 with tax calculation : > > mysql> select

Re: [Koha] Koha upgrade from 3.16 to 16.11

2017-04-18 Thread Jonathan Druart
Hi Hugo, A big work has been done in price calculation in 16.11, see bug 13321 and related. It certainly comes from these patches. I guess you can see differences in orders as well? If you find one, would you be able to give us the vendor and order tax configuration as well as the prices and

[Koha] Koha upgrade from 3.16 to 16.11

2017-04-18 Thread Hugo Agud
Dear all We have just upgraded a koha from 3.16 (packages) to 16.11 and we're facing problems in aquisitions migration data. We have identified at least two types of issues... 1. Not all orders are shown in the module (they're al llinked to the records, then all the info is in mysql) for