Re: [Koha] Taking patron images out of db into a directory

2020-04-14 Thread dcook
Online: 02 8005 0595 -Original Message- Date: Thu, 9 Apr 2020 17:40:17 +0300 From: Mengu Yazicioglu To: Koha Subject: [Koha] Taking patron images out of db into a directory Message-ID: Content-Type: text/plain; charset=utf-8; format=flowed Hi all, We'd like to write a patch to move

Re: [Koha] Taking patron images out of db into a directory

2020-04-13 Thread BRANNON, CHRISTOPHER
I would also like to suggest while you are doing this, please add a way to manage this directory from Koha. I would see it as a huge asset if an administrator could browse and manage these images, along with images for other things, such as cover images, or even an online repository an

Re: [Koha] Taking patron images out of db into a directory

2020-04-13 Thread Mark Tompsett
Greetings, I wrote: Ouch! We were stuck on that version for the longest time. May you have success in coding and implementing your patch! To which Mengu Yazicioglu replied: Why do you think that we may not? We're supporting Koha since v.2, and we also did similar thing in 16.11. I

Re: [Koha] Taking patron images out of db into a directory

2020-04-13 Thread Tomas Cohen Arazi
Mengu, I read Mark as saying he's been there as well, stuck on a version for a long time due to some customization. I don't think he's talking about your ability to implement it at all! El lun., 13 abr. 2020 a las 5:57, Mengu Yazicioglu () escribió: > Hi, > > El sáb., 11 de abril de 2020 17:47,

Re: [Koha] Taking patron images out of db into a directory

2020-04-13 Thread Mengu Yazicioglu
Hi, El sáb., 11 de abril de 2020 17:47, Mengu Yazicioglu escribió: We've developed this kind of feature first for 3.20 version with more than 1,600,000 users in the past. Ouch! We were stuck on that version for the longest time. May you have success in coding and implementing your patch!

Re: [Koha] Taking patron images out of db into a directory

2020-04-11 Thread Mark Tompsett
Greetings, Tomas Cohen Arazi wrote: The first step: write the tests! +1000 By writing the tests first, you know what you are coding towards, and have full test coverage for what you are going to provide a patch for. This makes everything easier for reviewing. The test plan becomes: run the

Re: [Koha] Taking patron images out of db into a directory

2020-04-11 Thread Tomas Cohen Arazi
The first step: write the tests! El sáb., 11 de abril de 2020 17:47, Mengu Yazicioglu escribió: > Thanks for everyone's comments. > > We've developed this kind of feature first for 3.20 version with more > than 1,600,000 users in the past. > > Some of our new customers also wanted this feature

Re: [Koha] Taking patron images out of db into a directory

2020-04-11 Thread Mengu Yazicioglu
Thanks for everyone's comments. We've developed this kind of feature first for 3.20 version with more than 1,600,000 users in the past. Some of our new customers also wanted this feature for new versions and with your comments, we'll start to write it soon. Thanks everyone ! Mengü

Re: [Koha] Taking patron images out of db into a directory

2020-04-10 Thread Mark Tompsett
Greetings, I wrote: Mmmm... no. Owen replied: This kind of comment is completely counterproductive to meaningful cooperation. Please be constructive without being dismissive. If that had been all I wrote, then your comment would be valid in my mind. However, you didn't include the rest of

Re: [Koha] Taking patron images out of db into a directory

2020-04-10 Thread Eric Bégin
Mengu, We did something similar for one clients.  It's patrons pictures were on an external server using the borrowernumber as filename (they have  a unified id for all of their services) So their is definitively use cases for such a feature. In our case, we just "hacked" the picture URL with

Re: [Koha] Taking patron images out of db into a directory

2020-04-10 Thread Owen Leonard
On Fri, Apr 10, 2020 at 3:50 PM Mark Tompsett wrote: > Mmmm... no. This kind of comment is completely counterproductive to meaningful cooperation. Please be constructive without being dismissive. -- Owen -- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org

Re: [Koha] Taking patron images out of db into a directory

2020-04-10 Thread Katrin Fischer
Hi Mark and all, I kind of disagree with a few points. I see no harm in storing the patron images optionally outside of the database as suggested by Owen. I don't think the database is a good place to store files actually, storing them outside makes a lot of sense to me. Patron images are

Re: [Koha] Taking patron images out of db into a directory

2020-04-10 Thread Mark Tompsett
Greetings, We'd like to write a patch to move patron images out of db into a directory in the server. Mmmm... no. People doing backups might forget to supplement the default Koha backup with that specific directory, and come a system failure and a restore later... they discover the photos are

Re: [Koha] Taking patron images out of db into a directory

2020-04-10 Thread Owen Leonard
> We'd like to write a patch to move patron images out of db into a > directory in the server. I think this is a good idea. There's no reason not to offer it as a choice if it's possible to do both. I think an argument could be made that it shouldn't be a choice presented to the librarian and

[Koha] Taking patron images out of db into a directory

2020-04-09 Thread Mengu Yazicioglu
Hi all, We'd like to write a patch to move patron images out of db into a directory in the server. By this change, we'd like to satisfy following. 1. The size of database backup will be decreased, by this way one may store db backups more. 2. Database performance will increase 3. It will