[Koha-bugs] [Bug 25305] Double UTF-8 encoding on translation files

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 103875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103875&action=edit Bug 25305: fix double encoding in translation files Changes inroduced i

[Koha-bugs] [Bug 25305] New: Double UTF-8 encoding on translation files

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25305 Bug ID: 25305 Summary: Double UTF-8 encoding on translation files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: N

[Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Nick Clemens changed: What|Removed |Added Summary|Make AutoCreateAuthorities |AutoCreateAuthorities can

[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #5 from Owen Leonard --- Created attachment 103874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103874&action=edit Screenshot showing option to search in Koha (Firefox) -- You are receiving this mai

[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #4 from Owen Leonard --- Created attachment 103873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103873&action=edit Screenshot showing menu for adding search engine in Firefox -- You are receiving th

[Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 fro

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #20 from Martin Renvoize --- Ah.. sorry.. I hadn't spotted you were worried about the$_ as apposed to $@.. I thought it was the introduction of a 'warn' at all you were commenting on. Yes, as Tomas explains, Try::Tiny ca

[Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168 --- Comment #8 from ciarebaha --- Created attachment 103872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103872&action=edit jQuery v1.7.2 The jquery used in this koha version is jQuery v1.7.2. Is your koha using

[Koha-bugs] [Bug 25189] Make AutoCreateAuthorities less of a footgun with LinkerModule: Default

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Nick Clemens changed: What|Removed |Added CC||martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 25189] Make AutoCreateAuthorities less of a footgun with LinkerModule: Default

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 --- Comment #5 from Nick Clemens --- Created attachment 103871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103871&action=edit Bug 25189: Don't create authority if results found Automatic authority creation assu

[Koha-bugs] [Bug 25189] Make AutoCreateAuthorities less of a footgun with LinkerModule: Default

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Nick Clemens changed: What|Removed |Added Attachment #103858|0 |1 is obsolete|

[Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168 --- Comment #7 from ciarebaha --- (In reply to Katrin Fischer from comment #5) > I first thought this could be Bug 22550 - OPAC suggestion form doesn't > require mandatory fields, but this is in 18.11 > > I have also checked that it

[Koha-bugs] [Bug 25189] Make AutoCreateAuthorities less of a footgun with LinkerModule: Default

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are re

[Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168 --- Comment #6 from ciarebaha --- Created attachment 103869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103869&action=edit Uncaught ReferenceError: ARRAY is not defined Yes, it seems like the cause came from th

[Koha-bugs] [Bug 22028] RecordedBooks integration with audio and magazine titles

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22028 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 7694] Syndetics Editons not included

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7694 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 10846] Add preference for naming OverDrive collection

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10846 --- Comment #2 from Owen Leonard --- Do we have the same problem with the LibraryName preference? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs m

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #12 from Jonathan Druart --- Does this make sense? -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. ___ Koha-bugs

[Koha-bugs] [Bug 23577] OPAC - patron e-mail notification of new login location

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23577 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 9606] When exporting to RIS the page information is not included

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9606 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #11 from Jonathan Druart --- Created attachment 103868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103868&action=edit Bug 23185: Make Koha::Objects->update loop on the object set if needed -- You

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #10 from Jonathan Druart --- Created attachment 103867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103867&action=edit Bug 23185: Add tests -- You are receiving this mail because: You are on the CC

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 25063] OPAC Renewal Option

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25063 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 --- Comment #3 from Owen Leonard --- Created attachment 103866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103866&action=edit Bug 11994: Fix OpenSearch discovery in the OPAC This patch corrects the markup for t

[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Stat

[Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 25246] Add script to export bib data to EBSCO EDS

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25246 --- Comment #13 from David Roberts --- (In reply to David Cook from comment #11) > (In reply to David Roberts from comment #10) > > We could have used OAI but there is at least one limitation, the main one > > being that EBSCO can't

[Koha-bugs] [Bug 25304] Some of the mark needs to be corrected

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25304 Timothy Alexis Vass changed: What|Removed |Added Status|NEW |ASSIGNED As

[Koha-bugs] [Bug 25304] New: Some of the mark needs to be corrected

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25304 Bug ID: 25304 Summary: Some of the mark needs to be corrected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW

[Koha-bugs] [Bug 14578] Allow merging of records upon import match

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED Assignee|

[Koha-bugs] [Bug 14578] Allow merging of records upon import match

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 103865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103865&action=edit Bug 25303: Make Koha::Objects->delete loop on the object set If we call Koha::L

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 103864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103864&action=edit Bug 25303: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are r

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103859|0 |1 is obsolete|

[Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines and whitespaces/linebreaks should be consistent.

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What|Removed |Added Summary|The indentations should be |The indentations shoul

[Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines.

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 --- Comment #1 from Timothy Alexis Vass --- Created attachment 103863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103863&action=edit === Indentations are now consistently 4 spaces and opening/closing tags are no

[Koha-bugs] [Bug 11994] Fix OpenSearch discovery in the OPAC

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Owen Leonard changed: What|Removed |Added Summary|Add option for installing a |Fix OpenSearch discovery in

[Koha-bugs] [Bug 25293] Don't call escapeHtml on null

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 didier changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receivin

[Koha-bugs] [Bug 25293] Don't call escapeHtml on null

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 --- Comment #1 from didier --- Created attachment 103862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103862&action=edit Bug 25293: Don't call escapeHtml on null Test Plan: 1) Create two Checkouts 2) v

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate,

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate,

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #9

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Martin Renvoize changed: What|Removed |Added Attachment #103812|0 |1 is obsolete|

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Martin Renvoize changed: What|Removed |Added Attachment #103811|0 |1 is obsolete|

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #9 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #8) > Is adding direct_update not adding the sidestep that you wanted to catch ? It's making the side step very explicit.. there are certainly times wh

[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.co

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master QA Conta

[Koha-bugs] [Bug 21472] Links in Additional Formats section of bib details do not work

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 Abbey Holt changed: What|Removed |Added CC||ah...@dubuque.lib.ia.us -- Yo

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Depends on||23185 Status|

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #8 from Marcel de Rooy --- Is adding direct_update not adding the side step that you wanted to catch ? -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. __

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Jonathan Druart changed: What|Removed |Added Blocks||23070 Referenced Bugs:

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #7 from Martin Renvoize --- Agreed with Jonathan that we should default Koha::Objects->update to loop through the resultset and call Koha::Object->store.. However, we should also allow for a direct_update option either b

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Jonathan Druart changed: What|Removed |Added Depends on||25303 Referenced Bugs:

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Blocks||23185 Referenced Bugs:

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Attachment #103855|0 |1 is obsolete|

[Koha-bugs] [Bug 25189] Make AutoCreateAuthorities less of a footgun with LinkerModule: Default

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 --- Comment #3 from Nick Clemens --- Created attachment 103858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103858&action=edit Bug 25189: Unit tests -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #3 from Tomás Cohen Arazi --- It all comes down to the DB triggers discussion... I agree we could enforce people overriding Koha::Thing->delete to take care of implementing and overriden Koha::Things->delete that is confo

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #93 from Jonathan Druart --- David, reading the last comments I noticed it may not be obvious: This patch set has been delayed because of the patron's attributes. In current master there is a hidden feature: you can ins

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #6 from Martin Renvoize --- More and more I feel like this needs to be caught at the QA level.. whenever we see the 'store' method being changed/created in a Koha::Thing class we should warn the QA person via the qa scrip

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #2 from Martin Renvoize --- This is more similar to bug 23185 than bug 21761. For performance reasons I'm not so sure about always forcing a loop rather than allowing a fast path.. I think I would rather see checks for t

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #19 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Marcel de Rooy from comment #17) > > (In reply to Martin Renvoize from comment #15) > > > > Why do you warn $_ ? > > > > > > Fol

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #92 from Jonathan Druart --- (In reply to David Nind from comment #91) > Just a couple of things from running through the testing again: > > 0) The mandatorty fields for self registration and editing worked for me! The

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #32

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #17) > (In reply to Martin Renvoize from comment #15) > > > Why do you warn $_ ? > > > > Following prior art. It makes sense to warn like this for s

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #17 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #15) > > Why do you warn $_ ? > > Following prior art. It makes sense to warn like this for such errors. I > have however added a Koha::Logger based

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #91 from David Nind --- Just a couple of things from running through the testing again: 0) The mandatorty fields for self registration and editing worked for me! 1) The image attached to the bug shows the human readable

[Koha-bugs] [Bug 25287] Add columns_settings support to API datatables wrapper

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25287 Tomás Cohen Arazi changed: What|Removed |Added See Also|https://bugs.koha-community | |.or

[Koha-bugs] [Bug 25288] Make the libraries list use the API

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25288 Tomás Cohen Arazi changed: What|Removed |Added See Also|https://bugs.koha-community | |.or

[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #2 from Martin Renvoize --- Created attachment 103857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103857&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #1 from Jonathan Druart --- Created attachment 103855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103855&action=edit Bug 25303: Make Koha::Objects->delete loop on the object set If we call Koha::Li

[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #1 from Martin Renvoize --- Created attachment 103856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103856&action=edit Bug 25261: Add system preference -- You are receiving this mail because: You are

[Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Summary|Koha::Objects->delete |Koha::Objects->delete

[Koha-bugs] [Bug 25303] New: Koha::Objects->delete should not skip overriden object class ->delete

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Bug ID: 25303 Summary: Koha::Objects->delete should not skip overriden object class ->delete Change sponsored?: --- Product: Koha Version: unspecified Hardwar

[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Nick Clemens changed: What|Removed |Added CC||ere.maij...@helsinki.fi,

[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Nick Clemens changed: What|Removed |Added Attachment #103801|0 |1 is obsolete|

[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are re

[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 --- Comment #2 from Nick Clemens --- Created attachment 103854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103854&action=edit Bug 25273: Make match-heading rely on authority type configuration The match-heading

[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #2 from Tomás Cohen Arazi --- (In reply to Frédéric Demians from comment #1) > This is an very annoying regression when using ES. You're right to point the > facet building process. I don't think filtering facets is a goo

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 --- Comment #6 from Tomás Cohen Arazi --- My conversation with one of the DBIx::Class authors: [17:56:51] weird question: if I know a query is going to return and empty resultset in advance, is there a way/helper to avoid performi

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #14 from Jonathan Druart --- From IRC: < Joubu> oleonard: there are 2 more .dropdown in opac-detail-sidebar.inc < oleonard> Joubu: I limited my search to the staff client since that's where the problematic combination

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #13 from Jonathan Druart --- Created attachment 103853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103853&action=edit Bug 25282: (follow-up) More corrections This patch adds more corrections missed

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 Jonathan Druart changed: What|Removed |Added Attachment #103816|0 |1 is obsolete|

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rec

[Koha-bugs] [Bug 20846] Suppressed Records Still Appear in Public Lists

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20846 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 24201] Attach desk to intranet session

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Status|Failed QA |In Discussion -- You are

[Koha-bugs] [Bug 5161] Patron attributes clearing if duplicate warning

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_05_candidate,| |RM_pri

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #11 from Owen Leonard --- Created attachment 103851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103851&action=edit Bug 25282: (follow-up) More corrections This patch adds more corrections missed in

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Frédéric Demians from comment #4) > Coming back from bug 25297, I have a question: Is it necessary to explicitly > call: > > Koha::Objects->new->empty; > > When you assign a

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

2020-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #89 from Jonathan Druart --- Created attachment 103850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103850&action=edit Bug 22844: Make the patron's attribute mandatory at the OPAC Test plan: - Set 1

<    1   2   3   >