[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #38 from Andrew Isherwood --- Created attachment 116986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116986=edit Bug 27378: Fix typo on cookie deletion expiry This commit fixes a typo in the expiry

[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #116423|0 |1 is obsolete|

[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #116422|0 |1 is obsolete|

[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #116421|0 |1 is obsolete|

[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #116420|0 |1 is obsolete|

[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #116419|0 |1 is obsolete|

[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #116418|0 |1 is obsolete|

[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #116417|0 |1 is obsolete|

[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Andrew Isherwood changed: What|Removed |Added Attachment #116416|0 |1 is obsolete|

[Koha-bugs] [Bug 27719] Receiving orders hangs on processing when missing a replacement price

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27719] Receiving orders hangs on processing when missing a replacement price

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 27694] News tool editor (codemirror) automatically converts HTML entities

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27694 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 27694] News tool editor (codemirror) automatically converts HTML entities

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27694 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #22 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 --- Comment #26 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #21 from Jonathan Druart --- Created attachment 116977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116977=edit Bug 27131: Improve POD for the new method -- You are receiving this mail because:

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #52 from Martin Renvoize --- Updated the branch attached to the merge request here: https://gitlab.com/mrenvoize/Koha/-/merge_requests/1 -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #51 from Martin Renvoize --- (In reply to Jonathan Druart from comment #44) > Is this store call needed? > > +$self->stage_id($new_stage->stage_id)->store;# Revert > stage change > > There are also

[Koha-bugs] [Bug 26937] Add an optional delay to the CheckPrevCheckout system preference

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion -- You

[Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion ---

[Koha-bugs] [Bug 27719] Receiving orders hangs on processing when missing a replacement price

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27719 Jonathan Druart changed: What|Removed |Added Severity|normal |major

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #50 from Martin Renvoize --- (In reply to Jonathan Druart from comment #45) > Shouldn't we start with a good script/template name? > transferstosend.pl => transfers_to_send.pl More than happy for that change.. I was

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #49 from Martin Renvoize --- (In reply to Jonathan Druart from comment #46) > 3. Shouldn't Koha::Exceptions::Item::Transfer::Found be actually > Koha::Exceptions::Item::Transfer::AlreadyInTransfer, to be more explicit? >

[Koha-bugs] [Bug 27626] Patron self-registration breaks if categorycode and password are hidden

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626 --- Comment #12 from Katrin Fischer --- (In reply to Jonathan Druart from comment #11) > (In reply to Katrin Fischer from comment #9) > > I've set all the email prefs to kat...@something.de and it doesn't change > > the error

[Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #25

[Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Marcel de Rooy changed: What|Removed |Added Attachment #116813|0 |1 is obsolete|

[Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Marcel de Rooy changed: What|Removed |Added Attachment #116779|0 |1 is obsolete|

[Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when adding to basket via file

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch

[Koha-bugs] [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608 --- Comment #11 from Jonathan Druart --- Created attachment 116974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116974=edit Bug 27608: [20.05] Corrects 'accepted by' inconsistency in suggestion.tt When looking

[Koha-bugs] [Bug 27626] Patron self-registration breaks if categorycode and password are hidden

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626 --- Comment #11 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > I've set all the email prefs to kat...@something.de and it doesn't change > the error message: > > Invalid 'from' parameter: root@localhost at

[Koha-bugs] [Bug 27626] Patron self-registration breaks if categorycode and password are hidden

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626 --- Comment #10 from Jonathan Druart --- Katrin, here is what I did: % git checkout -b bug_27626 origin/master % git bz apply 27626 % reset_all 1. PatronSelfRegistrationVerifyByEmail => require 2.

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #48 from Martin Renvoize --- (In reply to Jonathan Druart from comment #46) > 2. > -my ($datesent,$frombranch,$tobranch) = GetTransfers( $item->itemnumber > ); > +my $transfer = $item->get_transfer; > > This

[Koha-bugs] [Bug 22569] Add a 'Transfers to send' report

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #47 from Martin Renvoize --- (In reply to Jonathan Druart from comment #46) > Adding here some notes about the dependent tree (I've squashed the whole > tree for pre-review): > > 1. > -

[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > Hi Marcel, thanks for QAing. > > Which code from the controller do you have in mind? I had a look carefully > and I cannot think of some

[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules

2021-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #19 from Jonathan Druart --- Hi Marcel, thanks for QAing. Which code from the controller do you have in mind? I had a look carefully and I cannot think of some business code we could move to a module. There are 1. lot

<    1   2