[Koha-bugs] [Bug 5229] OPACItemsResultsDisplay preference does not work with XSLT results

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5229 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 28561] Order_by triggers a DBIx warning Unable to properly collapse has_many results

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28561 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment

[Koha-bugs] [Bug 28374] Convert pos/printreceipt.pl to use GetPreparedLetter

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28374 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 28389] One should be able to see details for refunds on the register summary page

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org --

[Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org --

[Koha-bugs] [Bug 28240] Some classes in register.tt are translatable

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28240 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #41 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #40) > (In reply to Martin Renvoize from comment #39) > > In this case, I do wonder about removing them.. remember, methods can be > > used by notices

[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #40 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #39) > In this case, I do wonder about removing them.. remember, methods can be > used by notices too.. so the 'from_library' may well have been

[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #39 from Martin Renvoize --- Ack.. that's a pet hate of mine.. that we don't pass through existing relationships so you have to create them each time if you want to use them (and add tests too). In this case, I do

[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #38 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #36) > (In reply to Jonathan Druart from comment #35) > > # Failed test 'No tests run for subtest "from_library relation tests"' > > # at

[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #37 from Joonas Kylmälä --- Created attachment 121985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121985=edit Bug 28520: Remove tests for removed from_library function The function was unused and

[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 --- Comment #36 from Jonathan Druart --- (In reply to Jonathan Druart from comment #35) > # Failed test 'No tests run for subtest "from_library relation tests"' > # at /kohadevbox/koha/t/db_dependent/Koha/Item/Transfer.t line

[Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is never called but should be

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 --- Comment #67 from Jonathan Druart --- (In reply to Jonathan Druart from comment #66) > This patchset conflicts with bug 28520, I cannot apply both of them. > Can you add a dependency and fix the conflict please? > (adding the

[Koha-bugs] [Bug 28520] Cancelling a hold that is in transit hides item's transit status

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28520 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment

[Koha-bugs] [Bug 28503] When ReservesControlBranch = "patron's home library" and Hold policy = "From home library" all holds are allowed

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28503 --- Comment #8 from Jonathan Druart --- Tomas, this is missing your signed-off-by patches! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #62 from Jonathan Druart --- Created attachment 121984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121984=edit Bug 25078: Re-introduce NewVersion This is ugly, we re-add the code we removed in the

[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What|Removed |Added Attachment #121911|0 |1 is obsolete|

[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 Jonathan Druart changed: What|Removed |Added Attachment #121909|0 |1 is obsolete|

[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #53 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #51) > Failing tests, please fix ASAP Attached a patch to correct the test scenarios. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #52 from Joonas Kylmälä --- Created attachment 121981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121981=edit Bug 27064: Correct transferbook.t tests to reflect new behaviour of transferbook() The

[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #59 from Julian Maurice --- (In reply to Jonathan Druart from comment #57) > (In reply to Julian Maurice from comment #56) > > https://gitlab.com/jajm/Koha/-/commit/ > > 864372e553d312d1a533a75f389d9a7aa143c62e > > Yes,

[Koha-bugs] [Bug 28349] Date sorting incorrect reports in en-GB

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28349 Lucy Vaux-Harvey changed: What|Removed |Added CC|

[Koha-bugs] [Bug 28519] Add a 2nd directory for Perl modules

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 --- Comment #10 from Julian Maurice --- Comment on attachment 121836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121836 Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory Review of attachment

[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #58 from Jonathan Druart --- Note to myself, the first patch should: -my $report = update( $files, { force => 1 } ); +my $report = update( $files, { force => $force } ); -- You are receiving this mail because:

[Koha-bugs] [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #57 from Jonathan Druart --- (In reply to Julian Maurice from comment #56) > (In reply to Julian Maurice from comment #54) > > I'll submit a patch later to show what I have in mind (maybe on a remote git > > repository

[Koha-bugs] [Bug 22702] Circulation note on patron page should allow for HTML tags

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Henry Bolshaw changed: What|Removed |Added Status|NEW |ASSIGNED -- You are

[Koha-bugs] [Bug 28141] Accessibility: OPAC Advanced Search fields aren't labelled

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28141 Henry Bolshaw changed: What|Removed |Added Status|NEW |ASSIGNED -- You are

[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Henry Bolshaw changed: What|Removed |Added Status|NEW |ASSIGNED -- You are

[Koha-bugs] [Bug 28188] Accessibility: OPAC - the contrast ratio for text is insufficient [OMNIBUS]

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28188 Henry Bolshaw changed: What|Removed |Added Assignee|oleon...@myacpl.org |bolsh...@parliament.uk --

[Koha-bugs] [Bug 28141] Accessibility: OPAC Advanced Search fields aren't labelled

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28141 Henry Bolshaw changed: What|Removed |Added Assignee|oleon...@myacpl.org |bolsh...@parliament.uk --

[Koha-bugs] [Bug 28142] Accessibility: OPAC Cart/basket checkboxes are not labelled

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28142 Henry Bolshaw changed: What|Removed |Added Assignee|oleon...@myacpl.org |bolsh...@parliament.uk --

[Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed

[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #34 from Peter Vashchuk --- Created attachment 121980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121980=edit Bug 28316: add tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #33 from Peter Vashchuk --- Created attachment 121979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121979=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the

[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #32 from Peter Vashchuk --- Created attachment 121978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121978=edit Bug 28316: avoid messing up regexes in the search queries This patch ensures that the

[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #31 from Peter Vashchuk --- Created attachment 121977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121977=edit Bug 28316: escape exclamation signs in the query Currently having exclamation sign at

[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 --- Comment #30 from Peter Vashchuk --- Created attachment 121976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121976=edit Bug 28316: escape brackets in the search query This patch screens square and curly

[Koha-bugs] [Bug 28316] Fix ES crashes related to various punctuation characters

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28316 Peter Vashchuk changed: What|Removed |Added Attachment #121837|0 |1 is obsolete|

[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #28 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121974=edit Bug 28243: tags folder Added captions to tables for accessibility

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 --- Comment #92 from Victor Grousset/tuxayo --- Here are alternatives 1 and 2. With only 3 operations detailed. == 1 ===

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off ---

[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #27 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121973=edit Bug 28243: suggestion folder Added captions to tables for

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121769|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121768|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121767|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121766|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121765|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121764|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121763|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121762|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121761|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121760|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121759|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121758|0 |1 is

[Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #121757|0 |1 is

[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #26 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121959=edit Bug 28243: serials folder Added captions to tables for accessibility

[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #25 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121958=edit Bug 28243: rotating_collections folder Added captions to tables for

[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #24 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121957=edit Bug 28243: reviews folder Added captions to tables for accessibility

[Koha-bugs] [Bug 28243] Accessibility: Staff Client - add captions to tables

2021-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28243 --- Comment #23 from wainuiwitikap...@catalyst.net.nz --- Created attachment 121956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121956=edit Bug 28243: reserve folder Added captions to tables for accessibility

<    1   2