https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742
Nick Clemens changed:
What|Removed |Added
Blocks||30892
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30892
Nick Clemens changed:
What|Removed |Added
Depends on||30742
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864
Nick Clemens changed:
What|Removed |Added
Attachment #13|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614
--- Comment #6 from Owen Leonard ---
(In reply to David Nind from comment #4)
> Everything is working as expected, except for the second last step: no
> messages, such as "There are no ungrouped baskets."
I left out a step in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614
Owen Leonard changed:
What|Removed |Added
Attachment #135394|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614
Owen Leonard changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789
Nick Clemens changed:
What|Removed |Added
Summary|Improve performance of |Improve performance of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152
Fridolin Somers changed:
What|Removed |Added
Status|Signed Off |Failed QA
QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
--- Comment #10 from Magnus Enger ---
If I change this line in the database update:
$dbh->do( q|ALTER TABLE borrower_attribute_types DROP CONSTRAINT
category_code_fk| );
to this:
$dbh->do( q|ALTER TABLE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
--- Comment #9 from Fridolin Somers ---
Both exists :
https://mariadb.com/kb/en/alter-table/#drop-constraint
https://mariadb.com/kb/en/alter-table/#drop-foreign-key
But in all other existing DBRevs it is "DROP FOREIGN KEY".
For
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963
Peter Vashchuk changed:
What|Removed |Added
Attachment #135582|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813
--- Comment #28 from Marcel de Rooy ---
Coming back here very soon. Please keep status.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813
--- Comment #27 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #26)
> my $mss = GetMarcSubfieldStructure( '', { unsafe => 1 } ); # Do not
> change framework
> @{$kohafields} = keys %{ $mss } unless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
--- Comment #8 from Fridolin Somers ---
(In reply to Magnus Enger from comment #1)
> Looks like the problem is on line 11 of
> /usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/211105004.pl:
>
> 10 if(
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813
--- Comment #26 from Marcel de Rooy ---
my $mss = GetMarcSubfieldStructure( '', { unsafe => 1 } ); # Do not change
framework
@{$kohafields} = keys %{ $mss } unless $kohafields;
foreach my $kohafield ( @{$kohafields} ) {
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
--- Comment #7 from Magnus Enger ---
The relevant code in the database update is:
if( foreign_key_exists('borrower_attribute_types', 'category_code_fk') ) {
$dbh->do( q|ALTER TABLE borrower_attribute_types DROP CONSTRAINT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813
Marcel de Rooy changed:
What|Removed |Added
Status|Passed QA |BLOCKED
--- Comment #25
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
--- Comment #6 from Fridolin Somers ---
This is from Bug 7154 that did not add the constraint in kohastructure.sql
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
--- Comment #8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
--- Comment #7 from Jonathan Druart ---
Do you think you will have time to get back to this, Thomas?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449
Jonathan Druart changed:
What|Removed |Added
Blocks||30899
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
Jonathan Druart changed:
What|Removed |Added
Depends on||30449
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
--- Comment #4 from Jonathan Druart ---
It's because you have a FK with the same name "category_code_fk"
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
--- Comment #3 from Magnus Enger ---
This is from the site that succeeded, before the upgrade (taken from last
night's backup):
CREATE TABLE `borrower_attribute_types` (
`code` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #68 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #67)
> (In reply to Marcel de Rooy from comment #60)
> > (In reply to Jonathan Druart from comment #59)
> > > (In reply to Marcel de Rooy from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
--- Comment #2 from Magnus Enger ---
This is from a database where the update succeeded:
MariaDB [koha_ok]> show create table borrower_attribute_types\G
*** 1. row ***
Table:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #67 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #60)
> (In reply to Jonathan Druart from comment #59)
> > (In reply to Marcel de Rooy from comment #48)
> > > +my $invalid_marc_record = $@ ||
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #66 from Jonathan Druart ---
Created attachment 135673
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135673=edit
Bug 29697: Deal with the degraded view in detail.pl
In detail.pl we must provide a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #65 from Jonathan Druart ---
Created attachment 135672
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135672=edit
Bug 29697: Fix tests
Signed-off-by: Marcel de Rooy
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #64 from Jonathan Druart ---
Created attachment 135671
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135671=edit
Bug 29697: Use flag embed_items
Includes:
Bug 29697: (follow-up) Use flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #63 from Jonathan Druart ---
Created attachment 135670
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135670=edit
Bug 29697: Remove GetHiddenItemnumbers
Signed-off-by: Marcel de Rooy
JD amended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #62 from Jonathan Druart ---
Created attachment 135669
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135669=edit
Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #135662|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
--- Comment #1 from Magnus Enger ---
Looks like the problem is on line 11 of
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/211105004.pl:
10 if( foreign_key_exists('borrower_attribute_types',
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #60 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #59)
> (In reply to Marcel de Rooy from comment #48)
> > +my $invalid_marc_record = $@ || !$marc_record;
> > +if ($invalid_marc_record) {
> > +
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
Bug ID: 30899
Summary: Upgrade sometimes fails at "Upgrade to 21.11.05.004"
Change sponsored?: ---
Product: Koha
Version: 21.11
Hardware: All
OS: All
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896
Marcel de Rooy changed:
What|Removed |Added
Summary|DB Error "Data too long for |Running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896
--- Comment #4 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #1)
> This might be some schema problem. I found this when running Biblio.t
>
> # Failed test 'expected warnings when adding too long LCCN'
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963
Slava Shishkin changed:
What|Removed |Added
Assignee|slavashish...@gmail.com |stalkern...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Attachment #135580|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896
--- Comment #3 from David Nind ---
(In reply to David Cook from comment #2)
> (In reply to David Nind from comment #0)
> > the sample data in koha-testing-data
>
> Should that be koha-testing-docker?
It should!
>
> Do you know
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #59 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #47)
> diff --git a/catalogue/detail.pl b/catalogue/detail.pl
> index 502963f8d6..120fc28a88 100755
> --- a/catalogue/detail.pl
> +++
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #58 from Marcel de Rooy ---
opac/opac-detail.pl:
if ( scalar @all_items >= 1 ) {
@items_to_show = Koha::Items->search( { itemnumbers => [ map {
$_->{itemnumber} } @all_items ] } )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #57 from Marcel de Rooy ---
Just a bit of post testing ;)
Crash on opening cart
Not a HASH reference at /usr/share/koha/opac/opac-basket.pl line 99
my @items= $biblio->items->filter_by_visible_in_opac({ patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #56 from Marcel de Rooy ---
Good work. See earlier comments. Most minor details, apart from the performance
remark where we would call GetMarcBiblio in a loop without fetching the biblio
object before.
Hard call for the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Marcel de Rooy changed:
What|Removed |Added
Attachment #135579|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Marcel de Rooy changed:
What|Removed |Added
Attachment #135578|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Marcel de Rooy changed:
What|Removed |Added
Attachment #135577|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Marcel de Rooy changed:
What|Removed |Added
Attachment #135576|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Marcel de Rooy changed:
What|Removed |Added
Attachment #135575|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Marcel de Rooy changed:
What|Removed |Added
Attachment #135574|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #49 from Marcel de Rooy ---
+++ b/misc/maintenance/process_record_through_filter.pl
+my $biblio = Koha::Biblios->find($ARGV[0]);
+unless ( $biblio ) {
+print "Biblio not found\n,";
+exit;
Looks a bit odd with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #48 from Marcel de Rooy ---
+my $invalid_marc_record = $@ || !$marc_record;
+if ($invalid_marc_record) {
+$template->param( decoding_error => $@ );
Theoretically $@ might be empty but there is not $marc_record.
So
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #47 from Marcel de Rooy ---
diff --git a/catalogue/detail.pl b/catalogue/detail.pl
index 502963f8d6..120fc28a88 100755
--- a/catalogue/detail.pl
+++ b/catalogue/detail.pl
@@ -84,6 +84,7 @@ if (
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342
Bug 15342 depends on bug 11213, which changed state.
Bug 11213 Summary: GetItemsInfo() called twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213
Jonathan Druart changed:
What|Removed |Added
Resolution|--- |FIXED
See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #46 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #44)
> See also IRC
>
> -my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber =>
> $biblionumber });
> +my $biblio =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #45 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #43)
> Subject: [PATCH 7/7] Bug 29697: (follow-up) Use flag embed_items
>
> -? Koha::Biblios->find($id)->metadata->record({ embed_items => 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #44 from Marcel de Rooy ---
See also IRC
-my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber => $biblionumber
});
+my $biblio = Koha::Biblios->find($biblionumber);
+my $marcrecord =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Attachment #128377|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Julian Maurice changed:
What|Removed |Added
Attachment #128376|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #43 from Marcel de Rooy ---
Subject: [PATCH 7/7] Bug 29697: (follow-up) Use flag embed_items
-? Koha::Biblios->find($id)->metadata->record({ embed_items => 1 })
+?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Patch doesn't apply
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #33 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #29)
> I haven't tested everything, and tests need test plans, but basically 80% of
> the work is done.
If I can save 80% of my records, we're happy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #42 from Marcel de Rooy ---
Once saw this:
t/db_dependent/Biblio.t .. 1/14
# Failed test 'expected warnings when adding too long LCCN'
# at t/db_dependent/Biblio.t line 61.
# didn't find a warning
#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30739
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672
--- Comment #19 from David Cook ---
(In reply to Julian Maurice from comment #18)
> Is it really less efficient ? We have to de-reference the list at some point
> to iterate over it anyway. I will be happy to change that if you can
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896
Marcel de Rooy changed:
What|Removed |Added
Component|System Administration |Database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30898
Bug ID: 30898
Summary: Elasticsearch/Indexer.t fails on 'No nodes are
available'
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30898
Marcel de Rooy changed:
What|Removed |Added
CC||tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #32 from Jonathan Druart ---
Ha, and question, see catalogue/detail.pl
We are using an order_by that was initially used in GetItemsInfo. Should it be
the default order by for all item searches?
I am also stuck trying to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
Jonathan Druart changed:
What|Removed |Added
Attachment #135641|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #31 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #29)
> It's crazy the number of bugs I found and fixed.
And some related to items visibility at the OPAC.
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #30 from Jonathan Druart ---
30 files changed, 495 insertions(+), 893 deletions(-)
Please understand that we need the patches pushed ASAP once they are ready for
testing. I will NOT rebase them several months.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
Jonathan Druart changed:
What|Removed |Added
Status|NEW |In Discussion
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886
Jonathan Druart changed:
What|Removed |Added
Blocks||27272
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885
Jonathan Druart changed:
What|Removed |Added
Blocks||27272
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
Jonathan Druart changed:
What|Removed |Added
Blocks||27272
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
Jonathan Druart changed:
What|Removed |Added
Depends on||29697, 30885, 30886
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #29 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #8)
> I'd say go for it. Next step is to just pass the items to the templates I
> guess?
Yes "just"... :D
Here are the patches. What next now? Do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
Jonathan Druart changed:
What|Removed |Added
Attachment #135640|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #27 from Jonathan Druart ---
Created attachment 135658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135658=edit
Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #26 from Jonathan Druart ---
Created attachment 135657
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135657=edit
Bug 27272: virtualshelves/sendshelf.pl shelves.pl
--
You are receiving this mail
101 - 200 of 224 matches
Mail list logo
