https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
--- Comment #45 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #44)
> Great it applies now.
> New module added.
> What I am missing here completely, is tests !
How could this be tested easily?
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983
--- Comment #21 from Jérémy Breuillard ---
(In reply to Jonathan Druart from comment #20)
> Jérémy, can you confirm that you agree with the 2 follow-ups please?
It is better, I agree with that
--
You are receiving this mail becaus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
--- Comment #44 from Marcel de Rooy ---
Great it applies now.
New module added.
What I am missing here completely, is tests !
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #51 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #48)
> Well I give up. Code looks good, nice improvement. But it does not work for
> me on holds. That is not providing confidence.
> Have some more pe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #50 from Jonathan Druart ---
Created attachment 138659
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138659&action=edit
Bug 30718: Fix dates display at the OPAC
Found dateofbirth so far, do we have ot
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718
--- Comment #46 from Mason James ---
> my theory is that a newer olsen database is needed for u18 - its been
> upgraded from 2018d to 2022a
> (ps: i cant explain why u20 works with only a 2019c database??)
>
aah, the 2019b databas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #49 from Jonathan Druart ---
Created attachment 138658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138658&action=edit
Bug 30718: Apply flatpickr changes to OPAC
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #48 from Marcel de Rooy ---
Well I give up. Code looks good, nice improvement. But it does not work for me
on holds. That is not providing confidence.
Have some more people test it.
Try adding a hold with start and end da
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #47 from Marcel de Rooy ---
| 79 | 51 | 2022-08-08 |1 | CPL|
NULL | NULL | NULL | NULL | NULL
| |1 | NULL |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #46 from Marcel de Rooy ---
Hey. When I switch to yy-mm-dd only THEN the hold dates are saved !
--
You are receiving this mail because:
You are watching all bug changes.
___
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #45 from Marcel de Rooy ---
No with mm/dd/yy I still have a new hold without two dates (hold start and end
date entered).
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #44 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #43)
> (In reply to Marcel de Rooy from comment #40)
> > Hmm. I am just globally testing a bit. But this does not provide confidence:
> >
> > Adding a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #43 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #40)
> Hmm. I am just globally testing a bit. But this does not provide confidence:
>
> Adding a expiration date for a new hold.
> The date does not g
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #42 from Marcel de Rooy ---
Allowing future hold dates:
| 77 | 51 | -00-00 |1 | CPL|
NULL | NULL | NULL | NULL | NULL
|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #41 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #38)
> Minor code observations:
>
> Koha/Hold.pm
> +$date &&= dt_from_string($date)->truncate( to => 'day' )->datetime;
> Obsure code
Obscure? It
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #40 from Marcel de Rooy ---
Hmm. I am just globally testing a bit. But this does not provide confidence:
Adding a expiration date for a new hold.
The date does not get saved.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #39 from Marcel de Rooy ---
Editing items: Should $w Price effective from be controlled by flatpickr ?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #273 from Jonathan Druart ---
The best hope is to find people to focus on it at the same time. Having someone
to rebase it is not enough, I have rebased it and adjusted it dozens of times
already.
--
You are receiving t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Passed QA
--- Comment #57
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #38 from Marcel de Rooy ---
Minor code observations:
Koha/Hold.pm
+$date &&= dt_from_string($date)->truncate( to => 'day' )->datetime;
Obsure code
clubs/clubs-add-modify.pl
+my $date_start = $cgi->param('date_start'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
--- Comment #43 from Jonathan Druart ---
Created attachment 138657
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138657&action=edit
Bug 27421: Commit and revert
--
You are receiving this mail because:
You are wa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
Jonathan Druart changed:
What|Removed |Added
Attachment #136338|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
Jonathan Druart changed:
What|Removed |Added
Status|BLOCKED |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #37 from Marcel de Rooy ---
testing 9 commit(s) (applied to e544ff4 '45 Bug 29632: (QA follow-up) Fix
COMM')
Processing files before patches
|>| 118 / 118 (100.00%)
Processing files after patches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #36 from Marcel de Rooy ---
Having a look here right now
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.k
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847
Jonathan Druart changed:
What|Removed |Added
Attachment #137675|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847
Jonathan Druart changed:
What|Removed |Added
Attachment #137674|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
Emmanuel Bétemps changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726
--- Comment #16 from sandbo...@biblibre.com ---
Created attachment 138653
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138653&action=edit
Bug 28726: Add sort1 and sort2 to patron card creator - patron search.
Al
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30926
--- Comment #9 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Marcel de Rooy from comment #7)
> > Tomas: Is this something that you would be willing to push quickly?
> > In that case I might have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30926
--- Comment #8 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #7)
> Tomas: Is this something that you would be willing to push quickly?
> In that case I might have a look soon,,
yes...
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
--- Comment #41 from Marcel de Rooy ---
The diff in the original 35K patch gives me on tools/manage-marc-import.pl:
1 file changed, 47 insertions(+), 22 deletions(-)
But there are definitely 210 changes in that patch file. (found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #35 from Jonathan Druart ---
Created attachment 138652
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138652&action=edit
Bug 30718: Prevent 'reset' icon to appear twice
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #34 from Jonathan Druart ---
Created attachment 138651
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138651&action=edit
Bug 30718: Fix time display
Especifically when timeformat=12h
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #33 from Jonathan Druart ---
Created attachment 138650
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138650&action=edit
Bug 30718: Fix scheduler
--
You are receiving this mail because:
You are watchi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #32 from Jonathan Druart ---
Created attachment 138649
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138649&action=edit
Bug 30718: Fix holidays
Template process failed: undef error - The given date (0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #31 from Jonathan Druart ---
Created attachment 138648
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138648&action=edit
Bug 30718: Add missing USE KohaDates
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #30 from Jonathan Druart ---
Created attachment 138647
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138647&action=edit
Bug 30718: Fix serials/showpredictionpattern.pl
Can't locate object method "ymd"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #29 from Jonathan Druart ---
Created attachment 138646
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138646&action=edit
Bug 30718: Fix today's date on overdue
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
--- Comment #28 from Jonathan Druart ---
Created attachment 138645
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138645&action=edit
Bug 30718: Pass DT to filter_by_lates
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
Jonathan Druart changed:
What|Removed |Added
Attachment #137707|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
Marcel de Rooy changed:
What|Removed |Added
Status|Patch doesn't apply |BLOCKED
--- Comment #40 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
Marcel de Rooy changed:
What|Removed |Added
Attachment #136339|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
Marcel de Rooy changed:
What|Removed |Added
Attachment #136339|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
--- Comment #38 from Marcel de Rooy ---
Created attachment 138642
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138642&action=edit
Bug 27421: Use Background job for staging MARC records for import
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
--- Comment #138 from Jonathan Druart ---
There is a test plan in comment 35.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421
--- Comment #37 from Marcel de Rooy ---
I fixed the first conflict
Looking at this one:
Applying: Bug 27421: Use Background job for staging MARC records for import
Applying: Bug 27421: Commit and revert
error: sha1 information is lac
201 - 251 of 251 matches
Mail list logo