[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26499|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26695|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26500|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26713|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26719|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26718|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26720|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26721|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #44 from Srdjan Jankovic srd...@catalyst.net.nz --- (In reply to Bernardo Gonzalez Kriegel from comment #35) (In reply to M. Tompsett from comment #34) I'd start at comment 25. :) * GetItemsInfo() is getting called in

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #33 from Srdjan Jankovic srd...@catalyst.net.nz --- (In reply to Bernardo Gonzalez Kriegel from comment #32) First two are signed. Test plan for the remaining? I'm sorry, I totally lost account for this fix. Which one

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #34 from M. Tompsett mtomp...@hotmail.com --- I'd start at comment 25. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #28 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 26720 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26720action=edit bug_11213: Added XSLTParse4Display() to Items test -- You are

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #29 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 26721 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26721action=edit bug_11213: Check for $item-{itype} presence to avoid warning --

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #30 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 26718 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26718 bug_11213: Use branch codes from the database rather than hardcoded CPL and

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #31 from Srdjan Jankovic srd...@catalyst.net.nz --- (In reply to M. Tompsett from comment #30) Comment on attachment 26718 [details] [review] bug_11213: Use branch codes from the database rather than hardcoded CPL and

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26696|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #25 from M. Tompsett mtomp...@hotmail.com --- You modified GetItemsInfo. t/db_dependent/Items.t needs to have GetItemsInfo calls. You modified searchResults. t/db_dependent/Search.t needs to have calls to searchResults

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #26 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 26718 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26718action=edit bug_11213: Use branch codes from the database rather than

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #27 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 26719 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26719action=edit bug_11213: GetItemsInfo() test -- You are receiving this mail

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #22 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 26695 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26695action=edit bug_11213: Include XSLT processing for searchResults() test *

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #23 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 26696 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26696action=edit bug_11213: C4::VirtualShelves::Page::shelf_contents() *

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #26430|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #26431|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Failed QA

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #17 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 26431 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26431action=edit bug_11213: whitespace correction -- You are receiving this

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #26394|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #18 from M. Tompsett mtomp...@hotmail.com --- In the midst of testing... Virtual shelves: LISTS! Testing to continue. I thought something was broken, but then realized that bug 10589 and the related bugs haven't hit

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #10 from Srdjan Jankovic srd...@catalyst.net.nz --- (In reply to M. Tompsett from comment #9) Why did you remove the hidden stuff? Because it makes no sense to pass on all items and then filter them in the called

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #11 from M. Tompsett mtomp...@hotmail.com --- Because I'm worried you are breaking the hiding functionality with this patch. I don't see any changes which reflect moving the exclusion from one place to another. -- You

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |In

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #12 from Srdjan Jankovic srd...@catalyst.net.nz --- (In reply to M. Tompsett from comment #11) Because I'm worried you are breaking the hiding functionality with this patch. I don't see any changes which reflect moving

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #13 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 22800 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22800 bug_11213: Changed XSLTParse4Display() interface Review of attachment 22800:

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #22800|0 |1

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #15 from M. Tompsett mtomp...@hotmail.com --- Sorry, but could you put the whitespace fixes in a separate patch? It makes reading the actual code changes easier. :) -- You are receiving this mail because: You are

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #7 from mathieu saby mathieu.s...@univ-rennes2.fr --- (In reply to Srdjan Jankovic from comment #6) I totally agree, and I may go there in some other bug report. Good idea! And I'm sure I've seen dozen of places in C4

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #8 from mathieu saby mathieu.s...@univ-rennes2.fr --- (In reply to Srdjan Jankovic from comment #2) This may yield significant improvements in performance. Hairy spots: * I have removed GetItemsLocationInfo() in

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #5 from mathieu saby mathieu.s...@univ-rennes2.fr --- Some remarks about GetItemsInfo () : There are 5 SELECT. I suppose it would be better for performance to have a unique SELECT. And the last SELECT gets some

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #6 from Srdjan Jankovic srd...@catalyst.net.nz --- I totally agree, and I may go there in some other bug report. I'll just say that at this stage 5 calls are better than 10. -- You are receiving this mail because: You

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #4 from Srdjan Jankovic srd...@catalyst.net.nz --- I believe that's exactly where it shows most benefits. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #1 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22800 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22800action=edit bug_11213: Changed XSLTParse4Display() interface The list of

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Priority|P5 - low|P3

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Assignee|oleon...@myacpl.org

<    1   2