http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #28480|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #41 from David Cook dc...@prosentient.com.au ---
Comment on attachment 28480
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28480
Bug 11592 - MARC Visibility settings not respected
Review of attachment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #42 from M. Tompsett mtomp...@hotmail.com ---
(In reply to David Cook from comment #41)
::: C4/Biblio.pm
+my $rv = $sth-execute($frameworkcode);
Why is there a my $rv here? It shouldn't be needed.
It was
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #43 from M. Tompsett mtomp...@hotmail.com ---
(In reply to David Cook from comment #41)
@@ +1334,5 @@
+my $show = $display-{$interface}-{
$data-{$fullfield}-{$tag}-{'hidden'} };
+if (!$show
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Fridolin SOMERS fridolyn.som...@biblibre.com changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #28003|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #28477|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #28478|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #28002|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Status|ASSIGNED|Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #34 from M. Tompsett mtomp...@hotmail.com ---
And this is where converting the parameters of GetMarcBiblio to a hash
reference would be useful, because optional parameters are a pain otherwise.
*sigh*
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #33 from M. Tompsett mtomp...@hotmail.com ---
(In reply to David Cook from comment #26)
A few additional thoughts...
1)
A follow-up should probably be added for a few other OPAC scripts like
opac-basket.pl,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24953|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Keywords|rel_3_16_candidate |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #29 from M. Tompsett mtomp...@hotmail.com ---
I think I have something working, but I need to get my unimarc VM updated and
do a test on it first.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Galen Charlton gmcha...@gmail.com changed:
What|Removed |Added
Keywords|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #27 from M. Tompsett mtomp...@hotmail.com ---
ARG! This no longer applies. And because the t/db_dependent/Biblio.t file has
gotten more complicated that a straight list of tests, I'm not sure how to
rebase.
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #28 from M. Tompsett mtomp...@hotmail.com ---
Rebase need caused by bug 11912.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #26 from David Cook dc...@prosentient.com.au ---
A few additional thoughts...
1)
A follow-up should probably be added for a few other OPAC scripts like
opac-basket.pl, opac-sendbasket.pl, opac-sendshelf.pl, etc., since
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #25 from David Cook dc...@prosentient.com.au ---
Looking forward to this one going in. It would be a great help...
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
David Cook dc...@prosentient.com.au changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #24875|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #24876|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Robin Sheat ro...@catalyst.net.nz changed:
What|Removed |Added
Status|Needs Signoff |Signed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Robin Sheat ro...@catalyst.net.nz changed:
What|Removed |Added
Attachment #24663|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #21 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 24876
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24876action=edit
Bug 11592 - opac scripts do not respect marc tag visibility
Added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #22 from Robin Sheat ro...@catalyst.net.nz ---
(sorry, attached them the wrong way around due to expecting git bz to work like
most git commands.)
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24629|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Patch complexity|Small patch |Medium
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Status|NEW |Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24654|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #8 from Robin Sheat ro...@catalyst.net.nz ---
Comment on attachment 24655
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24655
Bug 11592 - opac scripts do not respect marc tag visibility
Review of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #10 from Robin Sheat ro...@catalyst.net.nz ---
(In reply to M. Tompsett from comment #9)
Hmm... GetMarcStructure is cached. Look in C4/Biblio.pm for sub
GetMarcStructure. You will see the $marc_structure_cache line just
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24655|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24657|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Status|ASSIGNED|Needs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24658|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #14 from M. Tompsett mtomp...@hotmail.com ---
opac-search.pl is out of scope for now.
opac-ISDBdetail.pl could be cleaned up more, but the focus of this was more
consistency between opac-MARCdetail and opac-detail pages.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #16 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 24661
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24661action=edit
Bug 11592 - Updated License Text and use Modern::Perl
Why not clean
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24659|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24661|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24660|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24662|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24601|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24611|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
Robin Sheat ro...@catalyst.net.nz changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Summary|opac-detail.pl and |opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #24600|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592
--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Still to do: Add tests for new functions to C4/Biblio. :)
--
You are receiving this mail because:
You are watching all bug changes.
52 matches
Mail list logo