[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #24 from Jonathan Druart --- anonymise_issue_history changes need to be adjusted, the method has been removed. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Patch doesn't apply ---

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Lucas Gass changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Lucas Gass changed: What|Removed |Added Keywords||rel_22_05_candidate -- You

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate,|rel_22_05_candidate

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_05_candidate |rel_21_11_candidate --

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #22 from Nick Clemens --- Also QA failure: sort (...) interpreted as function sort (...) interpreted as function -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #21 from Martin Renvoize --- Thanks Nick, I've dug out my branch and it looks like I started added more tests for chaining and combination of these filters.. I'll look at working through completing those tests and take

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Depends on|20271 | Referenced Bugs:

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #19 from Martin Renvoize --- Created attachment 115041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115041=edit Bug 11983: (follow-up) Terminology fixes As discussed, this patch updates the class

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Attachment #114735|0 |1 is obsolete|

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #18 from Martin Renvoize --- Created attachment 115040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115040=edit Bug 11983: Centralised Koha::Patrons filtering methods This patch adds various

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #17 from Nick Clemens --- (In reply to Victor Grousset/tuxayo from comment #16) > Created attachment 114735 [details] [review] > Bug 11983: Centralised Koha::Patrons method OPTION 2 > > == Test plan == > prove

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Attachment #76227|0 |1 is obsolete|

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114731|0 |1 is

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Needs Signoff ---

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Attachment #114730|0 |1 is obsolete|

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Attachment #76701|0 |1 is obsolete|

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target|rel_21_05_candidate --

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Blocks|20469 | Referenced Bugs:

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Andrew Isherwood changed: What|Removed |Added CC|andrew.isherwood@ptfs-europ |

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target,

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Summary|Code to select patrons to |Code to select patrons to

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Blocks||16846 Referenced Bugs:

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Marcel de Rooy changed: What|Removed |Added Blocks||20469 Referenced Bugs:

[Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Katrin Fischer changed: What|Removed |Added Summary|code to select patrons to |Code to select patrons to

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au ---

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #10 from Martin Renvoize --- Thanks for the review, Jonathan :) I far prefer option 2 too now I've written it. I think splitting out the final combinations for script + tool interfaces into their own subclasses also

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion ---

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #8 from Martin Renvoize --- So the core proposal here is that we stop adding `->search_for_functionality_x` methods to the DB level Koha::Objects and rather add generalized filters for complex joins etc if we need to.

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #7 from Martin Renvoize --- The option 2 patch now includes the beginnings of tests (I still need to test method chaining). Would appreciate any further feedback on this option.. method names, how they're constructed,

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Attachment #76228|0 |1 is obsolete|

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #5 from Jonathan Druart --- IMO Option 1 will be hard to maintain, and is not very readable. Option 2 is more verbose but clearer. See also Koha/Virtualshelves.pm for existing examples. -- You are receiving this mail

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #4 from Martin Renvoize --- Feedback wanted on just the Koha::Patrons method options here before I write the associated tests and hook the code up to the scripts and tools. -- You are receiving this mail because: You

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #3 from Martin Renvoize --- Created attachment 76228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76228=edit Bug 11983: Centralised Koha::Patrons method OPTION 2 -- You are receiving this mail

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #2 from Martin Renvoize --- Created attachment 76227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76227=edit Bug 11983: Centralised Koha::Patrons method OPTION 1 -- You are receiving this mail

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #1 from Martin Renvoize --- I intend to work on this but won't do so until after 20271 is in as it will drastically affect the code. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Depends on||20271 Referenced Bugs:

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Assignee|gmcha...@gmail.com

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Victor Grousset/tuxayo changed: What|Removed |Added CC|

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Depends on||11352 --