[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Bug 12353 depends on bug 12917, which changed state. Bug 12917 Summary: Centralize reserves "last pickup date" calculation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12917 What|Removed

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #23 from Katrin Fischer --- I think the notices are ok, as the pick-up date is in reserves.expirationdate. But we still need to fix the problem with the calendar. -- You are receiving this

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Katrin Fischer changed: What|Removed |Added Severity|enhancement

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Marianne Rolfsen changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 David Kuhn changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Lisette changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #21 from Katrin Fischer --- Wondering if we should change this to a bug report instead of enh. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Viccy Kemp changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Owen Leonard changed: What|Removed |Added Version|3.16|master

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Heather Braum changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Christopher Davis mr.catalo...@gmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Tom Misilo misi...@fit.edu changed: What|Removed |Added CC||misi...@fit.edu

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I was about to file a bug for the holds calculated expiration date not caring about the calendar (calculate ReservesMaxPickUpDelay in opening days vs. calendar days),

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de --- 4 days are forever in terms of Koha :) Hope you had a good time! I was not sure how it all fits together, hoping that Olli can explain. -- You are receiving this mail

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #18 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- As an important difference this feature removes code duplication regarding holds expiration from 3 different places and centralizes it to actual functions. --

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #12 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Thanks for the review Katrin! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #13 from Christopher Brannon cbran...@cdalibrary.org --- Olli-Antti, I did not get notified of your patch. I will take a look at it when you address the things already in question. Christopher -- You are receiving this

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #14 from Christopher Brannon cbran...@cdalibrary.org --- (In reply to Katrin Fischer from comment #11) Hi Olli-Antti, a few things that have me confused here: 1) Can you please explain how your patches are different

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #15 from Christopher Brannon cbran...@cdalibrary.org --- (In reply to Christopher Brannon from comment #14) (In reply to Katrin Fischer from comment #11) Hi Olli-Antti, a few things that have me confused here:

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 31584 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31584action=edit Bug 12353 - Last pickup date in the letter templates

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 31585 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31585action=edit Bug 12353 - Displaying the last pickup date in OPAC and

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #31572|0

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #9 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Make sure to test with unicode material! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #31556|0

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Summary|Everybody need to know

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Version|master

[Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|