[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What|Removed |Added Attachment #38020|0 |1 is obsolete|

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #37 from Katrin Fischer --- Trying to see if I can fix it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.k

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #36 from Chris Cormack --- Right, well you've (collective you) have a few hours to get it in a state to apply on 3.18.x (until Bernardo sends the po files and I do the release that is) -- You are receiving this mail beca

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #35 from Katrin Fischer --- It's needed - library found this in 3.18.5.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Ko

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #34 from Chris Cormack --- Doesn't apply to 3.18.x please rebase if it is needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are recei

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What|Removed |Added Attachment #37992|0 |1 is obsolete|

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What|Removed |Added Attachment #37946|0 |1 is obsolete|

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiv

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What|Removed |Added Attachment #36048|0 |1 is obsolete|

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What|Removed |Added Status|Failed QA |ASSIGNED Assigne

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #28

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #27 from Katrin Fischer --- Kyle, would you be ok squashing the patches? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Ko

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are rece

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #26 from Jonathan Druart --- So, confirmed on master. make sure you have: item1 => date_due = today, issuedate = yesterday item2 => date_due = today, issuedate = today -- You are receiving this mail because: You are wa

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #25 from Katrin Fischer --- I think I managed to create a test case: 1) Check out an item today, due date is today 23.59 2) Check out an item yesterday (change issue date in db), due date is today 23:59 ... and the ISSUE

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #24 from Katrin Fischer --- Even if we weren't able to figure it out yet, this: 2446 elsif ((substr $it->{'date_due'}, 0, 10) le $now) { 2447 $it->{'overdue'} = 1; ... is wrong, if you

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #23 from Jonathan Druart --- Kyle, I am not able to reproduce the issue, and looking at the cait's data: issuedate: '2015-04-15 16:16:14' lastreneweddate: NULL I really don't understand how this code (C4::Members::Issue

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #22 from Katrin Fischer --- Created attachment 37908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37908&action=edit screenshot of the wrong display note date on top and overdues (Überfällig) due date

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What|Removed |Added CC||me...@bywatersolutions.com

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #17 from Jonathan Druart --- Kyle (or someone else), Could you add some tests to highlight the problem? -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiv

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What|Removed |Added Attachment #31280|0 |1 is obsolete|

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What|Removed |Added Attachment #35969|0 |1 is obsolete|

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #14

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Nick Clemens changed: What|Removed |Added CC||n...@quecheelibrary.org -- Y

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Barton Chittenden changed: What|Removed |Added Attachment #31286|0 |1 is obsolete|

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Barton Chittenden changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are r

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #12 from Barton Chittenden --- Created attachment 35969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35969&action=edit Bug 12847 [Follwup] - Remove code that calculates "overdue" key as C4::Members::Get

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #11 from Katrin Fischer --- I think the other problem blocking this is that people haven't been able to see the issue, could we get a more detailed test plan? Maybe with an example date? -- You are receiving this mail be

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What|Removed |Added Version|3.14|master -- You are receiving t

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #10 from Katrin Fischer --- Is this really 3.14, or should it be master? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Ko

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #9 from Frédéric Demians --- (In reply to Barton Chittenden from comment #8) > Frédéric: did you test dd/mm/ or mm/dd/? The latter is the one we're > having trouble with. Your reply above suggests that you tested

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #8 from Barton Chittenden --- (In reply to Frédéric Demians from comment #7) > (In reply to Chris Cormack from comment #6) > > > 28/10/2014 > 2014-10-28 .. so i think you need to make sure you have it set > > to mm/dd/yy

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #7 from Frédéric Demians --- (In reply to Chris Cormack from comment #6) > 28/10/2014 > 2014-10-28 .. so i think you need to make sure you have it set > to mm/dd/ (american format) I already tested switching datefor

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz ---

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Com

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What|Removed |Added Attachment #31281|0 |1 is obsolete|

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #3 from Kyle M Hall --- Created attachment 31281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31281&action=edit Bug 12847 [Follwup] - Remove code that calculates "overdue" key as C4::Members::GetPending

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are rece

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Pa

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #2 from Kyle M Hall --- Created attachment 31280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31280&action=edit Bug 12847 - Date comparisons in C4::Members::IssueSlip are broken Test Plan: 1) Ensure yo

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 --- Comment #1 from Barton Chittenden --- All items checked out by a patron will show between tags in ISSUESLIP. To replicate: go to cgi-bin/koha/tools/letter.pl?op=add_form&module=circulation&code=ISSUESLIP Add the following s

[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Barton Chittenden changed: What|Removed |Added Summary|Date comparisons in |Date comparisons in