https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Janet McGowan changed:
What|Removed |Added
CC||janet.mcgowan@ptfs-europe.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Marcel de Rooy changed:
What|Removed |Added
CC||frede...@tamil.fr
--- Comm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #47 from Jonathan Druart
---
See bug 14529.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Jonathan Druart changed:
What|Removed |Added
Blocks||14529
Referenced Bugs:
h
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #46 from Jonathan Druart
---
(In reply to Pete Edwards from comment #45)
> This isn't working as I would expect. I just upgraded from 3.18.03 to
> 3.20.01 and can see the new permissions. I cannot set them since I have
>
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Pete Edwards changed:
What|Removed |Added
CC||k...@jsense.co.uk
--- Comment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #44 from Katrin Fischer ---
Hm, have added bug 13888 with my thoughts.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #42 from Jonathan Druart ---
Sorry yes, it's delete_public_lists (not manage).
And, there is 1 permission in the group of permissions "Lists".
It's the first permission of the "List" module, we can imagine other
permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #41 from Nicole C. Engard ---
Created attachment 37051
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37051&action=edit
permissions
I see two new permissions - and I see that one of the patches here is t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #40 from Jonathan Druart ---
(In reply to Nicole C. Engard from comment #39)
> I'm seeing two new permissions - Lists and then the permission to delete
> under that. Does the lists permission do anything? Does it control
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Nicole C. Engard changed:
What|Removed |Added
CC||neng...@gmail.com
--- Com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
David Cook changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Passed QA
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #35 from Jonathan Druart ---
Created attachment 35764
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35764&action=edit
Bug 13417: (qa follow-up) Rename the permission to delete_public_lists
Signed-off-by
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #36 from Jonathan Druart ---
Created attachment 35765
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35765&action=edit
Bug 13417: Add the permission for all languages
Signed-off-by: Kyle M Hall
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #37 from Jonathan Druart ---
Created attachment 35766
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35766&action=edit
Bug 13417: Remove warnings
Without this patch
perl -wc C4/VirtualShelves.pm
failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #34 from Jonathan Druart ---
Created attachment 35763
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35763&action=edit
Bug 13417: Limit the permission to delete
It's preferable to limit the permission to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Jonathan Druart changed:
What|Removed |Added
Attachment #35083|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Patch doesn't apply
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Marc Véron changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #31 from Jonathan Druart ---
Created attachment 35089
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35089&action=edit
Bug 13417: Remove warnings
Without this patch
perl -wc C4/VirtualShelves.pm
failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #30 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #29)
> QA Note: One koha-qa.pl failure. AFAICT is not introduced by this patch set.
Hum, actually yes, it comes from this patch set.
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #29 from Kyle M Hall ---
QA Note: One koha-qa.pl failure. AFAICT is not introduced by this patch set.
FAILC4/VirtualShelves.pm
OK critic
OK forbidden patterns
OK pod
FAIL valid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #28 from Kyle M Hall ---
Created attachment 35086
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35086&action=edit
[PASSED QA] Bug 13417: Add the permission for all languages
Signed-off-by: Kyle M Hall
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #27 from Kyle M Hall ---
Created attachment 35085
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35085&action=edit
[PASSED QA] Bug 13417: (qa follow-up) Rename the permission to
delete_public_lists
Signe
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #26 from Kyle M Hall ---
Created attachment 35084
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35084&action=edit
[PASSED QA] Bug 13417: Limit the permission to delete
It's preferable to limit the permi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Kyle M Hall changed:
What|Removed |Added
Attachment #34743|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #24 from Jonathan Druart ---
Created attachment 34943
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34943&action=edit
Bug 13417: Add the permission for all languages
--
You are receiving this mail beca
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are rec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #23 from Jonathan Druart ---
Created attachment 34942
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34942&action=edit
Bug 13417: (qa follow-up) Rename the permission to delete_public_lists
--
You are r
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Chris Cormack changed:
What|Removed |Added
Attachment #34485|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Chris Cormack changed:
What|Removed |Added
Attachment #34483|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #19 from Jonathan Druart ---
Test plan updated:
4/ You should be able to edit all public lists
is
4/ You should be able to delete all public lists
--
You are receiving this mail because:
You are watching all bug chang
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--- Comment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #17 from Jonathan Druart ---
Created attachment 34485
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34485&action=edit
Bug 13417: Limit the permission to delete
It's preferable to limit the permission to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Jonathan Druart changed:
What|Removed |Added
Attachment #34249|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #16 from M. de Rooy ---
(In reply to Jonathan Druart from comment #12)
> But we don't want to remove public lists.
> So I could submit a patch to remove private lists only, do you agree with
> that?
> I don't think it wil
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #15 from Jonathan Druart ---
Created attachment 34483
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34483&action=edit
Bug 13417: Allow staff members to manage public lists
Currently a public list can on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #14 from M. de Rooy ---
(In reply to Jonathan Druart from comment #13)
> (In reply to M. de Rooy from comment #11)
> > Saw a Bug X: Add permission for shelves
>
> Maybe bug 9833?
No the print message in your own patc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #12 from Jonathan Druart ---
(In reply to M. de Rooy from comment #9)
> (In reply to Jonathan Druart from comment #0)
> > Currently a public list can only be deleted by its owner.
> > This means lists can exist infinitely.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #13 from Jonathan Druart ---
(In reply to M. de Rooy from comment #11)
> Saw a Bug X: Add permission for shelves
Maybe bug 9833?
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #11 from M. de Rooy ---
Saw a Bug X: Add permission for shelves
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #10 from M. de Rooy ---
I would favor a permission for allowing staff to manage lists that they do not
own. It was discussed on older reports already.
But the solution of this patch is imo little bit too quick.
[1] The ch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #9 from M. de Rooy ---
(In reply to Jonathan Druart from comment #0)
> Currently a public list can only be deleted by its owner.
> This means lists can exist infinitely.
Please look for HandleDelBorrower.
When you delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #8 from Fridolin SOMERS ---
(In reply to Jonathan Druart from comment #6)
> If not user is logged.
> This code is used for intranet and opac.
Ah, OK.
Its because of line 455 in C4/VirtualShelves.pm :
$user=0 unless $u
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #7 from Jonathan Druart ---
"If no user is logged in"
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #6 from Jonathan Druart ---
If not user is logged.
This code is used for intranet and opac.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #5 from Fridolin SOMERS ---
I agree with a new permission.
What for is this line :
+if ( $user > 0 ) {
To exclude database user (the one in koha-conf.xml) ?
--
You are receiving this mail because:
You are watching
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolyn.som...@biblibre.co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Fridolin SOMERS changed:
What|Removed |Added
CC||l...@catalyst.net.nz
--- C
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
M. de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Jonathan Druart changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Marc Véron changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
You are receivi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Marc Véron changed:
What|Removed |Added
Attachment #34233|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #3 from Marc Véron ---
Created attachment 34249
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34249&action=edit
[Signed-off] Bug 13417: Allow staff members to manage public lists
Currently a public list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #2 from Jonathan Druart ---
Files for other languages will be add later.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Ko
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
--- Comment #1 from Jonathan Druart ---
Created attachment 34233
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34233&action=edit
Bug 13417: Allow staff members to manage public lists
Currently a public list can onl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417
Jonathan Druart changed:
What|Removed |Added
Status|NEW |ASSIGNED
See Als
65 matches
Mail list logo
