[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Jonathan Druart changed: What|Removed |Added Blocks||27718 Referenced Bugs:

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 robbi...@middlesex.mass.edu changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to master|Pushed to stable

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What|Removed |Added Blocks||22431 Referenced Bugs:

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #24 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What|Removed |Added Blocks||23175 Referenced Bugs:

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #23 from Marcel de Rooy --- @RM: Passing QA with a follow-up. Note that the current query also fails on strict SQL mode. So not blocking for that. And yes, it could be moved to a module on a new report. -- You are

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #22 from Marcel de Rooy --- Created attachment 90872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90872=edit Bug 13640: (QA follow-up) Allow NULL values for default_branch_item_rules.holdallowed If

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added Attachment #90639|0 |1 is obsolete|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #20 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #14) > Signing off as in a testing it appears to work as expected.. > > I'd love to see this query moved into a module and unit tested really, but >

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #19 from Marcel de Rooy --- The where condition is wrong. It should also incorporate the case that default_branch_item_rules is NULL (for istance, no corresponding record found for a biblio level hold). Will add a

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #18 from Marcel de Rooy --- Fails on strict sql mode: DBD::mysql::st execute failed: 'koha_master.reserves.reserve_id' isn't in GROUP BY [for Statement [ ... etc ] -- You are receiving this mail because: You are

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #16 from Martin Renvoize --- (In reply to Jonathan Druart from comment #15) > (In reply to Martin Renvoize from comment #12) > > (In reply to Jonathan Druart from comment #10) > > > Because there are 3 values: From any

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #15 from Jonathan Druart --- (In reply to Martin Renvoize from comment #12) > (In reply to Jonathan Druart from comment #10) > > Because there are 3 values: From any library, From home library and not > > allowed (0) >

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Martin Renvoize changed: What|Removed |Added Attachment #89665|0 |1 is obsolete|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #11 from Jonathan Druart --- Created attachment 89665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89665=edit Bug 13640: Do not display unreserveable items on the Holds to pull screen We should

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Paul Thornton changed: What|Removed |Added CC||paul.thorn...@educampus.ie

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #9 from Magnus Enger --- I think I managed to take the 'Default holds policy by item type' into account in this report: SELECT min(reservedate) as l_reservedate, reserves.reserve_id, reserves.borrowernumber as

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #8 from Magnus Enger --- (In reply to Katrin Fischer from comment #6) > Hm, I don't think we need more configuration options - we need the report to > use the ones we have correctly. ...but I can't convince myself 100%

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #7 from Magnus Enger --- Yeah, probably a good idea! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #6 from Katrin Fischer --- Hm, I don't think we need more configuration options - we need the report to use the ones we have correctly. -- You are receiving this mail because: You are watching all bug changes. You are

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no ---

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Dobrica Pavlinusic changed: What|Removed |Added CC||dpav...@rot13.org --

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Patrick Robitaille changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #4 from Fiona Borthwick --- This has been raised by one of our customers and I can see it being a big problem for the larger libraries. In our customer's case, they have marked certain

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Fiona Borthwick changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #3 from David Cook --- Just a note that I have no plans to work on this currently, so I'm happy for someone else to work on fixing this bug. -- You are receiving this mail because: You are the

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #2 from Lisette --- We have this as well. If 1 item has no holds allowed and the other is checked out the no holds allowed will show up on the holds list. -- You are receiving this mail

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Lisette changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Janet McGowan changed: What|Removed |Added CC|

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|