https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #146 from M. Tompsett ---
Created attachment 70257
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70257&action=edit
Bug 14385 Followup: C4::Borrowers not found
GetMember is in C4::Members, not C4::Borr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #145 from M. Tompsett ---
Created attachment 70256
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70256&action=edit
Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories
Edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #144 from Liz Rea ---
a+ preserving attribution. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Status|Patch doesn't apply |ASSIGNED
--- Comment #143 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #141 from M. Tompsett ---
(In reply to Aleisha Amohia from comment #140)
> Sorry for the spam! Signing off on all patches
Thanks for the sign off. To the one that has the energy to QA this. The test
plan is in comment #1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Blocks||10589
Referenced Bugs:
http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #14
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66403|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66401|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66372|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66347|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66210|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66209|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66302|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66361|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66303|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66208|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66206|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66207|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66205|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66202|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66203|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66204|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66200|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66201|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66199|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66194|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66197|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66198|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66196|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66195|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66193|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
Aleisha Amohia changed:
What|Removed |Added
Attachment #66192|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #113 from M. Tompsett ---
comment #112 represents the latest test plan that I followed. I'm calling this
done. Multiple eyes and sign offs on this would be appreciated.
--
You are receiving this mail because:
You are wa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #112 from M. Tompsett ---
back up database
git bz apply 19040
git bz apply 14385
sudo koha-shell -c bash kohadev
./installer/data/misc/updatedatabase.pl
-- this proves the atomic update
drop the database
create an empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #111 from M. Tompsett ---
Created attachment 66403
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66403&action=edit
Bug 14385: Fix ILSDI_Services test when clubs with branch exist
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Patch complexity|Medium patch|Large patch
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #110 from M. Tompsett ---
Created attachment 66401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66401&action=edit
Bug 14385: Fix breaking issues constraint in ITerator test
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #109 from M. Tompsett ---
Created attachment 66372
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66372&action=edit
Bug 14385: Corrected opac-details searchResult call
--
You are receiving this mail b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #108 from M. Tompsett ---
Created attachment 66361
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66361&action=edit
Bug 14385: Improve C4::Record::marcrecord2csv test cases
--
You are receiving this m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #107 from M. Tompsett ---
Created attachment 66347
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66347&action=edit
Bug 14385: Test C4/Labels/Label.pm changes
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #106 from M. Tompsett ---
Created attachment 66303
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66303&action=edit
Bug 14385: Added missing 'my'
--
You are receiving this mail because:
You are watchi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #105 from M. Tompsett ---
Created attachment 66302
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66302&action=edit
Bug 14385: Trigger the C4::ILSDI::Services changes
prove t/db_dependent/ILSDI_Service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment #10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Status|In Discussion |ASSIGNED
--- Comment #103 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #98 from M. Tompsett ---
Created attachment 66206
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66206&action=edit
Bug 14385: Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
prove t/db_dependent/I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #102 from M. Tompsett ---
Created attachment 66210
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66210&action=edit
Bug 14385: Fix hiding in opac-tags
opac/opac-tags.pl was not properly hiding.
There
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #100 from M. Tompsett ---
Created attachment 66208
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66208&action=edit
Bug 14385: Add borrower category overrides
These files generally add borcat parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #99 from M. Tompsett ---
Created attachment 66207
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66207&action=edit
Bug 14385: Add missing test to trigger Koha/BiblioUtils/Iterator change
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #101 from M. Tompsett ---
Created attachment 66209
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66209&action=edit
Bug 14385: Modify opac-ISBDdetail and opac-MARCdetail
Both files had similar logic. T
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #96 from M. Tompsett ---
Created attachment 66204
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66204&action=edit
Bug 14385: Add some commenting to make sense of logic
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #94 from M. Tompsett ---
Created attachment 66202
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66202&action=edit
Bug 14385: Properly trigger all changes in C4/Search.pm
Signed-off-by: Mark Tompsett
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #95 from M. Tompsett ---
Created attachment 66203
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66203&action=edit
Bug 14385: Fix QA Test tool failures
C4/Search.pm had some tabs.
Signed-off-by: Mark
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #91 from M. Tompsett ---
Created attachment 66199
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66199&action=edit
Bug 14385: Tweak borrower category code
$borrower->{categorycode} on a Koha::Patron is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #90 from M. Tompsett ---
Created attachment 66198
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66198&action=edit
Bug 14385: Tweak t/db_dependent/Items.t to fully test changes
This will test all the i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #97 from M. Tompsett ---
Created attachment 66205
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66205&action=edit
Bug 14385: Refactor EmbedItemsInMarcBiblio parameters to hashref
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #92 from M. Tompsett ---
Created attachment 66200
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66200&action=edit
Bug 14385: Search was returning URLS for wrong interface
There was one search context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #93 from M. Tompsett ---
Created attachment 66201
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66201&action=edit
Bug 14385: Corrected issues with category code.
When a user isn't logged in, $borrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #87 from M. Tompsett ---
Created attachment 66195
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66195&action=edit
Bug 14385: Added missing GetHiddenItems parameter change case
Without this prove t had
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #85 from M. Tompsett ---
Created attachment 66193
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66193&action=edit
Bug 14385 Followup: C4::Borrowers not found
GetMember is in C4::Members, not C4::Borro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #88 from M. Tompsett ---
Created attachment 66196
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66196&action=edit
Bug 14385: Always use mocks, not set_preference
Signed-off-by: Mark Tompsett
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #86 from M. Tompsett ---
Created attachment 66194
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66194&action=edit
Bug 14385: Followup: changes to sysprefs.sql and atomicupdate
Run updatedatabase.pl wh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #66103|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #89 from M. Tompsett ---
Created attachment 66197
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66197&action=edit
Bug 14385: Tweaks so t/db_dependent/00-strict.t passes
There was a typo botcat vs borc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #66129|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #66130|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #66126|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #66125|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #66127|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #66116|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #66118|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #66117|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65408|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65409|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65386|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65411|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65410|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65384|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65387|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65388|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65389|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65382|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65380|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65381|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65385|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65383|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65379|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Attachment #65378|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Status|ASSIGNED|In Discussion
--- Comment #59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Depends on||19040
Referenced Bugs:
http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #58 from M. Tompsett ---
To test all the EmbedItemsInMarcBiblio calls:
prove t/db_dependent/Biblio.t
prove t/db_dependent/Record/marcrecord2csv.t
prove t/db_dependent/Koha/BiblioUtils/Iterator.t
prove t/db_dependent/E
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #57 from M. Tompsett ---
The problem with this, as it stands is the GetMarcBiblio call does not receive
the patron category code, so it can't pass it to EmbedItemsInMarcBiblio which
can't then pass it to GetHiddenItemnumb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #53 from M. Tompsett ---
Created attachment 65408
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65408&action=edit
Bug 14385: Add some commenting to make sense of logic
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #55 from M. Tompsett ---
Created attachment 65410
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65410&action=edit
Bug 14385: Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
prove t/db_dependent/I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #56 from M. Tompsett ---
Created attachment 65411
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65411&action=edit
Bug 14385: Add missing test to trigger Koha/BiblioUtils/Iterator change
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #54 from M. Tompsett ---
Created attachment 65409
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65409&action=edit
Bug 14385: Refactor EmbedItemsInMarcBiblio parameters to hashref
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--- Comment #52 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment #51
101 - 200 of 261 matches
Mail list logo
