[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Nick Clemens changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Mason James changed: What|Removed |Added Blocks||15333

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #31 from Jonathan Druart --- (In reply to Jonathan Druart from comment #25) > Comment on attachment 42919 [details] [review] > [PASSED QA] Bug 14522 - Use Koha::Cache for

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 43070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43070=edit Bug 14522: (QA followup) tidy tests Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #29 from Kyle M Hall --- Created attachment 43071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43071=edit Bug 14522 [QA Followup] * Change POD to a brief comment * Fix UT so

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Mason James changed: What|Removed |Added Change sponsored?|--- |Sponsored

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #20 from Kyle M Hall --- > > I set up about 350 holidays and tried > > checkout periods of 180 and days. Both were about the same speed with > > and without the patches respectively. > > your

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #24 from Kyle M Hall --- Created attachment 42922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42922=edit [PASSED QA] Bug 14522 [QA Followup] - Remove $single_holidays global

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Kyle M Hall changed: What|Removed |Added Attachment #42851|0 |1

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #22 from Kyle M Hall --- Created attachment 42920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42920=edit [PASSED QA] Bug 14522 [Followup] - fix =cut typo

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #25 from Jonathan Druart --- Comment on attachment 42919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42919 [PASSED QA] Bug 14522 - Use Koha::Cache for

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #26 from Jonathan Druart --- Created attachment 42926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42926=edit Script to try and reproduce the problem -- You

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #23 from Kyle M Hall --- Created attachment 42921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42921=edit [PASSED QA] Bug 14522 [QA Followup] - Koha complains about missing

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #19 from Mason James --- (In reply to Kyle M Hall from comment #18) > My testing has not shown any regressions, but I've been unable to prove any > speed improvement. Maston, can you provide a unit

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Kyle M Hall changed: What|Removed |Added Attachment #42856|0 |1

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #17 from Kyle M Hall --- Created attachment 42888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42888=edit Bug 14522 [QA Followup] - Koha complains about missing C4::Dates on

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #18 from Kyle M Hall --- My testing has not shown any regressions, but I've been unable to prove any speed improvement. Maston, can you provide a unit test or even just a perl script to demonstrate

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Nick Clemens changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Nick Clemens changed: What|Removed |Added Attachment #41050|0 |1

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Mason James changed: What|Removed |Added Attachment #42855|0 |1

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #14 from Mason James --- Created attachment 42856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42856=edit fix =cut typo -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Seth changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #15 from Mason James --- (In reply to Nick Clemens from comment #11) > Test plan and all tests pass. QA test tools fail for pod in > Koha::Calendar.pm > > Line 97 looks like you said =c when you

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #12 from Mason James --- Created attachment 42855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42855=edit Bug 14522 - Use Koha::Cache for accessing single_holidays() this patch

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #9 from Mason James --- > ..as this sequence of events is quite rare, and would only occur during > deliberate testing - i think this bug is a effectively a WONTFIX Sorry, when I say WONTFIX - I mean

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #7 from Mason James --- (In reply to James from comment #6) > Problem in testing, when trying to create holidays using patch the date > format is being read incorrectly resulting in the following

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #8 from Mason James --- (In reply to James from comment #6) > Problem in testing, when trying to create holidays using patch the date > format is being read incorrectly resulting in the following

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #4 from Mason James --- Created attachment 42255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42255=edit pic: create range of holidays -- You are receiving this mail because: You

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #3 from Mason James --- (In reply to Joonas Kylmälä from comment #2) > (In reply to Mason James from comment #1) > >1/ add a bunch of single_holidays to your test koha, (my table has 400 > >holiday

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #5 from Mason James --- (In reply to Mason James from comment #3) > (In reply to Joonas Kylmälä from comment #2) > > (In reply to Mason James from comment #1) > > >1/ add a bunch of single_holidays to

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 James changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Joonas Kylmälä changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Zeno Tajoli changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Zeno Tajoli changed: What|Removed |Added CC|z.taj...@cineca.it | -- You

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Bob Birchall b...@calyx.net.au changed: What|Removed |Added CC|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Mason James m...@kohaaloha.com changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|NEW |Needs

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #1 from Mason James m...@kohaaloha.com --- Created attachment 41050 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41050action=edit Bug 14522 - Use Koha::Cache for accessing single_holidays() this patch

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Mason James m...@kohaaloha.com changed: What|Removed |Added Blocks||8089

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Jonathan Druart jonathan.dru...@bugs.koha-community.org changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Mason James m...@kohaaloha.com changed: What|Removed |Added Blocks||14315