https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Jonathan Druart changed:
What|Removed |Added
Blocks||21517
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Josef Moravec changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Katrin Fischer changed:
What|Removed |Added
Resolution|---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #97 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #96)
> One of the OAI unit tests seems to have an issue with transactions.
No, it is Sets.t and it is not in this patch set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #96 from Marcel de Rooy ---
One of the OAI unit tests seems to have an issue with transactions.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #95 from Katrin Fischer ---
I think part of this would well qualify as bug fixes, but overall it's a big
patch and I am not confident pushing it to the stable version. What do people
think?
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Kyle M Hall changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Tomás Cohen Arazi changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #92 from Tomás Cohen Arazi ---
Created attachment 63174
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63174=edit
Bug 15108: (QA followup) Fix atomic update file
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #60608|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #60331|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Tomás Cohen Arazi changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Olli-Antti Kivilahti changed:
What|Removed |Added
Attachment #60835|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #87 from Olli-Antti Kivilahti ---
Created attachment 60835
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60835=edit
Bug 15108 - OAI-PMH provider improvements
- Fixed date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #86 from Ere Maijala ---
Created attachment 60608
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60608=edit
Fixed tests to be more robust and also work with UNIMARC.
Added a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #85 from Ere Maijala ---
I suppose that would have been the case with a clean database. I'll revise the
tests a bit to assume it's not clean (delete issues and oai_sets at least).
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #84 from Marcel de Rooy ---
(In reply to Ere Maijala from comment #83)
> Marcel: Was there a reason for removing the deletion of issues in your patch
> in Bug 17493?
>
> I suppose the issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #83 from Ere Maijala ---
Marcel: Was there a reason for removing the deletion of issues in your patch in
Bug 17493?
I suppose the issue with UNIMARC is that the OAI-PMH provider does take it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Julian Maurice changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #81 from Marcel de Rooy ---
(In reply to Ere Maijala from comment #80)
> Marcel: Yes, this patch should include all the tests from Bug 17493. If
> there were even more somewhere, then I've
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Bug 15108 depends on bug 17493, which changed state.
Bug 17493 Summary: Improve OAI Server tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17493
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #80 from Ere Maijala ---
Marcel: Yes, this patch should include all the tests from Bug 17493. If there
were even more somewhere, then I've missed them.
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #79 from Marcel de Rooy ---
Ere: Did you move all tests here now ?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Josef Moravec changed:
What|Removed |Added
Attachment #60260|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Ere Maijala changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Ere Maijala changed:
What|Removed |Added
Attachment #58245|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #76 from Ere Maijala ---
I'm finally able to get back to this. Thanks everyone for the work you've done
meanwhile. I'll try to rebase and address any issues soon.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Josef Moravec changed:
What|Removed |Added
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #74 from Frédéric Demians ---
Thanks for your work Marcel.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #73 from Marcel de Rooy ---
One further note (from QA tools):
FAIL Koha/OAI/Server/ListIdentifiers.pm
FAIL Koha/OAI/Server/ListRecords.pm
FAIL valid
Can't locate package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58063|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #71 from Marcel de Rooy ---
Created attachment 58251
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58251=edit
Bug 15108: [QA Follow-up] Serious doubts on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #70 from Marcel de Rooy ---
Created attachment 58250
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58250=edit
Bug 15108: [QA Follow-up] Changes from removing collection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58080|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58072|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #66 from Marcel de Rooy ---
Created attachment 58246
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58246=edit
Bug 15108: Remove Koha::AtomicUpdater dependency
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58062|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58064|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #64 from Marcel de Rooy ---
QA: Resuming today.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #63 from Marcel de Rooy ---
QA: Unfortunately I cannot finish this QA session now. Will resume it later
next week. Please wait :)
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #62 from Marcel de Rooy ---
Created attachment 58080
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58080=edit
Bug 15108: [QA Follow-up] Remove the sleep
Ordering by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #61 from Marcel de Rooy ---
Created attachment 58072
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58072=edit
Bug 15108: [QA Follow-up] Remove truncate
Truncate operations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #60 from Marcel de Rooy ---
Truncate operations cause an implicit commit, and so cannot be rolled back.
I discovered that now too in my test database..
Will adjust the statement :)
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58065|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #58 from Marcel de Rooy ---
Hm I have serious doubts about my last fourth patch. Will the adjusted order by
undo the performance gain from the new indexes?
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58059|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58061|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #57 from Marcel de Rooy ---
Only adjusted dbrev now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58058|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #58060|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #52 from Marcel de Rooy ---
Created attachment 58061
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58061=edit
Bug 15108: [QA Follow-up] Remove the sleep
If we order by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #51 from Marcel de Rooy ---
Just a rebase to begin with. Note that we had merge markers in one of those
patches too.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #49 from Marcel de Rooy ---
Created attachment 58059
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58059=edit
Remove Koha::AtomicUpdater dependency
Signed-off-by: Frederic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #50 from Marcel de Rooy ---
Created attachment 58060
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58060=edit
Bug 15108: Fix OAI Server tests
Tests introduced by bug 17493
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
Attachment #53853|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #47 from Marcel de Rooy ---
QA: Looking here now. Rebasing first.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Frédéric Demians changed:
What|Removed |Added
Attachment #56813|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #45 from Frédéric Demians ---
Created attachment 56813
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56813=edit
Fix OAI Server tests
Tests introduced by bug 17493 must be amended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Frédéric Demians changed:
What|Removed |Added
Depends on||17493
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #44 from Frédéric Demians ---
> I've been mocking an OAI server very simply using Test::TCP and
> Net::Server::HTTP, so that I can test my OAI client.
db_dependent/OAI/Server.t already mocks Koha OAI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
David Cook changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Marcel de Rooy changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Frédéric Demians changed:
What|Removed |Added
Attachment #52423|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Frédéric Demians changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #40 from Frédéric Demians ---
Created attachment 53853
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53853=edit
Remove Koha::AtomicUpdater dependency
Signed-off-by: Frédéric
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Katrin Fischer changed:
What|Removed |Added
Assignee|olli-antti.kivila...@jns.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #39 from Ere Maijala ---
(In reply to Katrin Fischer from comment #37)
That makes sense to me.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #38 from Katrin Fischer ---
include_items option ... is what I meant :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Mirko Tietgen changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #37 from Katrin Fischer ---
Hm, reading through the use cases Frederic wrote I wonder if it wouldn't work
for a first step if we say that the item changes should only be taken into
account if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Josef Moravec changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #36 from Ere Maijala ---
(In reply to Frédéric Demians from comment #35)
> > That said, if you think there should be an option to control whether item
> > timestamps are taken into account, I can
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #35 from Frédéric Demians ---
(In reply to Katrin Fischer from comment #32)
> Hm, I think in some cases it would be nice to include updates on available -
> I wouldn't rule that out. Maybe the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #34 from Ere Maijala ---
(In reply to Frédéric Demians from comment #31)
> > - If items are included in the records, their timestamps are taken into
> > account everywhere so that whichever is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #33 from Katrin Fischer ---
(In reply to Frédéric Demians from comment #30)
> (In reply to Katrin Fischer from comment #29)
> > Hi Frederic, that's ok - not really a dependency. The RM moves the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #32 from Katrin Fischer ---
Hm, I think in some cases it would be nice to include updates on available - I
wouldn't rule that out. Maybe the decision to take the item change into account
could
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #31 from Frédéric Demians ---
> - Fixed date handling to use UTC as specs require.
> - Added support for second precision in time stamps.
> - Added support for marc21 metadata prefix as recommended in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #30 from Frédéric Demians ---
(In reply to Katrin Fischer from comment #29)
> Hi Frederic, that's ok - not really a dependency. The RM moves the sql file
> into updatedatabase on pushing the enh. This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Katrin Fischer changed:
What|Removed |Added
Depends on|14698 |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Frédéric Demians changed:
What|Removed |Added
Depends on|3206|14698
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #27 from Ere Maijala ---
OKay, I've done my best. Sorry for the messy comments!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Ere Maijala changed:
What|Removed |Added
Attachment #52422|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #25 from Katrin Fischer ---
Thx!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Ere Maijala changed:
What|Removed |Added
Attachment #52422|Bug 15108 - OAI-PMH |Bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Ere Maijala changed:
What|Removed |Added
Attachment #52416|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #23 from Katrin Fischer ---
Hi Ere, looking good! One more thing: please attach a current test
plan/description of the changes - best to include it in the commit message of
your patch already.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Ere Maijala changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Ere Maijala changed:
What|Removed |Added
Attachment #51962|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #20 from Katrin Fischer ---
Hi Ere, it's missing the information about you as the author and such - that's
usually the first lines. Take a look at git bz for our usual workflow:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #19 from Ere Maijala ---
It's definitely done with a simple git diff command. Let me know if you need it
done with specific parameters or something.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #18 from Frédéric Demians ---
(In reply to Ere Maijala from comment #16)
> It would be great if others could try this out and see if it works for them.
It looks very good, Ere! How did you generate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #16 from Ere Maijala ---
It would be great if others could try this out and see if it works for them.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Ere Maijala changed:
What|Removed |Added
Attachment #44317|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
--- Comment #14 from Olli-Antti Kivilahti ---
Hi!
We are upgrading our KohaSuomi branch (with 300 custom commits) built on top of
Koha 3.16 to master this summer.
I heard that it is "impossible".
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Frédéric Demians changed:
What|Removed |Added
Blocks||15406
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108
Jonathan Druart changed:
What|Removed |Added
CC|
1 - 100 of 115 matches
Mail list logo