https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Niamh Walker-Headon changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Jonathan Druart changed:
What|Removed |Added
Blocks||27466
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Text to go in the||This enhancement lets you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #74 from Jonathan Druart
---
Created attachment 108163
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108163=edit
Bug 16371: (follow-up) DB changes
We need to keep "opac" is the pref was set before
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Jonathan Druart changed:
What|Removed |Added
Version(s)||20.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #73 from Jonathan Druart
---
Pushed to master for 20.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #72 from Jonathan Druart
---
Created attachment 108160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108160=edit
Bug 16371: Fix inconsistencies with timestamp
The timestamp value needs to be updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #71 from Emmi Takkinen ---
Created attachment 108098
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108098=edit
Bug 16371: Combine get_daily_quote and get_daily_quote_for_interface
This patch combines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #70 from Emmi Takkinen ---
Created attachment 108097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108097=edit
Bug 16371: Remove GetDailyQuote tests from Koha.t
Tests in Koha.t failed due
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #69 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #68)
> (In reply to Emmi Takkinen from comment #67)
> > (In reply to Jonathan Druart from comment #66)
> 70 timestamp => { -like =>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #68 from Jonathan Druart
---
(In reply to Emmi Takkinen from comment #67)
> (In reply to Jonathan Druart from comment #66)
>
> > 2. There are still occurrences of GetDailyQuote in t/db_dependent/Koha.t
> > (the tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #67 from Emmi Takkinen ---
(In reply to Jonathan Druart from comment #66)
> 2. There are still occurrences of GetDailyQuote in t/db_dependent/Koha.t
> (the tests are failing)
>
Didn't notice these until now. But
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #62 from Jonathan Druart
---
Quote vs DailyQuote vs QuoteOfTheDay?
I think Koha::DailyQuote could be more meaningful.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #61 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #59)
> "Cite" as in "Citations" is the only real synonym I can come up with.. but
> it's not especially clear to me.. I find that more confusing the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #60 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #59)
> "Cite" as in "Citations" is the only real synonym I can come up with.. but
> it's not especially clear to me.. I find that more confusing the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #63 from Katrin Fischer ---
More meaningful, but the daily could change at some point. I'd still be ok with
that as a compromise.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #66 from Jonathan Druart
---
Better in only one comment:
1. We don't need the weird "Koha::Exceptions::UnknownProgramState" exception,
C4::Context->interface() is always returning something.
2. There are still
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #59 from Martin Renvoize ---
"Cite" as in "Citations" is the only real synonym I can come up with.. but it's
not especially clear to me.. I find that more confusing the "Quote" I think...
Not read the patches yet so,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #64 from Martin Renvoize ---
Personally.. I think Koha::Quote is fine.. for other uses I'm envisaging
they're more nested.. i.e Acquisition::Quotes as Tomas highlighted.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #58 from Jonathan Druart
---
Also, we don't need the weird "Koha::Exceptions::UnknownProgramState"
exception, C4::Context->interface() is always returning something.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #57 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #56)
> I think Koha::Quote[s] is too generic, I am asking a couple of other QAers
> for feedback.
I think if we had some feature to place a RFQ or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106868|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106866|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106867|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106864|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106865|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106860|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106863|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106862|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106861|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Attachment #106859|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #106858|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #106818|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #106820|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103979|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103977|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103978|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103975|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103976|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103973|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103974|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Attachment #106819|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #34 from Emmi Takkinen ---
(In reply to David Nind from comment #33)
> Everything works as expected, however the tests fail! 8-(
>
> prove t/db_dependent/Koha/Quotes.t
> t/db_dependent/Koha/Quotes.t .. 1/13 Can't use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #33
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #32 from Emmi Takkinen ---
Created attachment 106820
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106820=edit
Bug 16371: Add database updates
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #31 from Emmi Takkinen ---
Created attachment 106819
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106819=edit
Bug 16371: Rewrite get_daily_quote
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #30 from Emmi Takkinen ---
Created attachment 106818
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106818=edit
Bug 16371: Fix QA issues, change terminology
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #29
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Attachment #10|0 |1
is patch|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--- Comment #28
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Attachment #10|1 |0
is patch|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103732|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #24 from David Nind ---
Created attachment 103977
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103977=edit
Bug 16371: Quote of the Day (QOTD) - Display in different interfaces
Set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103334|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103332|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103331|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103330|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Attachment #103329|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #19 from Emmi Takkinen ---
Created attachment 103732
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103732=edit
Bug 16371: Fix tests
Tests failed due ids already existing in 'quotes' table.
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Attachment #103019|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Attachment #102516|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Attachment #102515|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #14 from Emmi Takkinen ---
Created attachment 103331
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103331=edit
Bug 16371: Rename test file
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #13 from Emmi Takkinen ---
Created attachment 103330
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103330=edit
Bug 16371: Move GetDailyQuote to get_daily_quote
This patch moves subroutine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #12 from Emmi Takkinen ---
Created attachment 103329
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103329=edit
Bug 16371: Add Koha::Quote[s] classes
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--- Comment #11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Roberts changed:
What|Removed |Added
Attachment #102969|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Roberts changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #7 from Emmi Takkinen ---
Created attachment 102969
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102969=edit
Bug 16371: Use multi-select on syspref and remove 'display_daily_quote'
condition
This
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #6 from Katrin Fischer ---
It could also be a multi-select with 2 checkboxes for staff and OPAC showing
up.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
David Roberts changed:
What|Removed |Added
CC||david.roberts@ptfs-europe.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Aleisha Amohia changed:
What|Removed |Added
CC|alei...@catalyst.net.nz |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #4 from Emmi Takkinen ---
Created attachment 102517
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102517=edit
Bug 16371: Rework tests
Use TestBuilder and 'mock_preferences' in tests.
To test, prove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
--- Comment #3 from Emmi Takkinen ---
Created attachment 102516
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102516=edit
Bug 16371: Quote of the Day (QOTD) - Display in different interfaces
Set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Emmi Takkinen changed:
What|Removed |Added
Assignee|olli-antti.kivila...@jns.fi |emmi.takki...@outlook.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
92 matches
Mail list logo