[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #57 from David Cook --- (In reply to Martin Renvoize from comment #56) > David earns the necromancer badge... Guilty O_O. The worst part is that I have no idea why I was digging yesterday. Oh wait I was going through

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #56 from Martin Renvoize --- David earns the necromancer badge... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #55 from David Cook --- We should've changed this title as it's actually really misleading in hindsight, but oh well! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Bug 16892 depends on bug 10988, which changed state. Bug 10988 Summary: Allow login via Google OAuth2 (OpenID Connect) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 What|Removed

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Bug 16892 depends on bug 10988, which changed state. Bug 10988 Summary: Allow login via Google OAuth2 (OpenID Connect) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 What|Removed

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #52 from Jonathan Druart --- (In reply to David Cook from comment #48) > (In reply to Jonathan Druart from comment #47) > > Everything looks fine to me. > > However I think it

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #51 from M. Tompsett --- Created attachment 65316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65316=edit Bug 16892: Address error checking in comment #47 Tweaked logic to

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|Needs

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #50 from Jonathan Druart --- (In reply to M. Tompsett from comment #49) > > Usually I am not in favour of > > over-checking everything but it sounds like it is needed here (in

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #49 from M. Tompsett --- (In reply to Jonathan Druart from comment #47) > However I think it would be good to handle a wrong or non-existent patron > category or branchcode

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #48 from David Cook --- (In reply to Jonathan Druart from comment #47) > Everything looks fine to me. > However I think it would be good to handle a wrong or non-existent patron > category or

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #47 from Jonathan Druart --- Everything looks fine to me. However I think it would be good to handle a wrong or non-existent patron category or branchcode

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Nick Clemens changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Nick Clemens changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #45 from M. Tompsett --- (In reply to Nick Clemens from comment #44) > Perhaps if OAuth is activated just a note added that when you log out of > Koha you may still be logged in via google? [SNIP]

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #44 from Nick Clemens --- Perhaps if OAuth is activated just a note added that when you log out of Koha you may still be logged in via google? I agree a user with many tabs open may not expect

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #42 from M. Tompsett --- (In reply to Nick Clemens from comment #41) > I tested under plack/memcached and saw no difference when I removed the find > for borrower so think that can be safely

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #41 from Nick Clemens --- Tested with new instrcutions, works as advertised, the code looks good to me I tested under plack/memcached and saw no difference when I removed the find for borrower

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #40 from Nick Clemens --- Created attachment 63120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63120=edit Bug 16892: Follow up use AddMember as per QA comment Same Test

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #39 from Nick Clemens --- Created attachment 63119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63119=edit Bug 16892: Follow up with adding missing IGNORE Signed-off-by:

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #38 from Nick Clemens --- Created attachment 63118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63118=edit Bug 16892: System Preferences This adds the missing system

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Nick Clemens changed: What|Removed |Added Attachment #61886|0 |1

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #36 from M. Tompsett --- I haven't tested it, but I think the find is a way of ensuring the member has been added. A cache flush? A pause? Remove it and test with a plack-based system, before

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #35 from M. Tompsett --- ARG! I really hate them constantly changing the interface. It makes it so much harder to help people set up. First you need to confirm the Google OAuth works normally: Go

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #34 from Jonathan Druart --- Can we get an updated test plan? It sounds like the Google APIs interface has changed. The last line you added to opac/svc/auth/googleopenidconnect

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #33 from M. Tompsett --- Given that Google has changed their interface, I thought I'd post a newer update on how to link Google OAuth. Go to https://console.developers.google.com/project Log in

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #31 from sandbo...@biblibre.com --- Created attachment 61888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61888=edit Bug 16892: Follow up with adding missing IGNORE

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #32 from sandbo...@biblibre.com --- Created attachment 61889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61889=edit Bug 16892: Follow up use AddMember as per QA comment Same

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #30 from sandbo...@biblibre.com --- Created attachment 61887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61887=edit Bug 16892: System Preferences This adds the missing

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #29 from sandbo...@biblibre.com --- Created attachment 61886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61886=edit Bug 16892: Add automatic patron registration via OAuth2

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandbo...@biblibre.com changed: What|Removed |Added Attachment #61804|0

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandbo...@biblibre.com changed: What|Removed |Added Attachment #61803|0

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandbo...@biblibre.com changed: What|Removed |Added Attachment #61802|0

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandbo...@biblibre.com changed: What|Removed |Added Attachment #61801|0

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Attachment #61800|0 |1

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Attachment #58375|0 |1

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Attachment #58373|0 |1

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Attachment #58374|0 |1

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #23 from M. Tompsett --- Created attachment 61800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61800=edit Bug 16892: Follow up use AddMember as per QA comment Same Test plan as

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #22 from M. Tompsett --- (In reply to Jonathan Druart from comment #21) > Koha::Patron->new should not be called directly yet. > Please use AddMember instead (unless there is a good reason?). Valid

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Bug 16892 depends on bug 10988, which changed state. Bug 10988 Summary: Allow login via Google OAuth2 (OpenID Connect) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 What|Removed

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #20 from PTFS Europe Sandboxes --- Created attachment 58375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58375=edit Bug 16892: Follow up with adding missing IGNORE

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #19 from PTFS Europe Sandboxes --- Created attachment 58374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58374=edit Bug 16892: System Preferences This adds the missing

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #18 from PTFS Europe Sandboxes --- Created attachment 58373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58373=edit Bug 16892: Add automatic patron registration via OAuth2

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 PTFS Europe Sandboxes changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #57112|0

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #57113|0

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #57111|0

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Attachment #53488|0 |1

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Attachment #53485|0 |1

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Attachment #53257|0 |1

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #12 from M. Tompsett --- (In reply to David Cook from comment #11) > Ahh, sounds good. > > I suppose I'm still not happy that this feature is Google-specific and > wasn't made to be more general,

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #11 from David Cook --- Ahh, sounds good. I suppose I'm still not happy that this feature is Google-specific and wasn't made to be more general, but I had the opportunity to contribute my Open

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #10 from Jerwyn --- Yeap good thing its already available. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #9 from Jerwyn --- Created attachment 56081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56081=edit domain -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #8 from M. Tompsett --- Comment on attachment 53257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53257 Bug 16892: Add automatic patron registration via OAuth2 login Review of

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #7 from M. Tompsett --- Jerwyn, I think you missed David's point. This does not limit to a particular domain. Though, you do bring up a valid counter point, but would need further implementation.

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jerwyn changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 David Cook changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Depends on||10988

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Josef Moravec changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #4 from M. Tompsett --- Created attachment 53488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53488=edit Bug 16892: Follow up with adding missing IGNORE -- You are receiving

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #3 from M. Tompsett --- TEST PLAN - 1) backup the database 2) run upgrade: ./installer/data/mysql/updatedatabase.pl -- proves the atomic update. 3) run it again: -- proves the INSERT

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #2 from M. Tompsett --- Created attachment 53485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53485=edit Bug 16892: System Preferences This adds the missing system preferences

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Status|NEW |Needs

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 --- Comment #1 from M. Tompsett --- Created attachment 53257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53257=edit Bug 16892: Add automatic patron registration via OAuth2 login 10988

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 M. Tompsett changed: What|Removed |Added Patch complexity|--- |Small