[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 93764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93764=edit Bug 17314 : Added _to_model and _to_api methods and changed attirbutes naming -- You

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 93763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93763=edit Bug 17314: QA Followup Test plan unchanged -- You are receiving this mail because:

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #36 from Tomás Cohen Arazi --- Created attachment 93762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93762=edit Bug 17314: Migration from Swagger2 to OpenApi This patch migrates the original

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 93761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93761=edit Bug 17314: Routes to handle purchase suggestions -- You are receiving this mail

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90171|0 |1 is obsolete|

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90172|0 |1 is obsolete|

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Tomás Cohen Arazi changed: What|Removed |Added Attachment #90176|0 |1 is obsolete|

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Tomás Cohen Arazi changed: What|Removed |Added Attachment #91546|0 |1 is obsolete|

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added Attachment #91545|0 |1 is obsolete|

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #31 from Michal Denar --- Hi Arthur, nice to see progress in this bug. I'm ready to test :-) -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #30 from Arthur Suzuki --- Created attachment 91545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91545=edit Bug 17314 : Added _to_model and _to_api methods -- You are receiving this mail because:

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |ASSIGNED

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Failed QA

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #27 from Arthur Suzuki --- Hhmmm... I'd say the following : The API is not a huge mass of users. Also, C4 code is also going to move toward Koha::Suggestion one day or another. It's not like we'd be developing new

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #26 from Arthur Suzuki --- (In reply to Jonathan Druart from comment #24) > I do not know if there is a precedence, but here, adding a new suggestion > from the REST API and from the interface will not called the same >

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #25 from Arthur Suzuki --- Created attachment 90176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90176=edit Bug 17314 : QA Followup Test plan unchanged -- You are receiving this mail because: You

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #24 from Jonathan Druart --- I do not know if there is a precedence, but here, adding a new suggestion from the REST API and from the interface will not called the same method/subroutine IMO we should not do that.

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added Assignee|m...@jkozlovsky.cz |arthur.suz...@biblibre.com

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #23 from Arthur Suzuki --- Created attachment 90172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90172=edit Bug 17314 : Migration from Swagger2 to OpenApi -- You are receiving this mail because:

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added Attachment #58101|0 |1 is obsolete|

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #21 from Jiri Kozlovsky --- (In reply to Jon Knight from comment #20) > I noticed that this doesn't apply cleanly to the latest master HEAD on my > kohadevbox. I could help rebase if that would be

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #20 from Jon Knight --- I noticed that this doesn't apply cleanly to the latest master HEAD on my kohadevbox. I could help rebase if that would be useful to nudge this bug along? Unless of

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jonathan Druart changed: What|Removed |Added Component|Web services

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jon Knight changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Josef Moravec changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Mike changed: What|Removed |Added Status|Failed QA |Needs Signoff --

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #17 from Jiri Kozlovsky --- Created attachment 60133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60133=edit Bug 17314 - QA followup 2nd Fixed: Smartmatch Updating suggestion

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #16 from Jiri Kozlovsky --- (In reply to Jiri Kozlovsky from comment #15) > (In reply to Jiri Kozlovsky from comment #14) > > > And I found one problem: when I'am adding suggestion through API, I

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #15 from Jiri Kozlovsky --- (In reply to Jiri Kozlovsky from comment #14) > > And I found one problem: when I'am adding suggestion through API, I can't > > see them in the user interface, unless I add

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #14 from Jiri Kozlovsky --- > And I found one problem: when I'am adding suggestion through API, I can't > see them in the user interface, unless I add the branchcode - it should be > somehow set as

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #13 from Josef Moravec --- Also, unit test are needed I think -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Josef Moravec changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #11 from Jiri Kozlovsky --- Created attachment 58993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58993=edit QA followup test plan unchanged -- You are receiving this mail

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #10 from Josef Moravec --- prove t/db_dependent/api/v1/swagger/definitions.t says: # Failed test 'Columns is nullable in DB, not in swagger file for suggestion: publicationyear, suggesteddate'

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Josef Moravec changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What|Removed |Added Attachment #58100|0 |1

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What|Removed |Added Attachment #58098|0 |1

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #6 from Jiri Kozlovsky --- (In reply to Jiri Kozlovsky from comment #5) > Created attachment 58098 [details] [review] > Implemented suggestions REST API Basic test plan 1.part: 1. Login using account

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Mike changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What|Removed |Added Patch complexity|--- |Medium

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #5 from Jiri Kozlovsky --- Created attachment 58098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58098=edit Implemented suggestions REST API -- You are receiving this mail

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #3 from Katrin Fischer --- > > - collectiontitle: I think it's not clear in the interface what this is to > > be used for, maybe a question we should talk about first and then maybe > > choose a

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What|Removed |Added Status|NEW |In

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Jiri Kozlovsky changed: What|Removed |Added Blocks||16652