[Koha-bugs] [Bug 17428] REST API: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Zeno Tajoli changed: What|Removed |Added Text to go in the||This

[Koha-bugs] [Bug 17428] REST API: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Josef Moravec changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 17428] REST API: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Katrin Fischer changed: What|Removed |Added Summary|REST api: CRUD endpoint for

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #47 from Martin Renvoize --- Woop, woop! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #46 from Martin Renvoize --- (In reply to Jonathan Druart from comment #33) > Please try to separate indentation fixes and other changes. Oops, Sorry about that.. been working on another

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #45 from Tomás Cohen Arazi --- Created attachment 56812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56812=edit Bug 17428: (QA followup) Fix community site in swagger file

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56802|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56803|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56804|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56801|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56800|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Jonathan Druart changed: What|Removed |Added Attachment #56555|0

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #38 from Jonathan Druart --- Created attachment 56804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56804=edit Bug 17428: Remove warning Signed-off-by:

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Jonathan Druart changed: What|Removed |Added Attachment #56741|0

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Jonathan Druart changed: What|Removed |Added Attachment #56554|0

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Jonathan Druart changed: What|Removed |Added Attachment #56556|0

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #33 from Jonathan Druart --- Please try to separate indentation fixes and other changes. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #32 from Martin Renvoize --- Comment on attachment 56555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56555 Bug 17428: [REST] Cities swagger specification Review of

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #31 from Martin Renvoize --- Only the final [REST best practice Followup] needs signing off, would love to get some movement on this again before feature freeze ;) -- You are receiving

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Martin Renvoize changed: What|Removed |Added Attachment #56557|0

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #29 from Martin Renvoize --- Final followup, I was wrong in my last comment.. Swagger Validator is in fact doing the right thing it's just that we can't easily test against it. We are

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #28 from Martin Renvoize --- Created attachment 56724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56724=edit QA Followup - Fix failing test Failing test case is due

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Karam Qubsi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #27 from Martin Renvoize --- Please note, the last followup include a currently failing test case.. The failure is in the upstream library (::Swagger2), and I intend to attempt to fix it

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #24 from Martin Renvoize --- Created attachment 56557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56557=edit Bug 17428: Followup - More RESTfull handling of

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #23 from Martin Renvoize --- Created attachment 56556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56556=edit Bug 17428: [REST] Koha::REST::V1::Cities introduced

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #25 from Martin Renvoize --- Created attachment 56558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56558=edit Bug 17428: Remove debug statement -- You are receiving

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #26 from Martin Renvoize --- Created attachment 56559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56559=edit Bug 17428: QA Followup - Add readOnly marker to cityid

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #22 from Martin Renvoize --- Created attachment 56555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56555=edit Bug 17428: [REST] Cities swagger specification This

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Martin Renvoize changed: What|Removed |Added Attachment #56226|0

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #20 from Martin Renvoize --- Created attachment 56553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56553=edit Bug 174828: QA Followup - Add readOnly marker to cityid

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Martin Renvoize changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #19 from Jonathan Druart --- Created attachment 56548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56548=edit Bug 17428: Remove debug statement -- You are

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56545|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56544|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #17 from Jonathan Druart --- Created attachment 56544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56544=edit Bug 17428: Just some refactoring The idea is

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #18 from Jonathan Druart --- Created attachment 56545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56545=edit Bug 17428: Move the params check after the

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Martin Renvoize changed: What|Removed |Added Attachment #56314|0

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Lari Taskula changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Martin Renvoize changed: What|Removed |Added Blocks|17445

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Martin Renvoize changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #15 from Martin Renvoize --- (In reply to Jonathan Druart from comment #12) > Comment on attachment 56314 [details] [review] > Bug 174828: Followup - More RESTfull handling of endpoints >

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #14 from Jonathan Druart --- POST with non-existing id allows me to choose the id. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #12 from Jonathan Druart --- Comment on attachment 56314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56314 Bug 174828: Followup - More RESTfull handling of

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #11 from Martin Renvoize --- I have added a followup with some minor alterations to encourage Restful best practice a little more. The biggest change is to always expect full object for

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Martin Renvoize changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #10 from Martin Renvoize --- Created attachment 56314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56314=edit Bug 174828: Followup - More RESTfull handling of

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Claire Gravely changed: What|Removed |Added Attachment #56228|0

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Josef Moravec changed: What|Removed |Added Attachment #56190|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Josef Moravec changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Josef Moravec changed: What|Removed |Added Attachment #56191|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Josef Moravec changed: What|Removed |Added Attachment #56189|0 |1

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #5 from Claire Gravely --- (In reply to Claire Gravely from comment #4) > I'm getting raptor not found when pointing my browser at it! ignore me! -- You are receiving this mail because: You

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Claire Gravely changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Tomás Cohen Arazi changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 56191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56191=edit Bug 17428: [REST] Koha::REST::V1::Cities introduced This patch

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 56190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56190=edit Bug 17428: [REST] Cities swagger specification This patch adds

[Koha-bugs] [Bug 17428] REST api: CRUD endpoint for cities

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 56189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56189=edit Bug 17428: [REST] Cities endpoint unit tests This patch