[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #28 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #24) > Btw, this also appears to change the acq claim and order notices if I am > reading the code correctly, but it isn't

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Resolution|---

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Attachment #61774|0

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #27 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #23) > While the behaviour is a bit odd at the moment, the patch proposes a > behaviour change and should not be a sudden

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #26 from Katrin Fischer --- Marcel, did you see my comment? There is also already another bug for this: bug 18368. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Status|REOPENED

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #25 from Marcel de Rooy --- Created attachment 61774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61774=edit Bug 17866: [QA Follow-up] Add forgotten SetVersion call In db

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Katrin Fischer changed: What|Removed |Added Resolution|FIXED

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Jonathan Druart changed: What|Removed |Added Attachment #59043|0

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #20 from Jonathan Druart --- Created attachment 61584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61584=edit Bug 17866: [QA Follow-up] Add notification for

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #21 from Jonathan Druart --- Created attachment 61585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61585=edit Bug 17866: [QA Follow-up] Reword message for

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #18 from Marcel de Rooy --- Created attachment 61517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61517=edit Bug 17866: [QA Follow-up] Reword message for missing email

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #17 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #15) > Since I guess KohaAdminEmailAddress has to be filled, we can just get rid of > no_loggedin_user_email It probably

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #15 from Jonathan Druart --- Since I guess KohaAdminEmailAddress has to be filled, we can just get rid of no_loggedin_user_email -- You are receiving this mail because: You are

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #14 from Jonathan Druart --- Marcel, I am not sure to understand. Without the patch: If there is no 'From' it means that the logged in user does not have an email address

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #13 from Marcel de Rooy --- Created attachment 61473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61473=edit Bug 17866: [QA Follow-up] Add notification for changed sender

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #12 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > (In reply to Marcel de Rooy from comment #7) > > The claims.tt template correction is not in the scope of this report.

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #11 from Marcel de Rooy --- serials/claims.pl if ( $@ ) { $template->param(error_claim => $@); } elsif ( ref $err and exists $err->{error} ) { if ( $err->{error} eq

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #10 from Marcel de Rooy --- lateorders.tt seems fine if ( $@ ) { $template->param(error_claim => $@); } elsif ( ref $err and exists $err->{error} and $err->{error} eq "no_email"

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #9 from Marcel de Rooy --- (In reply to Gracie from comment #5) > Created attachment 59043 [details] [review] > Bug 17866: Change sender for serial claim notifications > > Currently, the From

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #7) > The claims.tt template correction is not in the scope of this report. I only > change the sender

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > Indeed that sounds like a wrong behaviour, but some are using it for ages. > Maybe we should warn them that the

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Gracie changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Gracie changed: What|Removed |Added Attachment #58721|0 |1 is

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Attachment #58677|0

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Attachment #58676|0

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #1 from Marcel de Rooy --- Created attachment 58676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58676=edit Bug 17866: Change sender for serial claim notifications

[Koha-bugs] [Bug 17866] Change sender for serial claim notifications

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What|Removed |Added Status|NEW