https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Martin Renvoize changed:
What|Removed |Added
Blocks||29490
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Martin Renvoize changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #68 from David Cook ---
(In reply to David Cook from comment #67)
> Going to double-check but this might be broken in 19.11...
I must've been mistaken as it looks fine now.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Nick Clemens changed:
What|Removed |Added
Resolution|---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Keywords|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #60 from Josef Moravec ---
Created attachment 74030
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74030=edit
Bug 17981: Better error handling
Signed-off-by: Kyle M Hall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #61 from Josef Moravec ---
Created attachment 74031
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74031=edit
Bug 17981: Move the divs to the top of the modal
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #64 from Josef Moravec ---
Created attachment 74034
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74034=edit
Bug 17981: (QA follow-up) Fix and update pod in svc/letters/get
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #63 from Josef Moravec ---
Created attachment 74033
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74033=edit
Bug 17981: Do not crash if the template is already using TT syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #59 from Josef Moravec ---
Created attachment 74029
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74029=edit
Bug 17981: Add a preview mode for notice templates
This patch is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #62 from Josef Moravec ---
Created attachment 74032
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74032=edit
Bug 17981: Remove uneeded module JS var
As we only support
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Josef Moravec changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Josef Moravec changed:
What|Removed |Added
Attachment #73201|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #58 from Josef Moravec ---
Created attachment 74028
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74028=edit
Bug 17981: Add a 'letter' param to GetPreparedLetter
This will
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #56 from Jonathan Druart
---
Created attachment 74025
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74025=edit
Bug 17981: Do not crash if the template is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Josef Moravec changed:
What|Removed |Added
Patch complexity|---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #52 from Jonathan Druart
---
Created attachment 73950
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73950=edit
Bug 17981: Better error handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #53 from Jonathan Druart
---
Created attachment 73951
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73951=edit
Bug 17981: Move the divs to the top of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #54 from Jonathan Druart
---
Created attachment 73952
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73952=edit
Bug 17981: Remove uneeded module JS var
As we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Attachment #73203|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Julian Maurice changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Bug 17981 depends on bug 17961, which changed state.
Bug 17961 Summary: TT syntax for notices - Prove we have an equivalent for our
historical custom syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Attachment #70300|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #49 from Jonathan Druart
---
Created attachment 73206
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73206=edit
Bug 17981: Remove uneeded module JS var
As we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #47 from Jonathan Druart
---
Created attachment 73204
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73204=edit
Bug 17981: Better error handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #48 from Jonathan Druart
---
Created attachment 73205
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73205=edit
Bug 17981: Move the divs to the top of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #46 from Jonathan Druart
---
Created attachment 73203
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73203=edit
Bug 17981: Add a preview mode for notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #45 from Jonathan Druart
---
Created attachment 73202
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73202=edit
Bug 17981: Add a 'letter' param to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Kyle M Hall changed:
What|Removed |Added
QA Contact|k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Kyle M Hall changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #42 from Jonathan Druart
---
Created attachment 70305
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70305=edit
Bug 17981: Remove uneeded module JS var
As we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #39 from Jonathan Druart
---
Created attachment 70302
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70302=edit
Bug 17981: Add a preview mode for notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #41 from Jonathan Druart
---
Created attachment 70304
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70304=edit
Bug 17981: Move the divs to the top of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #40 from Jonathan Druart
---
Created attachment 70303
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70303=edit
Bug 17981: Better error handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Attachment #67144|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #38 from Jonathan Druart
---
Created attachment 70301
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70301=edit
Bug 17981: Add a 'letter' param to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Keywords|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #36 from Jonathan Druart
---
Created attachment 67152
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67152=edit
Bug 17981: Remove uneeded module JS var
As we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #35 from Jonathan Druart
---
(In reply to Owen Leonard from comment #34)
> While rebasing Bug 18007 I noticed something in this update:
>
> In the JavaScript there are couple of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #34 from Owen Leonard ---
While rebasing Bug 18007 I noticed something in this update:
In the JavaScript there are couple of instances of a "module" variable which
doesn't appear to ever be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #31 from Jonathan Druart
---
Created attachment 67146
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67146=edit
Bug 17981: Add a preview mode for notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #33 from Jonathan Druart
---
Created attachment 67148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67148=edit
Bug 17981: Move the divs to the top of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Attachment #65701|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #32 from Jonathan Druart
---
Created attachment 67147
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67147=edit
Bug 17981: Better error handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #30 from Jonathan Druart
---
Created attachment 67145
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67145=edit
Bug 17981: Add a 'letter' param to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #27 from Kyle M Hall ---
Created attachment 65704
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65704=edit
Bug 17981: Better error handling
Signed-off-by: Kyle M Hall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #28 from Kyle M Hall ---
Created attachment 65705
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65705=edit
Bug 17981: Move the divs to the top of the modal
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Kyle M Hall changed:
What|Removed |Added
Attachment #63978|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #26 from Kyle M Hall ---
Created attachment 65703
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65703=edit
Bug 17981: Add a preview mode for notice templates
This patch is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #25 from Kyle M Hall ---
Created attachment 65702
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65702=edit
Bug 17981: Add a 'letter' param to GetPreparedLetter
This will
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #23 from Kyle M Hall ---
I also agree the current way of filling in the preview data is not user
friendly ; )
Hopefully it won't be too much harder to put those data needed in separate form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #22 from Kyle M Hall ---
> The possibilities:
> - Mock data to get fully working generated messages for any notice
> templates. For instance, for CHECKIN and CHECKOUT, the item is not
> checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #20 from Jonathan Druart
---
Created attachment 65689
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65689=edit
Bug 17981: Better error handling
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #21 from Jonathan Druart
---
Created attachment 65690
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65690=edit
Bug 17981: Move the divs to the top of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Attachment #63980|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #18 from Jonathan Druart
---
I do not think you can test this patch and all the dependencies on a sandbox.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #17 from Séverine Queune ---
I tested with the HOLD_SLIP notice on BibLibre's sandbox03.
When I applied bug 17975, a new box appeared to preview the notice for
"biblionumber|borrowernumber".
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #16 from Lee Jamison ---
Also, this is one of my favorite enhancements. Our clerk who handles all the
notices will be very grateful for this feature!
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Lee Jamison changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Kyle M Hall changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #14 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #13)
> Is this patch set in a testable state yet? I applied the patches to master
> and did not see the preview
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #13 from Kyle M Hall ---
Is this patch set in a testable state yet? I applied the patches to master and
did not see the preview button. Can you add a test plan?
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Tomás Cohen Arazi changed:
What|Removed |Added
Version|unspecified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #11 from Jonathan Druart
---
Created attachment 63981
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63981=edit
Bug 17981: Better error handling
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Attachment #59508|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #10 from Jonathan Druart
---
Created attachment 63980
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63980=edit
Bug 17981: Add a preview mode for notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #12 from Jonathan Druart
---
Created attachment 63982
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63982=edit
Bug 17981: Move the divs to the top of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #9 from Jonathan Druart
---
Created attachment 63979
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63979=edit
Bug 17981: Add a 'letter' param to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Séverine Queune changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Nick Clemens changed:
What|Removed |Added
Status|ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Owen Leonard changed:
What|Removed |Added
Blocks||18007
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #6 from Jonathan Druart
---
Created attachment 59524
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59524=edit
Bug 17981: Move the divs to the top of the modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #5 from Jonathan Druart
---
Created attachment 59514
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59514=edit
Bug 17981: Better error handling
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #1 from Jonathan Druart
---
Created attachment 59508
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59508=edit
Bug 17981: Move svc/letters to svc/letters/get
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #4 from Jonathan Druart
---
These patches will not apply due to the big dependency tree.
Use this remote branch instead: https://github.com/joubu/Koha/tree/bug_17981
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #3 from Jonathan Druart
---
Created attachment 59510
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59510=edit
Bug 17981: Add a preview mode for notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #2 from Jonathan Druart
---
Created attachment 59509
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59509=edit
Bug 17981: Add a 'letter' param to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED
96 matches
Mail list logo