[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #43 from Marcel de Rooy --- Template process failed: undef error - Cannot use "->find" in list context at /usr/share/koha/masterclone/Koha/Club.pm line 51. You will find a few with git grep

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #42 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.09. Picked the 16.11.x patch from here. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #39 from Katrin Fischer --- Sorry, first patch listed here and first patch pushed do both not apply? It also looks like a part of the patches has been reverted from master and the status here

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #38 from Jonathan Druart --- Only the first patch is needed for 16.11.x -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #37 from Jonathan Druart --- Created attachment 63832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63832=edit [16.11.x] Bug 18179: Update existing calls

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #36 from Jonathan Druart --- (In reply to Jonathan Druart from comment #32) > Created attachment 63109 [details] [review] > Bug 18179: Use borrower.category_type in

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Attachment #63109|0

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #35 from Jonathan Druart --- (In reply to Jonathan Druart from comment #31) > Created attachment 63108 [details] [review] > Bug 18179: Update 1 occurrence in moremember.pl This

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Attachment #63108|0

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Attachment #62657|0

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Attachment #62656|0

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Attachment #62879|0

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #31 from Jonathan Druart --- Created attachment 63108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63108=edit Bug 18179: Update 1 occurrence in moremember.pl

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #32 from Jonathan Druart --- Created attachment 63109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63109=edit Bug 18179: Use borrower.category_type in

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #30 from Jonathan Druart --- Created attachment 63107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63107=edit Bug 18179: Update 1 occurrence in

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #28 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #26) > Same include: > > [%- IF borrower.category.category_type == 'I' %] > > [%- IF category_type == 'I'

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #27 from Marcel de Rooy --- Jonathan: If you move the first patch somewhere else and remove the category change, please update to Passed QA. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #26 from Marcel de Rooy --- Same include: [%- IF borrower.category.category_type == 'I' %] [%- IF category_type == 'I' %] I am having the feeling that it should be borrower.category_type when

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #24 from Jonathan Druart --- Kyle, I think the last 3 patches should be pushed before the release. We could move the croak to its own bug report if you do not feel confident with

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #22 from Jonathan Druart --- *** Bug 18510 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #20 from Jonathan Druart --- Created attachment 62880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62880=edit Bug 18179: Update 1 occurrence in moremember.pl

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #19 from Jonathan Druart --- Created attachment 62879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62879=edit Bug 18179: Update 1 occurrence in

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #18 from Jonathan Druart --- This patch should not have been reverted: Bug 18179: Update existing calls It fixes the original issues. Where do you get errors? -- You are

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Kyle M Hall changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 M. Tompsett changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Nick Clemens changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Nick Clemens changed: What|Removed |Added Attachment #62321|0 |1

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Nick Clemens changed: What|Removed |Added Attachment #62319|0 |1

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Nick Clemens changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron changed: What|Removed |Added Attachment #62305|0 |1 is

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Marc Véron changed: What|Removed |Added Attachment #62304|0 |1 is

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Severity|normal

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #10 from Jonathan Druart --- @RMaints, I would not backport the first patch, but the second one is safe ("Update existing calls"). -- You are receiving this mail because: You

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 --- Comment #9 from Jonathan Druart --- Created attachment 62305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62305=edit Bug 18179: Update existing calls This patch

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Attachment #62218|0

[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 18179] Koha::Objects-find should not be called in list context

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What|Removed |Added Summary|Patron