[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Marcel de Rooy changed: What|Removed |Added Attachment #64097|0 |1 is obsolete|

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rece

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 M. Tompsett changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are rec

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 M. Tompsett changed: What|Removed |Added Attachment #61196|0 |1 is obsolete|

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiv

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 --- Comment #7 from M. Tompsett --- (In reply to M. Tompsett from comment #5) > Ryan Higgins P.P.S. 10ish years ago. I suspect all of these are cut and paste from early in the project. -- You are receiving this mail because: You a

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 --- Comment #6 from M. Tompsett --- (In reply to Olli-Antti Kivilahti from comment #4) > This patch is just cosmetic and seems to have no impact on test results. Actually, while generally true, I think a microscopic time gain would

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comm

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 --- Comment #4 from Olli-Antti Kivilahti --- (In reply to Marc Véron from comment #3) > What about the tons of *.t files with 1; as last line? > > git grep '^1;' -- *.t This patch is just cosmetic and seems to have no impact on tes

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #3

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 --- Comment #2 from Olli-Antti Kivilahti --- Initially thought the test fails because of this when ran via prove, but it was maybe something leaking between test cases. -- You are receiving this mail because: You are watching all b

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 61196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61196&action=edit Bug 18292 - t/db_dependent/Circulation.t doesn't need to return 1; -- You are

[Koha-bugs] [Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

2017-03-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292 Olli-Antti Kivilahti changed: What|Removed |Added Summary|t/db_dependent/Circulation. |t/db_dependent/Circul