[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #47 from David Cook --- This change causes the regression reported in Bug 27565. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailin

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Cook changed: What|Removed |Added Blocks||27565 CC|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Joy Nelson changed: What|Removed |Added Status|Pushed to master|RESOLVED CC|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Nind changed: What|Removed |Added Text to go in the||This enhancement to the r

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #45 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing li

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #44 from Julian Maurice --- (In reply to Jonathan Druart from comment #43) > Do you agree with that patch? Yep. I haven't tested it, but patch looks good. -- You are receiving this mail because: You are watching all bu

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #43 from Jonathan Druart --- (In reply to Julian Maurice from comment #35) > (In reply to Jonathan Druart from comment #33) > > This is still valid. > > Not anymore ;) Awesome Julian, thanks for that follow-up! (In re

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #42 from Jonathan Druart --- Created attachment 99162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99162&action=edit Bug 18433: Display the number of selected items Signed-off-by: Jonathan Druart

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rec

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #41 from Jonathan Druart --- Created attachment 99161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99161&action=edit Bug 18433: Add missing filter Signed-off-by: Jonathan Druart -- You are receiv

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #40 from Jonathan Druart --- Created attachment 99160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99160&action=edit Bug 18433: Remember item search results selected rows in session storage Session

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What|Removed |Added Attachment #99123|0 |1 is obsolete|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Nind changed: What|Removed |Added CC||da...@davidnind.com

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Nind changed: What|Removed |Added Attachment #97479|0 |1 is obsolete|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 David Nind changed: What|Removed |Added Attachment #95380|0 |1 is obsolete|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #35 from Julian Maurice --- (In reply to Jonathan Druart from comment #33) > This is still valid. Not anymore ;) -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #34 from Julian Maurice --- Created attachment 97479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97479&action=edit Bug 18433: Remember item search results selected rows in session storage Session st

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #33

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Attachment #62472|0 |1 is obsolete|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #32

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #30 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #29) > (In reply to Fridolin SOMERS from comment #28) > > Maybe this should be splitted into one bug changing > > Koha::Template::Plugin::AuthorisedVa

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Fridolin SOMERS changed: What|Removed |Added Depends on||9573 Referenced Bugs: h

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #29 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #28) > Maybe this should be splitted into one bug changing > Koha::Template::Plugin::AuthorisedValues and this bug focusing on changes in > item sear

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #27 from Owen Leonard --- I agree with Jonathan that the best behavior would be to allow the user to select items on multiple pages and have it remember across pages. I say this not knowing how difficult it might be to im

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What|Removed |Added CC||oleon...@myacpl.org --- C

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #25 from Julian Maurice --- (In reply to Jonathan Druart from comment #24) > Hum, I get "Template process failed: undef error - The method biblioitem is > not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm l

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Bug 18433 depends on bug 18459, which changed state. Bug 18459 Summary: Add the Koha::Item->biblioitem method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18459 What|Removed |Added

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #23 from Julian Maurice --- Squashed all patches for readability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Attachment #62388|0 |1 is obsolete|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #21

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Attachment #62415|0 |1 is obsolete|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #19 from Julian Maurice --- Created attachment 62449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62449&action=edit Bug 18433: Remove Koha::AuthorisedValueCategories::find_by_koha_field Use Koha::Aut

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #18 from Julian Maurice --- (In reply to Jonathan Druart from comment #17) > What you actually want is > Koha::AuthorisedValues->get_description_by_koha_field. Yes, exactly! :-) Thanks -- You are receiving this mail be

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #17

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #15 from Jonathan Druart --- Created attachment 62416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62416&action=edit Bug 18433: Add new subroutine GetDescriptionByKohaField to AuthorisedValues TT plu

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #14 from Jonathan Druart --- Created attachment 62415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62415&action=edit Bug 18433: Use existing pattern for find_by_koha_field -- You are receiving this

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #16 from Jonathan Druart --- Created attachment 62417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62417&action=edit Bug 18433: Use the TT plugin for itemsearch_item.json.inc TODO: includes/catalogu

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off -- You are rec

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #13 from Julian Maurice --- Created attachment 62390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62390&action=edit Bug 18433: Remove indentation from CSV output -- You are receiving this mail becau

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #12 from Julian Maurice --- Rebased patches on top of bug 18459 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Depends on||18459 Referenced Bugs: h

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Attachment #62358|0 |1 is obsolete|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Attachment #62181|0 |1 is obsolete|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Status|Signed Off |Failed QA -- You are rece

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #9 from Jonathan Druart --- When I export in CSV there are 2 spaces at the beginning of each line. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #8 from Jonathan Druart --- Koha::Item->biblioitem should be moved to its own bug report and covered by tests. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off -- You are rec

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #7 from Julian Maurice --- Created attachment 62358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62358&action=edit Bug 18433: QA fixes - Use snake_case for Koha::AuthorisedValueCategories method nam

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #6 from Julian Maurice --- > (In reply to Jonathan Druart from comment #4) > > You should also use Text::CSV to build the CSV content. > > It's not really CSV, just a simple text file with one barcode per line, so > what

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #5 from Julian Maurice --- (In reply to Jonathan Druart from comment #3) > Something sounds wrong here, I'd suggest that GetCategoryByKohaField should > be replaced with Koha::AuthorisedValues->search_by_koha_field->categ

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #4 from Jonathan Druart --- You should also use Text::CSV to build the CSV content. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs ma

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Bug 18433 depends on bug 18394, which changed state. Bug 18394 Summary: Add an option to item search to export a barcodes file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394 What|Removed

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Marc Véron changed: What|Removed |Added Patch complexity|--- |Small patch Status

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Marc Véron changed: What|Removed |Added Attachment #62170|0 |1 is obsolete|

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 18433] Allow to select results to export in item search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 --- Comment #1 from Julian Maurice --- Created attachment 62170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62170&action=edit Bug 18433: Allow to select results to export in item search This adds a column of ch