[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Mason James changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy changed: What|Removed |Added Attachment #65495|0

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #33 from Marcel de Rooy --- (In reply to Marc Véron from comment #29) > (In reply to Marcel de Rooy from comment #28) > > From an earlier comment: > > Note that the trailing IF does not increase

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Owen Leonard changed: What|Removed |Added Attachment #65494|0 |1

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron changed: What|Removed |Added Status|ASSIGNED|Needs Signoff

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #30 from Marc Véron --- Created attachment 65494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65494=edit Bug 18649: (New patch) Translatability: Get rid of tt directive in translation

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron changed: What|Removed |Added Attachment #64079|0 |1 is

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron changed: What|Removed |Added Status|Failed QA |ASSIGNED ---

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #27 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #26) > I will look at this one tomorrow during QA. Sorry, it became manana (issue with issues). Still on my list now ! --

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #26 from Marcel de Rooy --- I will look at this one tomorrow during QA. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #25 from Marc Véron --- (In reply to Marcel de Rooy from comment #24) > I would opt for pushing the two patches as they were in PQA. > Not allowing the zero should be solved on another report. > Showing

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #24 from Marcel de Rooy --- I would opt for pushing the two patches as they were in PQA. Not allowing the zero should be solved on another report. Showing the zero here is fine with me. No need

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #23 from Marc Véron --- Where do we go from here? - The original aim of this bug is not to expose the tt directive to translators (without changing the original behaviour). It is kind of string patch. -

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #22 from Jonathan Druart --- It is wrong to store 0 and it is wrong to display an empty string when 0 is stored. I did not say your last patch modified that, just that it should

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #21 from Marc Véron --- (In reply to Jonathan Druart from comment #20) > Sounds like there is something wrong with the "0", but if it's a bug we must > fix it somewhere else. I do not think that there is

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #20 from Jonathan Druart --- Sounds like there is something wrong with the "0", but if it's a bug we must fix it somewhere else. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron changed: What|Removed |Added Status|Failed QA |Needs Signoff

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron changed: What|Removed |Added Attachment #64049|0 |1 is

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #18 from Marc Véron --- Created attachment 64079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64079=edit Bug 18649: (Restored earlier version) Translatability: Get rid of tt directive

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #17 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #15) > There is a change in the behaviour: > Before the patch, if the enrolment period == 0, the input was empty, now it >

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #16 from Marc Véron --- (In reply to Jonathan Druart from comment #15) > There is a change in the behaviour: > Before the patch, if the enrolment period == 0, the input was empty, now it > shows '0'. Ah,

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #14 from Marcel de Rooy --- Applied the second patch to the first. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy changed: What|Removed |Added Attachment #63724|0

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron changed: What|Removed |Added Attachment #63757|0 |1 is

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #12 from Marc Véron --- Created attachment 63937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63937=edit Bug 18649: [QA followup] Simplify If and remove chomps in admin/categories.tt

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #11 from Marc Véron --- Oh... Hmm... That's true for the original line as well... -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #10 from Marcel de Rooy --- (In reply to Marc Véron from comment #9) > (In reply to Marcel de Rooy from comment #8) > > Marc, > > I understand your explanation, but you did not respond to my

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #9 from Marc Véron --- (In reply to Marcel de Rooy from comment #8) > Marc, > I understand your explanation, but you did not respond to my question about > the trailing IF. Ah, sorry, I must have skipped

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #8 from Marcel de Rooy --- Marc, I understand your explanation, but you did not respond to my question about the trailing IF. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #7 from Marc Véron --- Created attachment 63757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63757=edit Bug 18649: [QA followup] Remove chomps in admin/categories.tt As of comment

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #6 from Marc Véron --- (In reply to Marcel de Rooy from comment #5) > Hi Marc, > > What is the advantage of > value="[%- category.enrolmentperiod IF category.enrolmentperiod -%]" > above e.g. >

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #4 from Marc Véron --- (In reply to Aleisha Amohia from comment #3) (...) > > Patch works as expected for me - also this is a really great way to do > this kind of fix! We should have this all over Koha.

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Aleisha Amohia changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Aleisha Amohia changed: What|Removed |Added Attachment #63626|0 |1

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |ve...@veron.ch

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron changed: What|Removed |Added Status|NEW |Needs Signoff

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #2 from Marc Véron --- Created attachment 63626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63626=edit Bug 18649: Translatability: Get rid of tt directive in translation for

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #1 from Marc Véron --- Translation tool shows [% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %] for en/modules/admin/categories.tt and

[Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc Véron changed: What|Removed |Added Summary|Translatability: Get rid of