https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to Stable|RESOLVED
Resoluti
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
--- Comment #32 from Jonathan Druart
---
Created attachment 74247
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74247&action=edit
Bug 18725: Test return values of make_column_dirty
--
You are receiving this mai
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
--- Comment #31 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #30)
> Marcel, this change makes sense to me.
> However we need to return a Koha::Object instead of DBIC one, otherwise we
> could have weird side-effe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
--- Comment #30 from Jonathan Druart
---
Marcel, this change makes sense to me.
However we need to return a Koha::Object instead of DBIC one, otherwise we
could have weird side-effects when chaining the calls.
Kyle, would you agree
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
Marcel de Rooy changed:
What|Removed |Added
Status|In Discussion |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
--- Comment #28 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #27)
> If the tests is bad I'd prefer not to have them. It let us think the changes
> are covered but they are not.
>
> I tried this:
> https://dev.my
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
Marcel de Rooy changed:
What|Removed |Added
Attachment #73750|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |In Discussion
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
--- Comment #27 from Jonathan Druart
---
If the tests is bad I'd prefer not to have them. It let us think the changes
are covered but they are not.
I tried this:
https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
--- Comment #26 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #25)
> (In reply to Marcel de Rooy from comment #24)
> > (In reply to Jonathan Druart from comment #23)
> > > Why not simply:
> > >
> > > return unl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
--- Comment #25 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #24)
> (In reply to Jonathan Druart from comment #23)
> > Why not simply:
> >
> > return unless $message_object->status('pending')->store;
>
> Tha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
--- Comment #24 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #23)
> Why not simply:
>
> return unless $message_object->status('pending')->store;
That does not trigger an update unless you mark a field as 'dir
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
--- Comment #23 from Jonathan Druart
---
I do not understand the trick:
1065 # If this fails the database is unwritable and we won't manage to
send a message that continues to be marked 'pending'
1066 $message_objec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
Tomás Cohen Arazi changed:
What|Removed |Added
Summary|Process_message_queue sends |process_message_queue.pl
17 matches
Mail list logo
