https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
David Nind changed:
What|Removed |Added
Keywords||Manual
Text to go in the|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||28318
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Jonathan Druart changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Jonathan Druart changed:
What|Removed |Added
Keywords||release-notes-needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Jonathan Druart changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Severity|enhancement |new feature
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #62 from Lucas Gass ---
enhancement will not be backported to 20.05.x
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #60 from Jonathan Druart
---
Follow-up pushed to master!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #59 from Martin Renvoize ---
The attached followup should fix the related failing test on master.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #58 from Martin Renvoize ---
Created attachment 108733
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108733=edit
Bug 19036: (follow-up) Test credits should be credits
A series of accountlines added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Jonathan Druart changed:
What|Removed |Added
Version(s)||20.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #57 from Jonathan Druart
---
Pushed to master for 20.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #56 from Martin Renvoize ---
Fixed the test.. there were two minor issues with the construction meaning that
we would not reach the exception (missing interface and amount params in the
call to new).
I've also added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #55 from Martin Renvoize ---
Created attachment 108587
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108587=edit
Bug 19036: (follow-up) Improve test output
This patch adds proper detail to the test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #54 from Jonathan Druart
---
I've added a missing test but it does not pass. Could you have a look?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #53 from Jonathan Druart
---
Created attachment 108525
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108525=edit
Bug 19036: Add missing test
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #52 from Katrin Fischer ---
I a little torn still about the terminology, but not enough to block this. I
have retested the table layout and the added POS functionality.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Attachment #107877|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Attachment #107872|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Attachment #106280|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Attachment #106281|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Attachment #106279|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Attachment #106767|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Medium patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Attachment #106278|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Attachment #107875|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #43 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #41)
> (In reply to Martin Renvoize from comment #36)
> > (In reply to Katrin Fischer from comment #33)
> > > Hm, it wasn't the missed db update,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #42 from Martin Renvoize ---
Created attachment 107875
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107875=edit
Bug 19036: (QA follow-up) Add credit_number handling to POS
This patch adds the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #41 from Jonathan Druart
---
(In reply to Martin Renvoize from comment #36)
> (In reply to Katrin Fischer from comment #33)
> > Hm, it wasn't the missed db update, because as I wrote... I have the same
> > output of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #40 from Martin Renvoize ---
I also think the credit number should be added to the 'register details' page
that lists transactions too.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #39 from Martin Renvoize ---
Should we be hiding the 'credit number' column by default in fact... we don't
enable the feature by default so why expose the empty field in the table?
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #38 from Martin Renvoize ---
Fixed the table issue in the attached followup.
As for terminology.. this identifier is only added to 'credits' to the 'debits'
terminology discussion it mute at this time. As for the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #37 from Martin Renvoize ---
Created attachment 107872
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107872=edit
Bug 19036: (QA follow-up) Fix 'out-by-one' error on table
This patch fixes the total
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #36 from Martin Renvoize ---
(In reply to Katrin Fischer from comment #33)
> Hm, it wasn't the missed db update, because as I wrote... I have the same
> output of master - but it claims all tests successful. Are we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #33 from Katrin Fischer ---
Hm, it wasn't the missed db update, because as I wrote... I have the same
output of master - but it claims all tests successful. Are we provoking the db
error intentionally?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Status|BLOCKED |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #31 from Martin Renvoize ---
Created attachment 106767
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106767=edit
Bug 19036: (QA follow-up) Fix test plan
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #30
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
QA Contact|martin.renvoize@ptfs-europe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #28 from Martin Renvoize ---
Created attachment 106281
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106281=edit
Bug 19036: DBIC Schema Updates
Dumped schema updates + manual addition of boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #27 from Martin Renvoize ---
Created attachment 106280
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106280=edit
Bug 19036: (QA follow-up) Use Koha::DateUtils
This patch replaced raw DateTime->now
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Attachment #101897|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Attachment #101896|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_20_11_target|
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_20_05_candidate,|rel_20_11_target
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_20_05_target
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Keywords||RM_priority
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Attachment #101549|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Attachment #101550|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Julian Maurice changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #20 from Julian Maurice ---
Created attachment 101550
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101550=edit
Bug 19036: Add ability to enable credit number for only some credit types
This feature
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Julian Maurice changed:
What|Removed |Added
Attachment #99676|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Julian Maurice changed:
What|Removed |Added
Status|ASSIGNED|In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Julian Maurice changed:
What|Removed |Added
Status|Failed QA |ASSIGNED
--- Comment #17
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #15 from Martin Renvoize ---
(In reply to Julian Maurice from comment #14)
> > Hmm, I slightly wonder if it's a good idea to allow passing
> > credit_number and allowing it to override the AudoCreditNumber
> > setting..
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #14 from Julian Maurice ---
> Hmm, I slightly wonder if it's a good idea to allow passing
> credit_number and allowing it to override the AudoCreditNumber
> setting.. to me if it's set then we should throw an Exception
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #13 from Martin Renvoize ---
Note to self.. I'd like to add support for cash_register_id + timstamp as an
option for numbering.. I'll post that as a followup once we've worked through
my other comments ;)
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #12 from Martin Renvoize ---
Comment on attachment 99676
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99676
Bug 19036: Add ability to auto generate a number for account credits
Review of attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Michal Denar changed:
What|Removed |Added
Attachment #99303|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Michal Denar changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #10 from Michal Denar ---
Hi Julian,
it's clear. I'll try to test it again soon.
Thank You.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #9 from Julian Maurice ---
(In reply to Michal Denar from comment #8)
> Hi Julian,
> I've tested bug. All works great, but I'm not able to add account credit
> number on print slip. It generate just empty space. But
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #8 from Michal Denar ---
Hi Julian,
I've tested bug. All works great, but I'm not able to add account credit number
on print slip. It generate just empty space. But maybe it's my mistake. Can you
double-check this part?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Julian Maurice changed:
What|Removed |Added
Attachment #99302|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Julian Maurice changed:
What|Removed |Added
Attachment #99301|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #5 from Julian Maurice ---
Created attachment 99301
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99301=edit
Bug 19036: Add ability to auto generate a number for account credits
In some areas it's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Julian Maurice changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Component|Patrons |Fines and fees
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #4 from Katrin Fischer ---
Ah, also accountlines_id is on the wrong level I think - we want to number the
payments - a payment might include changes to multiple accountlines.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #3 from Katrin Fischer ---
As I understood this is a legal requirement in some countries, possibly
relating to anti-corruption laws, where they have to keep a tight track of all
the monetary transactions. I believe the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
--- Comment #2 from Martin Renvoize ---
Do these actually need to be sequential?
At this point we could use the accountlineid for the 'payment' type accountline
that's associated with the slip.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Martin Renvoize changed:
What|Removed |Added
Blocks||13985
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Indranil Das Gupta changed:
What|Removed |Added
CC||indr...@l2c2.co.in
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036
Katrin Fischer changed:
What|Removed |Added
Summary|Numer payment receipts /
89 matches
Mail list logo