[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Fridolin SOMERS changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #28 from Jonathan Druart --- Last patch pushed to master -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #27 from Jonathan Druart --- Created attachment 68923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68923=edit Bug 19176: (QA follow-up) few cosmetic changes

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Jonathan Druart changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #23 from Julian Maurice --- (In reply to Jonathan Druart from comment #21) > Hi Julian, > Thanks for taking care of this. > I am stuck and I do not have more time to spend on this. Do you

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #22 from Julian Maurice --- Created attachment 68848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68848=edit Bug 19176: Fix how t::lib::Dates::compare handle timezone --

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #21 from Jonathan Druart --- Hi Julian, Thanks for taking care of this. I am stuck and I do not have more time to spend on this. Do you have something to suggest? If we do not

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Julian Maurice changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #19 from Josef Moravec --- Created attachment 68450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68450=edit Bug 19176: followup - fix POD in t/lib/Dates.pm Signed-off-by:

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Josef Moravec changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #18 from Josef Moravec --- Created attachment 68449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68449=edit Bug 19176: Reduce the number of seconds to 5 Signed-off-by: Josef

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Josef Moravec changed: What|Removed |Added Attachment #68413|0 |1

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #16 from Jonathan Druart --- (In reply to M. Tompsett from comment #11) > Typo: comparison. Fixed. > ::: t/lib/Dates.pm > @@ +19,5 @@ > > +my $dt_expected =

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #15 from Jonathan Druart --- Created attachment 68414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68414=edit Bug 19176: Reduce the number of seconds to 5

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Jonathan Druart changed: What|Removed |Added Attachment #68082|0

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #13 from Jonathan Druart --- Created attachment 68412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68412=edit Bug 19176: Reduce the number of seconds to 5

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Magnus Enger changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #11 from M. Tompsett --- Comment on attachment 68082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68082 Bug 19176: Compare the number of seconds when comparing dates in tests

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #10 from Jonathan Druart --- Thanks Julian, excellent remarks. I rewrote the patch and add tests for the new module. Switch back to Needs Signoff. -- You are receiving this

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Jonathan Druart changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Jonathan Druart changed: What|Removed |Added Attachment #67322|0

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Julian Maurice changed: What|Removed |Added QA

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #8 from Julian Maurice --- ... and it doesn't consider timezone. my $dt = DateTime->new( year => 2017, month => 1, day => 1, hour => 1, minute => 1, second => 0,

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Julian Maurice changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 David Bourgault changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 David Bourgault changed: What|Removed |Added Attachment #66563|0

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #4 from Jonathan Druart --- (In reply to Marc Véron from comment #2) > Wouldn't it be safer to calculate the delta and pass the test OK if delta > <60 sec? > (Or even introduce a

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Jonathan Druart changed: What|Removed |Added Attachment #66493|0

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 --- Comment #1 from Jonathan Druart --- Created attachment 66493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66493=edit Bug 19176: Truncate to minutes when comparing

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED