[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Fridolin SOMERS changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #30 from Jonathan Druart --- Owen, you modified the original patch to use a POST (form) instead of a GET (link), could you explain why? It makes the button hard to locate from

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Nick Clemens changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Josef Moravec changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Josef Moravec changed: What|Removed |Added Attachment #69736|0 |1

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #26 from Owen Leonard --- Created attachment 69736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69736=edit Bug 19560: Correctly escape branchcode in admin/branches.pl

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Attachment #69735|0 |1

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Attachment #69700|0 |1

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #24 from Jonathan Druart --- (In reply to Josef Moravec from comment #23) > looks like this is bug in current master... Yes, definitely -- You are receiving this mail because:

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #23 from Josef Moravec --- Comment on attachment 69700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69700 Bug 19560: Correctly escape branchcode in admin/branches.pl Review

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Attachment #69701|0 |1

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Attachment #69700|1 |0

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Attachment #69700|0 |1

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Status|In Discussion |Signed

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Attachment #69490|0 |1

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Attachment #69130|0 |1

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #18 from Josef Moravec --- (In reply to Jonathan Druart from comment #17) > (In reply to Owen Leonard from comment #16) > > Should we still reject brachcodes with whitespace characters? > > Yes

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #17 from Jonathan Druart --- (In reply to Owen Leonard from comment #16) > Should we still reject brachcodes with whitespace characters? Yes I think so (for command line

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #16 from Owen Leonard --- Should we still reject brachcodes with whitespace characters? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Josef Moravec changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #14 from Jonathan Druart --- (In reply to Owen Leonard from comment #12) > Is it a limitation of branches.pl that it fails to accept a string like this? > >

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Jonathan Druart changed: What|Removed |Added Attachment #69423|0

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #12 from Owen Leonard --- As far as I can tell, JavaScript regular expressions will not recognize non-ascii "word" characters as such, and thus client-side validation can't work here unless we

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #11 from Joy Nelson --- Ah! I see. Yes, escaping or restricting would work. I can't say I have a preference in the matter. Thanks! joy (In reply to Jonathan Druart from comment #10) >

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #10 from Jonathan Druart --- Joy, What I tried to say is: If we escape correctly the variable, we will not have problem to delete a library with branchcode=A, see the follow-up.

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #9 from Jonathan Druart --- Created attachment 69423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69423=edit Bug 19560: Correctly escape branchcode in

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #8 from Joy Nelson --- Jonathon, I encountered this because a library was adding a branch for "Art & Architecture" as A When they decided to go with a different naming convention, they were

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Blocks|19608 |

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Blocks||19608

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Nick Clemens changed: What|Removed |Added Attachment #69097|0 |1

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Nick Clemens changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 David Bourgault changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 David Bourgault changed: What|Removed |Added Attachment #69062|0

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Blocks||19607

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 --- Comment #1 from Owen Leonard --- Created attachment 69062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69062=edit Bug 19560: Unable to delete library when branchcode contains special

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560 Owen Leonard changed: What|Removed |Added Summary|Unable to delete branch |Unable