[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #32 from Marcel de Rooy --- Back into PQA, no strong attachment to the second patch, just preferential of course ;) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #31 from Marcel de Rooy --- Created attachment 75260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75260=edit Bug 19792: Few minor fixes - No string extrapolation needed on

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #30 from Marcel de Rooy --- Created attachment 75259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75259=edit Bug 19792: (QA follow-up) Move anonymous sub out of GetHierarchy

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Attachment #74983|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Charles Farmer changed: What|Removed |Added Attachment #71989|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Charles Farmer changed: What|Removed |Added Attachment #71990|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Charles Farmer changed: What|Removed |Added Attachment #71991|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #28 from Jon Knight --- Oh, and whilst signing off again, I noted the speed increase running the tests. Not huge but there is one even on a system with limited budgets. Without these patches:

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Jon Knight changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #25 from Jon Knight --- Created attachment 74983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74983=edit [SIGNED-OFF] Bug 19792 - Perf. boost for GetBudgetHierarchy This

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #27 from Jon Knight --- Created attachment 74985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74985=edit [SIGNED-OFF] Bug 19792: Few minor fixes - No string extrapolation

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #26 from Jon Knight --- Created attachment 74984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74984=edit [SIGNED-OFF] Bug 19792: (QA follow-up) Move anonymous sub out of

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Charles Farmer changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 David Bourgault changed: What|Removed |Added

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Charles Farmer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Charles Farmer changed: What|Removed |Added Attachment #70306|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Charles Farmer changed: What|Removed |Added Attachment #70296|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Charles Farmer changed: What|Removed |Added Attachment #70298|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #19 from Nicolas Legrand --- I just tried NYTProf on orderreceive.pl which loaded twice GetBudgetHierarchy with a budget id. orderreceive without 19792 ran in 6.05s, 38.9ms is spent in

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #18 from Nicolas Legrand --- (In reply to Blou from comment #16) > (In reply to Nicolas Legrand from comment #14) [...] > > Prompt correction? As in simple & fast? There's nothing quick and

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #17 from Nicolas Legrand --- I did a benchmark on a 16.11.00 with NYTProf, with and without the patch, with GetBudgetHierarchy being called with arguments. We have 517 aqbudgets lines.

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #16 from Blou --- (In reply to Nicolas Legrand from comment #14) > Well, what about a prompt correction such as : > > - by default on acquisition home, GetBudgetHierarchy loads the last

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #15 from Blou --- > How many budgets/funds? What are the performances before/after this patch? Over 500 aqbudgets. Performance went from 30+ seconds to less than 1 second. -- You are

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Séverine Queune changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Nicolas Legrand changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #13 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #11) > 1. I prefer the version without Marcel's patch (especially because of the > size of the parameter list) I have seen

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #12 from Jonathan Druart --- Created attachment 70306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70306=edit Bug 19792: Few minor fixes - No string

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Attachment #70297|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Attachment #69960|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #9 from Marcel de Rooy --- Created attachment 70297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70297=edit Bug 19792: (QA follow-up) Move anonymous sub out of GetHierarchy

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #7 from Marcel de Rooy --- (In reply to David Bourgault from comment #6) > I don't think I can move the recursive sub out of GetBudgetHierarchy, since > it calls variables local to that

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 David Bourgault changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Jon Knight changed: What|Removed |Added Attachment #69702|0 |1

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Jon Knight changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 jmbroust changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #3 from David Bourgault --- >From Bug 19586 (codebase is essentially the same): > I used the followup patch with CCSR to cut the DB calls from 3 to 5. > Display idle time went from 30+

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 David Bourgault changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #1 from David Bourgault --- Created attachment 69702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69702=edit Bug 19792 - Perf. boost for GetBudgetHierarchy This patches

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 David Bourgault changed: What|Removed |Added Status|NEW