[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #26 from Jonathan Druart --- There is something terribly wrong with this test file, the cronjob script is run outside the transaction and so changes are effective. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Nick Clemens changed: What|Removed |Added Blocks||24268 Referenced Bugs:

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Jonathan Druart changed: What|Removed |Added Blocks||24064 Referenced Bugs:

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Magnus Enger changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Margaret changed: What|Removed |Added Version(s)||19.05 released in|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement add the

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added Attachment #80902|0 |1 is obsolete|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added Attachment #80903|0 |1 is obsolete|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize changed: What|Removed |Added Attachment #80901|0 |1 is obsolete|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #22 from Martin Renvoize --- Created attachment 86384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86384=edit Bug 20478: (QA follow-up) Make test more standard Signed-off-by: Martin Renvoize --

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Magnus Enger changed: What|Removed |Added Attachment #73722|0 |1 is obsolete|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Magnus Enger changed: What|Removed |Added Attachment #73723|0 |1 is obsolete|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Magnus Enger changed: What|Removed |Added Attachment #80867|0 |1 is obsolete|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #14 from Andreas Jonsson --- Created attachment 80867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80867=edit Bug 20478: Have the cronjob script advance_notices.pl send digest messages per branch.

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Andreas Jonsson changed: What|Removed |Added Attachment #73724|0 |1 is obsolete|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #12 from Magnus Enger --- I followed the test plan, and the script works as it should. But the new --digest-per-branch parameter needs to be added to the POD in the script, along witht the other options. If you provide a

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no ---

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andreas.jons...@kreablo.se

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #10 from Katrin Fischer --- QA script passes now - leaving the sign-off to someone else, so I have the option to QA later. -- You are receiving this mail because: You are the assignee for the

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #9 from Katrin Fischer --- > Also, I've added the command line parameter '-digest-per-branch' while > preserving the original behavior as default. But isn't the expected > behavior to receive

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Andreas Jonsson changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #7 from Andreas Jonsson --- Created attachment 73724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73724=edit Bug 20478: Have the cronjob script advance_notices.pl send

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #6 from Andreas Jonsson --- Created attachment 73723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73723=edit Bug 20478: Refactor to remove code duplication. -- You are

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #5 from Andreas Jonsson --- Created attachment 73722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73722=edit Bug 20478: Add unit test for advance_notices.pl cronjob. --

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Andreas Jonsson changed: What|Removed |Added Attachment #73310|0

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Andreas Jonsson changed: What|Removed |Added Attachment #73309|0

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Andreas Jonsson changed: What|Removed |Added Attachment #73308|0

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #3 from Andreas Jonsson --- Created attachment 73310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73310=edit Bug 20478: Have the cronjob script advance_notices.pl send

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #1 from Andreas Jonsson --- Created attachment 73308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73308=edit Bug 20478: Add unit test for advance_notices.pl cronjob. --

[Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #2 from Andreas Jonsson --- Created attachment 73309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73309=edit Bug 20478: Refactor to remove code duplication. -- You are