[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com ---

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #19 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Katrin Fischer changed: What|Removed |Added Attachment #99877|0 |1 is obsolete|

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Katrin Fischer changed: What|Removed |Added Attachment #99878|0 |1 is obsolete|

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Katrin Fischer changed: What|Removed |Added Attachment #99879|0 |1 is obsolete|

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #14 from Jonathan Druart --- Created attachment 99879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99879=edit Bug 20728: Remove the 2 GetLastOrder* subroutines At this point the 2 subroutines are

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #13 from Jonathan Druart --- Created attachment 99878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99878=edit Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent There are 2

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Jonathan Druart changed: What|Removed |Added Attachment #99655|0 |1 is obsolete|

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #11 from Katrin Fischer --- From 0445ff47aea8cbe01e5fbb212aebe4885b65deb3 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 15 Mar 2019 19:24:19 -0300 Subject: [PATCH] Bug 20728: Proof that there is no cheating

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #9) > Please fix the commit messages :( What do you mean? All of them explain what they are doing. With comment 0 and the 3 commit titles,

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #8 from Jonathan Druart --- (In reply to Martin Renvoize from comment #7) > Works as expected without regressions. > > I'm not entirely sure I like that we're moving from a tested method to an > untested controller,

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Martin Renvoize changed: What|Removed |Added Attachment #86695|0 |1 is obsolete|

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Martin Renvoize changed: What|Removed |Added Attachment #86694|0 |1 is obsolete|

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Martin Renvoize changed: What|Removed |Added Attachment #86693|0 |1 is obsolete|

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #1 from Jonathan Druart --- Created attachment 86693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86693=edit Bug 20728: Proof that there is no cheating -- You are receiving this mail because: You

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #2 from Jonathan Druart --- Created attachment 86694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86694=edit Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent -- You are

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #3 from Jonathan Druart --- Created attachment 86695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86695=edit Bug 20728: Remove the 2 GetLastOrder* subroutines -- You are receiving this mail

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Bug 20728 depends on bug 20726, which changed state. Bug 20726 Summary: Display acquisition details on the subscription detail page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20726 What|Removed

[Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder*

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Jonathan Druart changed: What|Removed |Added Depends on|20276