https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
pierre.ge...@biblibre.com changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #54 from Julian Maurice ---
(In reply to Fridolin Somers from comment #53)
> Why call _cache() ? I cant find this method
That's how it's done on master. It's in C4/Reserves.pm
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #53 from Fridolin Somers ---
+unless ( $params->{ignore_onshelfholds_policy} ) {
+unless ( IsOnShelfHoldsPolicySatisfied( { item => $item, patron =>
$patron } ) ) {
+return _cache { status =>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #52
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Julian Maurice changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Julian Maurice changed:
What|Removed |Added
Attachment #121485|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
mathieu saby changed:
What|Removed |Added
CC||mathsaby...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Nick Clemens changed:
What|Removed |Added
Blocks||30845
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Shi Yao Wang changed:
What|Removed |Added
CC||shi-yao.w...@inlibro.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Shi Yao Wang changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #49 from Fridolin Somers ---
(In reply to Fridolin Somers from comment #47)
> +# Check for item on shelves and OnShelfHoldsAllowed
> +return { status => 'onShelfHoldsNotAllowed' }
> +unless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Fridolin Somers changed:
What|Removed |Added
Blocks|19294 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #47 from Fridolin Somers ---
+# Check for item on shelves and OnShelfHoldsAllowed
+return { status => 'onShelfHoldsNotAllowed' }
+unless IsAvailableForItemLevelRequest($item, $patron,
$pickup_branchcode,1);
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Jonathan Druart changed:
What|Removed |Added
Text to go in the|This bug fixes the "On |This bug fixes the "On
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #45 from Arthur Suzuki ---
Joubu, can you revert? otherwise I cannot apply to master (conflicts) + if
solving the problem in master i'm afraid to run into issues applying the patch
afterward (fake ancestor).
Thanks
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #44 from Jonathan Druart ---
There are tons of tests failing.
t/db_dependent/Holds.t, t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t,
t/db_dependent/api/v1/holds.t, t/db_dependent/ILSDI_Services.t and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #43 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #42 from Kyle M Hall ---
Created attachment 121486
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121486=edit
Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved
The expected behaviour for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Kyle M Hall changed:
What|Removed |Added
Attachment #121185|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #40 from Arthur Suzuki ---
Thx!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
Attachment #121139|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
Attachment #121176|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #37 from David Nind ---
> Should work now.
Everything works now - sign off on the way..
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #36 from Arthur Suzuki ---
Hi David,
Can you retry? seems the patches have to be uploaded in the proper order to be
applied the same...
Should work now.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #121102|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #34 from David Nind ---
Path no longer applies 8-(...
error: sha1 information is lacking or useless (t/db_dependent/Reserves.t).
error: could not build fake ancestor
Patch failed at 0001 Bug 20985: Add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #33 from Arthur Suzuki ---
Hi David,
just pushed a new version of the test patch with number of tests updated.
Arthur
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #121100|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #31 from David Nind ---
Hi Arthur.
I quickly ran through the test plan.
Everything works as expected, except the tests fail.
If I manually update the number of tests to 68, everything passes.
David
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #121101|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #115733|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #115732|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Joonas Kylmälä changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Depends on|25408 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
Text to go in the||This bug fixes the "On
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
Attachment #114805|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
Attachment #114804|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #23 from Arthur Suzuki ---
applied recommended changes and rebased on current master
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #22 from Arthur Suzuki ---
Created attachment 114805
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114805=edit
Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved
The expected behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #114801|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #20 from Arthur Suzuki ---
Created attachment 114802
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114802=edit
Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved
The expected behaviour
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #113730|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #17 from Arthur Suzuki ---
Created attachment 113731
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113731=edit
Bug 20985: Add OnShelfHoldsAllowed checks to CanItemBeReserved
Expected behaviour for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #111954|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
CC|da...@davidnind.com |
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
Attachment #112688|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #14 from David Nind ---
Created attachment 112688
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112688=edit
Bug 25898: Fix indirect object notation in debian/list-deps
There's a Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #110095|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Nick Clemens changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #105991|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Joonas Kylmälä changed:
What|Removed |Added
CC||joonas.kylm...@helsinki.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #89723|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Depends on||25408
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #7 from Hayley Mapley ---
Hi Arthur,
Looks good, only the description is not displayed in the Hold column of the
item table when the 'On shelf holds allowed' preference is set to 'If all
unavailable'. It is shown though
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #6 from Arthur Suzuki ---
(In reply to Hayley Mapley from comment #3)
> This patch results in a runtime error. Here are the steps I followed which
> led to the error.
>
> - Checked default circulation rule -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Attachment #86874|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Nick Clemens changed:
What|Removed |Added
CC||julian.maur...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Hayley Mapley changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |arthur.suz...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
--- Comment #2 from Arthur Suzuki ---
Created attachment 86874
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86874=edit
Bug 20985 : Add OnShelfHoldsAllowed checks to CanItemBeReserved
Test plan :
1 / Check that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
Blocks||19294
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Arthur Suzuki changed:
What|Removed |Added
CC||arthur.suz...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
Jonathan Druart changed:
What|Removed |Added
CC|
78 matches
Mail list logo