[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Katrin Fischer changed: What|Removed |Added Text to go in the|This patch adds a system|This patch adds a system

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Fridolin Somers changed: What|Removed |Added Blocks||30814 Referenced Bugs:

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29152 Referenced

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Nick Clemens changed: What|Removed |Added Blocks||28847 Referenced Bugs:

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #56 from David Cook --- (In reply to Fridolin Somers from comment #55) > Nice. > > Just, preference description seems incorect : > both: "home library and holding library." > >

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #54 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #53 from Victor Grousset/tuxayo --- Great to have this going :D btw, great test plan Aleisha it helped a lot -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What|Removed |Added Blocks||28295 Referenced Bugs:

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #52 from Jonathan Druart --- I am willing to push this enhancement as it, given its age. But please keep in mind that we must avoid copy/paste, here we have ~40 lines of the exact same code in 2 different files. That

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |dc...@prosentient.com.au

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120572|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120571|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120570|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120569|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120568|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Attachment #120567|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #45 from David Cook --- I am getting 1 fail in the QA tools but it seems minor to me. I'm leaving it to the RM to squash if necessary. -- root@kohadevbox:koha(bug_21249)$ qa testing 6 commit(s) (applied to 640ba47 'cf

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117223|0 |1 is

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #120481|0 |1 is

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117224|0 |1 is

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117222|0 |1 is

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117221|0 |1 is

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #117220|0 |1 is

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #37 from Aleisha Amohia --- Created attachment 120481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120481=edit Bug 21249: (follow-up) Adding parentheses to fix query -- You are receiving this mail

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #36

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #35 from David Cook --- This is on my test list. Just haven't gotten to it yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #34 from Aleisha Amohia --- Created attachment 117224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117224=edit Bug 21249: (follow-up) Implement SearchLibraryLimit for individual library before this

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Attachment #103622|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Attachment #103620|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Attachment #103619|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Attachment #103618|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #29 from David Cook --- (In reply to Aleisha Amohia from comment #25) > > Code is duplicated but no idea where we could move it to. > I'd suggest something like Koha::Search or a Koha::Search::Something submodule and

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Andrew Fuerste-Henry changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Attachment #95100|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #26 from Aleisha Amohia --- Created attachment 103621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103621=edit Bug 21249: (follow-up) Fixing syspref name, description, get working with OPAC masthead

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Attachment #95099|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Attachment #95101|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Attachment #103621|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Aleisha Amohia changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |alei...@catalyst.net.nz

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Patch doesn't apply

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #21 from Martin Renvoize --- Would love to see this picked back up near the beginning of the next cycle.. I'm afraid it's just missed the freeze for 19.11 :( -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Martin Renvoize changed: What|Removed |Added Keywords|rel_19_11_candidate |rel_20_05_target

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What|Removed |Added Attachment #93345|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #19 from Jonathan Druart --- Created attachment 95101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95101=edit Bug 21249: Code cleaning Trying to make the code a bit more readable removing

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #18 from Jonathan Druart --- Created attachment 95100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95100=edit Bug 21249: Made the SQL INSERT statement idempotent Sponsored-BY: Brimbank Library,

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Katrin Fischer changed: What|Removed |Added Keywords||rel_19_11_candidate

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #14 from sandbo...@biblibre.com --- Created attachment 93345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93345=edit Bug 21249: New syspref controlling branch fields queried against selected library

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #15 from sandbo...@biblibre.com --- Created attachment 93346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93346=edit Bug 21249: Made the SQL INSERT statement idempotent Sponsored-BY: Brimbank

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 sandbo...@biblibre.com changed: What|Removed |Added Attachment #82138|0 |1 is

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 sandbo...@biblibre.com changed: What|Removed |Added Attachment #83518|0 |1 is

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Brian changed: What|Removed |Added CC||bkl...@dubuque.lib.ia.us ---

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #11 from Alex Buckley --- Created attachment 83518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83518=edit Bug 21249: Made the SQL INSERT statement idempotent Sponsored-BY: Brimbank Library,

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #10 from Alex Buckley --- Hi Michael, Are you able to retest please,? This still applies cleanly on master. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #9 from Alex Buckley --- I have also amended the test plan in the commit accordingly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #8 from Alex Buckley --- Hi Michal I have found what you have to do is create a Library group then click 'Actions->Add sub-group' Give your sub group a name and then add the library branches to the subgroup. The

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #7 from Alex Buckley --- Created attachment 82138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82138=edit Bug 21249: New syspref controlling branch fields queried against selected library group value

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Alex Buckley changed: What|Removed |Added Attachment #78921|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com ---

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #5 from Alex Buckley --- Rebased against master on 16th of sept 2018. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #4 from Alex Buckley --- Created attachment 78921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78921=edit Bug 21249 - New syspref controlling branch fields queried against selected library group

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Alex Buckley changed: What|Removed |Added Attachment #78014|0 |1 is obsolete|

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #3 from Alex Buckley --- Any chance we can move this along? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Alex Buckley changed: What|Removed |Added Summary|Syspref to choose whether |Syspref to choose whether