https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Katrin Fischer changed:
What|Removed |Added
Text to go in the||This adds a new free text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Status|Needs documenting |RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|additional_work_needed |
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #128 from Martin Renvoize ---
Aha, I see.. I'm a little out of date then.. I tended to track D10 as I thought
it was still the most complete run.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #127 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #126)
> Patch makes sense.. why is this only failing on D11 though and not any of
> the other runs?
D11 is the only job that has LIGHT_RUN=0 and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #126 from Martin Renvoize ---
Patch makes sense.. why is this only failing on D11 though and not any of the
other runs?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #125 from Martin Renvoize ---
I only see TestBuilder failures on Jenkins at the moment.. so hadn't spotted
this no... thanks for the patch.. I'll take a look to confirm it makes sense
now.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #124 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #122)
> Created attachment 137612 [details] [review]
> Bug 21978: Fix Selenium tests
This patch is messy but makes the tests pass. I think the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #123 from Jonathan Druart ---
Is watching the CI after pushing still a thing or...? :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #122 from Jonathan Druart ---
Created attachment 137612
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137612=edit
Bug 21978: Fix Selenium tests
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #121 from Jonathan Druart ---
Did you notice that t/db_dependent/selenium/patrons_search.t was failing?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #120 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #119 from Christopher Brannon ---
Passed QA! This is a huge step forward! This has been needed for so long!
Thank you Martin for this much needed field! I am really looking forward to
seeing it in production!
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135189|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135188|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135187|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135186|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135185|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135184|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135183|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135182|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135181|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #135180|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #108 from Martin Renvoize ---
Looks great to me Jonathan, thanks for the follow-up
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #107 from Jonathan Druart ---
Do you agree with this last patch, Martin?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #106 from Jonathan Druart ---
Created attachment 135189
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135189=edit
Bug 21978: Add middle_name to sysprefs.sql
And add middle_name at the exact same
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #105 from Jonathan Druart ---
Created attachment 135188
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135188=edit
Bug 21978: (follow-up) Stop using C4 methods in atomicupdate
We should really only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #104 from Jonathan Druart ---
Created attachment 135187
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135187=edit
Bug 21978: (follow-up) Stop passing holdfor_cardnumber
We not longer need to pass
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #103 from Jonathan Druart ---
Created attachment 135186
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135186=edit
Bug 21978: Use patron-title for holdfor handling in results
This patch update the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #102 from Jonathan Druart ---
Created attachment 135185
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135185=edit
Bug 21978: Use patron-title.inc in request.tt
This patch updates all manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #101 from Jonathan Druart ---
Created attachment 135184
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135184=edit
Bug 21978: Add middle_name into hold request autocomplete
Signed-off-by: Sally
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #100 from Jonathan Druart ---
Created attachment 135183
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135183=edit
Bug 21978: Schema Update
Signed-off-by: Sally
Signed-off-by: Jonathan Druart
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #99 from Jonathan Druart ---
Created attachment 135182
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135182=edit
Bug 21978: Add support for middle name
This patch adds the new 'Middle name' field to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #98 from Jonathan Druart ---
Created attachment 135181
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135181=edit
Bug 21978: Add middle_name to api specification
This patch adds middle_name to the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Jonathan Druart changed:
What|Removed |Added
Attachment #135147|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #96 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #83 and #84)
* Spacing fixed and squashed
* Indents fixed and squashed
* Follow-up added to drop passing for holdfor_cardnumber. Original reason for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #95 from Martin Renvoize ---
Created attachment 135155
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135155=edit
Bug 21978: (follow-up) Stop using C4 methods in atomicupdate
We should really only use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #94 from Martin Renvoize ---
Doh, I missed the first comment.. brb
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #93 from Martin Renvoize ---
Created attachment 135154
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135154=edit
Bug 21978: (follow-up) Stop passing holdfor_cardnumber
We not longer need to pass
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134751|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134750|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134749|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134748|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134747|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134746|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134745|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #84 from Jonathan Druart ---
* request.tt l. 384 not correctly indented
* In last patch:
-holdfor => $query->cookie("holdfor"),
-holdfor_surname => $holdfor_patron->surname,
-holdfor_firstname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #83 from Jonathan Druart ---
Please adjust "Bug 21978: Use patron-title.inc in request.tt" to be consistent
with spaces:
-No holds allowed:
+No
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Victor Grousset/tuxayo changed:
What|Removed |Added
Patch complexity|--- |Medium patch
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Sally changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #81 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #134503|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #134502|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #134501|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #134500|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #134499|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #134498|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #134497|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134495|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134259|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134258|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134257|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134256|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134255|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #134254|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #66 from Martin Renvoize ---
Hi Sally,
I've resolved the autocomplete issue you mentioned.. and have added another
follow-up to correct the mentioned display issue.
I have a feeling if you dig too deeply you'll find a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #65 from Martin Renvoize ---
Created attachment 134495
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134495=edit
Bug 21978: Use patron-title for holdfor handling in results
This patch update the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Sally changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #64 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #63 from Martin Renvoize ---
Rebased and added the sponsorship line
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133757|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133756|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133755|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133754|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133753|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133752|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #56 from Martin Renvoize ---
Not to self, add in 'Sponsored-by: Cheshire Libraries' line.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Blocks||30617
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133751|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #54 from Martin Renvoize ---
Created attachment 133757
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133757=edit
Bug 21978: Use patron-title.inc in request.tt
This patch updates all manual accurences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #53 from Martin Renvoize ---
Created attachment 133756
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133756=edit
Bug 21978: Add middle_name into hold request autocomplete
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133547|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133546|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133545|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133544|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #48 from Martin Renvoize ---
Created attachment 133751
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133751=edit
Bug 30576: Use DefaultPatronSearchFields in patron search
This patch corrects the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #47 from Christopher Brannon ---
Otherwise, everything else looked great. Searching was not a problem. Just a
few missed areas, and the controls are just not all there for mandatory or
unwanted preferences.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Christopher Brannon changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #45 from Martin Renvoize ---
I'm reconsidering whether this should be hard coded to be included in the
autocomplete searches. Those searches only allow for ten results at a time and
adding another field into the mix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
--- Comment #44 from Martin Renvoize ---
Added 30576 as a dependency here and rebased appropriately. That should fix
the DefaultPatronSearchFields preference handling.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133537|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133536|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978
Martin Renvoize changed:
What|Removed |Added
Attachment #133535|0 |1
is obsolete|
1 - 100 of 152 matches
Mail list logo