https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
Eric Phetteplace changed:
What|Removed |Added
CC||ephettepl...@cca.edu
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
Magnus Enger changed:
What|Removed |Added
Severity|enhancement |normal
--- Comment #11 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
Katrin Fischer changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
--- Comment #10 from Magnus Enger ---
I think the counts are also influenced by this bug:
Bug 20567 - "Holds per record (count)" limit is not enforced after item is
captured for hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
Magnus Enger changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
--- Comment #9 from Magnus Enger ---
(In reply to Magnus Enger from comment #7)
> this patch on current master, running prove on the tests should *FAIL*.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
--- Comment #8 from Magnus Enger ---
Created attachment 103251
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103251=edit
Bug 22005 - DecreaseLoanHighHolds counts holds wrong
There is a small error in how holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
--- Comment #7 from Magnus Enger ---
Created attachment 103250
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103250=edit
Bug 22005 - DecreaseLoanHighHolds counts holds wrong
This patch adds some more comments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
Magnus Enger changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
--- Comment #6 from Magnus Enger ---
I had a long stare at the code around this, and by fleshing out the tests a bit
more I think I was able to find and fix a small bug. Will submit a patch for
this in a minute.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
--- Comment #5 from Magnus Enger ---
(In reply to Kelly McElligott from comment #0)
> When using the system preference decreaseLoanHighHolds, if a library has
> this set to 1 hold. Then when the 1 person that has a hold on this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
--- Comment #4 from Magnus Enger ---
I really don't understand the logic of the CheckHighHolds sub:
sub checkHighHolds {
my ( $item, $borrower ) = @_;
...
if ( $holds->count() ) {
...
if (
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
--- Comment #3 from Magnus Enger ---
A couple of tests seem to be failing for me:
$ sudo koha-shell -c "prove -v t/db_dependent/DecreaseLoanHighHolds.t" kohadev
t/db_dependent/DecreaseLoanHighHolds.t ..
1..17
ok 1 - userenv set
ok
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
Magnus Enger changed:
What|Removed |Added
CC||mag...@libriotech.no
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005
Jeff Brown changed:
What|Removed |Added
CC||j.j.br...@lboro.ac.uk
---
17 matches
Mail list logo