[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2023-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu --

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-12-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Magnus Enger changed: What|Removed |Added Severity|enhancement |normal --- Comment #11 from

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 --- Comment #10 from Magnus Enger --- I think the counts are also influenced by this bug: Bug 20567 - "Holds per record (count)" limit is not enforced after item is captured for hold

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Magnus Enger changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 --- Comment #9 from Magnus Enger --- (In reply to Magnus Enger from comment #7) > this patch on current master, running prove on the tests should *FAIL*. -- You are receiving this mail because: You are the assignee for the bug.

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 --- Comment #8 from Magnus Enger --- Created attachment 103251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103251=edit Bug 22005 - DecreaseLoanHighHolds counts holds wrong There is a small error in how holds

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 --- Comment #7 from Magnus Enger --- Created attachment 103250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103250=edit Bug 22005 - DecreaseLoanHighHolds counts holds wrong This patch adds some more comments

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 --- Comment #6 from Magnus Enger --- I had a long stare at the code around this, and by fleshing out the tests a bit more I think I was able to find and fix a small bug. Will submit a patch for this in a minute. -- You are

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 --- Comment #5 from Magnus Enger --- (In reply to Kelly McElligott from comment #0) > When using the system preference decreaseLoanHighHolds, if a library has > this set to 1 hold. Then when the 1 person that has a hold on this

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 --- Comment #4 from Magnus Enger --- I really don't understand the logic of the CheckHighHolds sub: sub checkHighHolds { my ( $item, $borrower ) = @_; ... if ( $holds->count() ) { ... if (

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 --- Comment #3 from Magnus Enger --- A couple of tests seem to be failing for me: $ sudo koha-shell -c "prove -v t/db_dependent/DecreaseLoanHighHolds.t" kohadev t/db_dependent/DecreaseLoanHighHolds.t .. 1..17 ok 1 - userenv set ok

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no ---

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2020-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds

2019-06-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Jeff Brown changed: What|Removed |Added CC||j.j.br...@lboro.ac.uk ---